Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp509990ybg; Fri, 18 Oct 2019 03:16:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPPJrvGgCU6fCDrhdN4/FyDhakK+me8sIXhECcl4+le9A0mjvuRaEx4Uo1Yc1ezA510xv8 X-Received: by 2002:a17:906:538a:: with SMTP id g10mr7709039ejo.94.1571393802811; Fri, 18 Oct 2019 03:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571393802; cv=none; d=google.com; s=arc-20160816; b=f/fnalPfg5/Y3MS/d9vzCSIdJ6UbCJthAFPmVfU/usvkJ7QYiaTu/De09VujVbFwP1 QAj8jza8W4qoOYdWyf1cgSOpw4oXGRIAu9hE54qNVw3iK0dz820/EpWmGK6NhcaP9QMI ePXWybX59MplndXQfSuysQRgBIvS+Y0lCASvpnZTZSfA8KBNXuu+oDXt7QrytB+XjJfd uPVSg4F8Ph7KYLpuC3dJZKJlhXcWtJTVJdBRZFK6/s1a6PmuYYShxOYwLt6e+ETT+qZL EvyjBOQ6QbDoR8FBtSlEpJOpEZrNS0RFjHHuVMejFjBZl7gbf18dymXj3/qxTpy6OW/r ZuZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=4df2TAlI68WOpkNRQpEUHxAsdJdfhE7sL4M8N3p8Axk=; b=wT5yISLZrxg7AprgqayIw0Ce/wc//eCblIgRcXnH2//uBMrYqqs4rhsvu3WkW30AXo x5VFR6LFqmsRPzHAG2S0inAQWv3oS/b5hk5dUnaUr+ba6n/ey0nc9PbQ7juvhETew+A2 w39p19EUuKgLj08yd8rP2r51Ehth2OmRr7GUPDm0fFAf3fEMe3m/tT6yISkSlP0aAX03 tffGHVYKNzKu2HwLgUH04kh0ATPWIGP1uhvuVc56bLEo3Z6lE7+Fl2Mczk5/ZdkCqCdw wZXeovCHG/fwtDCBWqGTenMVqA6LLm6ybAkAcBkm8r+SgsYD1sTtsBBKX/nWHI4L0kMI M81w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s42si3419868edm.292.2019.10.18.03.16.19; Fri, 18 Oct 2019 03:16:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393317AbfJQI2N (ORCPT + 99 others); Thu, 17 Oct 2019 04:28:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57518 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389585AbfJQI2M (ORCPT ); Thu, 17 Oct 2019 04:28:12 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6813018CB90E; Thu, 17 Oct 2019 08:28:11 +0000 (UTC) Received: from [10.72.12.185] (ovpn-12-185.pek2.redhat.com [10.72.12.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6719F60BE1; Thu, 17 Oct 2019 08:27:43 +0000 (UTC) Subject: Re: [PATCH V3 1/7] mdev: class id support To: Parav Pandit , "kvm@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "intel-gvt-dev@lists.freedesktop.org" , "kwankhede@nvidia.com" , "alex.williamson@redhat.com" , "mst@redhat.com" , "tiwei.bie@intel.com" Cc: "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "cohuck@redhat.com" , "maxime.coquelin@redhat.com" , "cunming.liang@intel.com" , "zhihong.wang@intel.com" , "rob.miller@broadcom.com" , "xiao.w.wang@intel.com" , "haotian.wang@sifive.com" , "zhenyuw@linux.intel.com" , "zhi.a.wang@intel.com" , "jani.nikula@linux.intel.com" , "joonas.lahtinen@linux.intel.com" , "rodrigo.vivi@intel.com" , "airlied@linux.ie" , "daniel@ffwll.ch" , "farman@linux.ibm.com" , "pasic@linux.ibm.com" , "sebott@linux.ibm.com" , "oberpar@linux.ibm.com" , "heiko.carstens@de.ibm.com" , "gor@linux.ibm.com" , "borntraeger@de.ibm.com" , "akrowiak@linux.ibm.com" , "freude@linux.ibm.com" , "lingshan.zhu@intel.com" , Ido Shamay , "eperezma@redhat.com" , "lulu@redhat.com" , "christophe.de.dinechin@gmail.com" , "kevin.tian@intel.com" References: <20191011081557.28302-1-jasowang@redhat.com> <20191011081557.28302-2-jasowang@redhat.com> From: Jason Wang Message-ID: <67b645a6-1b70-094d-6a12-fc6591e07a13@redhat.com> Date: Thu, 17 Oct 2019 16:27:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Thu, 17 Oct 2019 08:28:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/16 下午12:57, Parav Pandit wrote: >> +static struct mdev_class_id id_table[] = { > static const > >> + { MDEV_ID_VFIO }, > I guess you don't need extra braces for each entry. > Since this enum represents MDEV class id, it better to name it as MDEV_CLASS_ID_VFIO. > (Similar to PCI_VENDOR_ID, PCI_DEVICE_ID).. > Gcc start to complain like: warning: missing braces around initializer [-Wmissing-braces]  static const struct mdev_class_id id_table[] = {                                                 ^   MDEV_ID_VFIO, 0,   {           } {  };  } So I will keep this part untouched. Thanks >> + { 0 }, >> +};