Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 17 Oct 2019 11:04:27 +0200
From:   Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To:     Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?S8Op?= =?UTF-8?B?dmlu?= RAYMOND 
        <k.raymond@overkiz.com>, Mickael GARDET <m.gardet@overkiz.com>
Subject: Re: [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file
Message-ID: <20191017110427.66bccdfb@windsurf>
In-Reply-To: <20191017085405.12599-3-kamel.bouhara@bootlin.com>
References: <20191017085405.12599-1-kamel.bouhara@bootlin.com>
        <20191017085405.12599-3-kamel.bouhara@bootlin.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Kamel,

On Thu, 17 Oct 2019 10:54:05 +0200
Kamel Bouhara <kamel.bouhara@bootlin.com> wrote:

> There are three different boards available depending on the PCB
> (3 antennas support and several revison). Add a dtsi file to share
> common binding between all kizbox2 boards.
> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> Signed-off-by: Kévin RAYMOND <k.raymond@overkiz.com>
> Signed-off-by: Mickael GARDET <m.gardet@overkiz.com>
> ---
>  arch/arm/boot/dts/Makefile                 |   6 +-
>  arch/arm/boot/dts/at91-kizbox.dts          | 173 +++++++-------

The changes to this file (change to use phandles) seem unrelated to the
current patch, unless I'm missing something.

>  arch/arm/boot/dts/at91-kizbox2-0.dts       |  17 ++
>  arch/arm/boot/dts/at91-kizbox2-1.dts       |  22 ++
>  arch/arm/boot/dts/at91-kizbox2-2.dts       |  26 +++
>  arch/arm/boot/dts/at91-kizbox2-3.dts       |  30 +++
>  arch/arm/boot/dts/at91-kizbox2-rev2.dts    |  34 +++
>  arch/arm/boot/dts/at91-kizbox2.dts         | 244 -------------------
>  arch/arm/boot/dts/at91-kizbox2_common.dtsi | 258 +++++++++++++++++++++

"-" seems to be a much more common separator for DT names, including in
this file, so what about at91-kizbox2-common.dtsi ?

> +// WMBUS (inverted with IO in the latest schematic)

I am not sure C++ comments are common in Device Tree files.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com