Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chengguang Xu <cgxu519@mykernel.net>
To:     mike.kravetz@oracle.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Chengguang Xu <cgxu519@mykernel.net>
Message-ID: <20191017103822.8610-1-cgxu519@mykernel.net>
Subject: [PATCH] hugetlbfs: fix error handling in init_hugetlbfs_fs()
Date:   Thu, 17 Oct 2019 18:38:22 +0800
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In order to avoid using incorrect mnt, we should set
mnt to NULL when we get error from mount_one_hugetlbfs().

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/hugetlbfs/inode.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index a478df035651..427d845e7706 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1470,9 +1470,12 @@ static int __init init_hugetlbfs_fs(void)
 =09i =3D 0;
 =09for_each_hstate(h) {
 =09=09mnt =3D mount_one_hugetlbfs(h);
-=09=09if (IS_ERR(mnt) && i =3D=3D 0) {
-=09=09=09error =3D PTR_ERR(mnt);
-=09=09=09goto out;
+=09=09if (IS_ERR(mnt)) {
+=09=09=09if (i =3D=3D 0) {
+=09=09=09=09error =3D PTR_ERR(mnt);
+=09=09=09=09goto out;
+=09=09=09}
+=09=09=09mnt =3D NULL;
 =09=09}
 =09=09hugetlbfs_vfsmount[i] =3D mnt;
 =09=09i++;
--=20
2.20.1