Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp876764ybg; Fri, 18 Oct 2019 08:40:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzqAs1lgPn3qfWBha+/oVFM8wqVcFP5u9JSohvLRk4DqAUv8v5Lge6BJtfwPhB+wrW6rUPJ X-Received: by 2002:a50:9a46:: with SMTP id o64mr10371490edb.191.1571413207685; Fri, 18 Oct 2019 08:40:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571413207; cv=none; d=google.com; s=arc-20160816; b=Mi5ff2GR/dt1VUlWxv1NHX0WMCazxeZPm9iquX/2dz6270GyCIVxgFua8IGKwFN3no fHTgNi2fSv+nse7ILXZoIi7kwVLxPQeDLFjkeoH3wmMQxbFXHHeBIkWE3V1/ELRL+R0E slm+BNzdoSYoqivfeuY1px4+BD0APqloypUpkAXLWmMp7h+SBqyBL0RLbU/2qekUs6cO vw9zMMIq/cxTzO96KMXmE64uOkfJGNl1/1kdTc/ezmdWrjL8tjk5RGL9DgWNoHVz6HyG HDnUnL08zqDyr+HN40Bt8sA/PRtLPeqJaNfUNsUuc6YRWMFcgtpAAIr1O0SwZDjGaZT5 7u4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=imPKS+WeN7jc/rlmjknoRggYFjGqwhycRGJDY75fL3M=; b=ZeTYRTlwAa4Bnc0mucNfXQDRVRdxVWFYpXYuv8mwCpipTTMWusVSJVONKid2W1yc9W r6kKa+JIYJGpzqEOrWPxlANCGZIYz0mtbwk28nFZ55l2ym7XOeMgk/WlTFe8R8q5737M VYpIv93vSoWyN3+RKgOX4CnAiXPqiXpir0uIZf/8P87aBPmWPe0lSYvpJyCTVbzUEzsQ c7UfyqaRs9i0U8FWh7G6Jx1gCYNtd9gHDjj+fLL2kMVkPpoDBBBODWXd95dgPaQSoHiU fcaj8fqpjPOv/Ha16hedGStERXaXUqnKNgIrMAl1cvgQcbfHM7HmingQxuK3muRo4UhK g/vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d15si4042667edb.7.2019.10.18.08.39.44; Fri, 18 Oct 2019 08:40:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439671AbfJQLSD (ORCPT + 99 others); Thu, 17 Oct 2019 07:18:03 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:52998 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439661AbfJQLSD (ORCPT ); Thu, 17 Oct 2019 07:18:03 -0400 Received: from [167.98.27.226] (helo=rainbowdash.codethink.co.uk) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iL3n3-0002yw-Kr; Thu, 17 Oct 2019 12:17:57 +0100 Received: from ben by rainbowdash.codethink.co.uk with local (Exim 4.92.2) (envelope-from ) id 1iL3n2-0003MI-WD; Thu, 17 Oct 2019 12:17:57 +0100 From: "Ben Dooks (Codethink)" To: linux-kernel@lists.codethink.co.uk Cc: "Ben Dooks (Codethink)" , Liviu Dudau , Brian Starkey , David Airlie , Daniel Vetter , malidp@foss.arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/arm: make undeclared items static Date: Thu, 17 Oct 2019 12:17:55 +0100 Message-Id: <20191017111756.12861-1-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make the following items static to avoid clashes with other parts of the kernel (dev_attr_core_id) or just silence the following sparse warning: drivers/gpu/drm/arm/malidp_drv.c:371:24: warning: symbol 'malidp_fb_create' was not declared. Should it be static? drivers/gpu/drm/arm/malidp_drv.c:494:6: warning: symbol 'malidp_error_stats_dump' was not declared. Should it be static? drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Liviu Dudau Cc: Brian Starkey Cc: David Airlie Cc: Daniel Vetter Cc: malidp@foss.arm.com Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org .. (open list) --- drivers/gpu/drm/arm/malidp_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 333b88a5efb0..18ca43c9cef4 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -368,7 +368,7 @@ malidp_verify_afbc_framebuffer(struct drm_device *dev, struct drm_file *file, return false; } -struct drm_framebuffer * +static struct drm_framebuffer * malidp_fb_create(struct drm_device *dev, struct drm_file *file, const struct drm_mode_fb_cmd2 *mode_cmd) { @@ -491,9 +491,9 @@ void malidp_error(struct malidp_drm *malidp, spin_unlock_irqrestore(&malidp->errors_lock, irqflags); } -void malidp_error_stats_dump(const char *prefix, - struct malidp_error_stats error_stats, - struct seq_file *m) +static void malidp_error_stats_dump(const char *prefix, + struct malidp_error_stats error_stats, + struct seq_file *m) { seq_printf(m, "[%s] num_errors : %d\n", prefix, error_stats.num_errors); @@ -665,7 +665,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr, return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id); } -DEVICE_ATTR_RO(core_id); +static DEVICE_ATTR_RO(core_id); static int malidp_init_sysfs(struct device *dev) { -- 2.23.0