Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191017110225.30841-1-ben.dooks@codethink.co.uk> <25bb4857-950e-592a-b2ba-7730867742b3@redhat.com>
In-Reply-To: <25bb4857-950e-592a-b2ba-7730867742b3@redhat.com>
From:   Andreas Gruenbacher <agruenba@redhat.com>
Date:   Thu, 17 Oct 2019 14:46:19 +0200
Message-ID: <CAHc6FU7V6PK4OhzqiELiG8cXi5jhpV7whe5Dx5jbL_69LxzUpg@mail.gmail.com>
Subject: Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
To:     Andrew Price <anprice@redhat.com>
Cc:     "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
        linux-kernel@lists.codethink.co.uk,
        cluster-devel <cluster-devel@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 17, 2019 at 1:42 PM Andrew Price <anprice@redhat.com> wrote:
> On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> > The gfs2_fs_parameters is not used outside the unit
> > it is declared in, so make it static.
> >
> > Fixes the following sparse warning:
> >
> > fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
> >
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > ---
> > Cc: Bob Peterson <rpeterso@redhat.com>
> > Cc: Andreas Gruenbacher <agruenba@redhat.com>
> > Cc: cluster-devel@redhat.com
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >   fs/gfs2/ops_fstype.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> > index 681b44682b0d..ebdef1c5f580 100644
> > --- a/fs/gfs2/ops_fstype.c
> > +++ b/fs/gfs2/ops_fstype.c
> > @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> >       {}
> >   };
> >
> > -const struct fs_parameter_description gfs2_fs_parameters = {
> > +static const struct fs_parameter_description gfs2_fs_parameters = {
> >       .name = "gfs2",
> >       .specs = gfs2_param_specs,
> >       .enums = gfs2_param_enums,
> >
>
> Looks good to me.

Andy, I've added a reviewed-by tag for you and pushed this to for-next.

Thanks,
Andreas