Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp898060ybg; Fri, 18 Oct 2019 08:59:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyh6lOkqbQrS4zZH16umh07uJgmYRjM8z75pRMpuflyS2UPw13GeOj5bhaFgr8/pMwLjC46 X-Received: by 2002:a17:906:7f03:: with SMTP id d3mr9577772ejr.209.1571414386803; Fri, 18 Oct 2019 08:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571414386; cv=none; d=google.com; s=arc-20160816; b=F68LpsoWn6PAFgeYGM25YfBwh7L0fc6XWVHCtawPymdv4/6jd8yCtiGsmnjUTfg/1L WZOk89pUTUnK3QPbswg4NtqtfE9MKjmGu+qD0qvvp1H44jYnyMIytduV4JTWQO0wdJxj s2s+IjM8zLdechokdF13tgRa547/oXXusJrFhD89k3RZaYZzyfiWueFLW+vK2UmS/LGQ p0JWxDy1Jk7wAfEbDq/WYm+XW2EG0mClOA+ecMQ+iTLMMlcp/aVOYfhGUnaIvANs0jZu 8wgRRgS+DxS5hTfnRD6Tl5rbUiZMiVkwQOOHkCCA9KW5pnQy9iSD4nX9HFiVJ3KjFCa+ C0Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rC8bs724wQUQJHgz+QqZKrZ1svu9wnLcV6k9kWY3n/s=; b=UJ5V+eor0YQ7R7KSn90mV9AQSPQ8hnnmvfjeOERvluPkGJDcdPAP9uzs7KejULpAqG hgcwQ3fRfbggIrz3sSaSvkb/feb2lP+KVsl4uIImjJKqSoL0brI7xORyGV780BRwiJx5 C4gsZTUaJMQrGUCvHohy3nlP1UrHcdJSM9HGCbey7EBRjsowtA2aI/3nC75b9+Zuoqh1 jbxCkUoJPkG+dBMGcL7e8DlxlXQT11NMVis8euD8DMw8d5Y+lffSBGBhpdLO552ZJOFo XWKPSKLoZqJ5pjFECGwEbnKH2D7GmHWvYM9fPhx6nW+cELT2rf5vousJzOgs35SOrlNk jZCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 22si3686076ejz.218.2019.10.18.08.59.23; Fri, 18 Oct 2019 08:59:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394085AbfJQNFy (ORCPT + 99 others); Thu, 17 Oct 2019 09:05:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:50738 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726898AbfJQNFx (ORCPT ); Thu, 17 Oct 2019 09:05:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CD714AFC1; Thu, 17 Oct 2019 13:05:51 +0000 (UTC) Date: Thu, 17 Oct 2019 15:05:50 +0200 From: Petr Mladek To: Kefeng Wang Cc: Linus Torvalds , Arnd Bergmann , Andy Whitcroft , "DavidS. Miller" , Sergey Senozhatsky , Peter Zijlstra , Daniel Borkmann , AlexeiStarovoitov , Andrew Morton , GregKroah-Hartman , Joe Perches , ArnaldoCarvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code Message-ID: <20191017130550.nwswlnwdroyjwwun@pathway.suse.cz> References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2019-10-08 14:39:32, Kefeng Wang wrote: > Hi all, > > On 2019/10/2 16:55, Petr Mladek wrote: > > Linus, > > > > On Fri 2019-09-20 14:25:12, Kefeng Wang wrote: > >> There are pr_warning and pr_warng to show WARNING level message, > >> most of the code using pr_warn, number based on next-20190919, > >> > >> pr_warn: 5189 pr_warning: 546 (tools: 398, others: 148) > > > > The ratio is 10:1 in favor of pr_warn(). It would make sense > > to remove the pr_warning(). > > > > Would you accept pull request with these 32 simple patches > > for rc2, please? > > > > Alternative is to run a simple sed. But it is not trivial > > to fix indentation of the related lines. > > Kindly ping, should I respin patches with comments fixed? > Is the patchset acceptable, hope to be clear that what to do next :) I am going to check how many conflicts appeared in linux-next. If there are only few then I'll take it via printk.git. This way we get proper indentation and other changes. If there are too many conflicts then I'll ask Linus to do a mass change using a script. I am sorry for late reply. I have never pushed such a mass change. I hoped that anyone more experienced will provide some opinion ;-) Best Regards, Petr