Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] dt-bindings: watchdog: Convert stm32 watchdog bindings to
 json-schema
To:     Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>
Cc:     "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20191017124159.13869-1-benjamin.gaignard@st.com>
 <63f96a2f-78c0-21ae-781b-e52068f57103@st.com>
 <6597f899-f049-02dc-de59-07a0f23a88b8@st.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <d0c1af15-a647-8d80-81c9-fc07b926856c@roeck-us.net>
Date:   Thu, 17 Oct 2019 06:31:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <6597f899-f049-02dc-de59-07a0f23a88b8@st.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/17/19 6:17 AM, Benjamin GAIGNARD wrote:
> 
> On 10/17/19 3:06 PM, Alexandre Torgue wrote:
>> Hi Benjamin
>>
>> On 10/17/19 2:41 PM, Benjamin Gaignard wrote:
>>> Convert the STM32 watchdog binding to DT schema format using json-schema
>>>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>>> ---
>>>    .../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 -----------
>>>    .../bindings/watchdog/st,stm32-iwdg.yaml           | 54
>>> ++++++++++++++++++++++
>>>    2 files changed, 54 insertions(+), 26 deletions(-)
>>>    delete mode 100644
>>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>>>    create mode 100644
>>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>>> deleted file mode 100644
>>> index d8f4430b0a13..000000000000
>>> --- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>>> +++ /dev/null
>>> @@ -1,26 +0,0 @@
>>> -STM32 Independent WatchDoG (IWDG)
>>> ----------------------------------
>>> -
>>> -Required properties:
>>> -- compatible: Should be either:
>>> -  - "st,stm32-iwdg"
>>> -  - "st,stm32mp1-iwdg"
>>> -- reg: Physical base address and length of the registers set for the
>>> device
>>> -- clocks: Reference to the clock entry lsi. Additional pclk clock entry
>>> -  is required only for st,stm32mp1-iwdg.
>>> -- clock-names: Name of the clocks used.
>>> -  "lsi" for st,stm32-iwdg
>>> -  "lsi", "pclk" for st,stm32mp1-iwdg
>>> -
>>> -Optional Properties:
>>> -- timeout-sec: Watchdog timeout value in seconds.
>>> -
>>> -Example:
>>> -
>>> -iwdg: watchdog@40003000 {
>>> -    compatible = "st,stm32-iwdg";
>>> -    reg = <0x40003000 0x400>;
>>> -    clocks = <&clk_lsi>;
>>> -    clock-names = "lsi";
>>> -    timeout-sec = <32>;
>>> -};
>>> diff --git
>>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>>> new file mode 100644
>>> index 000000000000..edec96d53e6b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>>> @@ -0,0 +1,54 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
>>> +
>>> +maintainers:
>>> +  - Yannick Fertre <yannick.fertre@st.com>
>>
>> Yannick is still working on this driver ?
> 
> That is a good question.
> 
> Rob, can we use the STM32 dedicated mailing list address for this
> mainteners field ?
> 
> maintainers:
> 
> - linux STM32 <linux-stm32@st-md-mailman.stormreply.com>
> 


I'd rather wonder who is going to maintain this secondary distributed
maintainers list, but I guess that is a different question.

Guenter

> Regards,
> 
> Benjamin
> 
>>
>>> +
>>> +allOf:
>>> +  - $ref: "watchdog.yaml#"
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - st,stm32-iwdg
>>> +      - st,stm32mp1-iwdg
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: Low speed clock
>>> +      - description: Optional peripheral clock
>>> +    minItems: 1
>>> +    maxItems: 2
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      enums: [ lsi, pclk ]
>>> +    minItems: 1
>>> +    maxItems: 2
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - clocks
>>> +  - clock-names
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/clock/stm32mp1-clks.h>
>>> +    watchdog@5a002000 {
>>> +      compatible = "st,stm32mp1-iwdg";
>>> +      reg = <0x5a002000 0x400>;
>>> +      clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
>>> +      clock-names = "pclk", "lsi";
>>> +      timeout-sec = <32>;
>>> +    };
>>> +
>>> +...
>> >