Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
        "linux-kernel@lists.codethink.co.uk" 
        <linux-kernel@lists.codethink.co.uk>
CC:     Antoine Tenart <antoine.tenart@bootlin.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: inside-secure - fix type of buffer in
 eip197_write_firmware
Thread-Topic: [PATCH] crypto: inside-secure - fix type of buffer in
 eip197_write_firmware
Thread-Index: AQHVhBfWMp/OQ1W3YkiqzB+SEDRBb6dfDogA
Date:   Thu, 17 Oct 2019 17:14:14 +0000
Message-ID: <MN2PR20MB29739F7E3C145AB915E4A2DECA6D0@MN2PR20MB2973.namprd20.prod.outlook.com>
References: <20191016114945.30451-1-ben.dooks@codethink.co.uk>
In-Reply-To: <20191016114945.30451-1-ben.dooks@codethink.co.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: verimatrix.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: afd25bc5-bc6a-4a23-e759-08d753256f7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2019 17:14:14.4652
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dcb260f9-022d-4495-8602-eae51035a0d0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t/1TdEPrvy/7lo8TVXxL4kYk5pGbKL2zcO5m41ifD8JUTgQL759k5fOGpA4jd2d3i9DrHP4+aEPxixhvtViZNM8QrO/eTYFWzHwHlZ5VPV8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR20MB2573
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.=
org> On Behalf Of Ben
> Dooks (Codethink)
> Sent: Wednesday, October 16, 2019 1:50 PM
> To: linux-kernel@lists.codethink.co.uk
> Cc: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>; Antoine Tenart
> <antoine.tenart@bootlin.com>; Herbert Xu <herbert@gondor.apana.org.au>; D=
avid S. Miller
> <davem@davemloft.net>; linux-crypto@vger.kernel.org; linux-kernel@vger.ke=
rnel.org
> Subject: [PATCH] crypto: inside-secure - fix type of buffer in eip197_wri=
te_firmware
>=20
> In eip197_write_firmware() the firmware buffer is sent using
> writel(be32_to_cpu(),,,) this produces a number of warnings.
>=20
> Note, should this really be cpu_to_be32()  ?
>=20
No, it should certainly not be cpu_to_be32() since the HW itself is most
definitely little endian, so that would not make sense to me.

Actually, I don't think either solution would be correct on a big-endian
CPU. But I don't have any big-endian CPU available to test that theory.

What I believe must happen is that the bytes must *always* be swapped=20
here, regardless of the endianness of the CPU. And with a little-endian
CPU, be32_to_cpu() coincidentally always does that.

Basically, what we need here is: read a dword (32 bits) from the memory
subsystem and write it back to the memory subsystem with bytes reversed.

Does the kernel have any dedicated function for just always swapping?

Anyway: NACK on this patch for now due to this.

> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restrict=
ed __be32
>=20
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Antoine Tenart <antoine.tenart@bootlin.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/crypto/inside-secure/safexcel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/ins=
ide-secure/safexcel.c
> index 223d1bfdc7e6..dd33f6dda295 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -298,13 +298,13 @@ static void eip197_init_firmware(struct safexcel_cr=
ypto_priv *priv)
>  static int eip197_write_firmware(struct safexcel_crypto_priv *priv,
>  				  const struct firmware *fw)
>  {
> -	const u32 *data =3D (const u32 *)fw->data;
> +	const __be32 *data =3D (const __be32 *)fw->data;
>  	int i;
>=20
>  	/* Write the firmware */
> -	for (i =3D 0; i < fw->size / sizeof(u32); i++)
> +	for (i =3D 0; i < fw->size / sizeof(__be32); i++)
>  		writel(be32_to_cpu(data[i]),
> -		       priv->base + EIP197_CLASSIFICATION_RAMS + i * sizeof(u32));
> +		       priv->base + EIP197_CLASSIFICATION_RAMS + i * sizeof(__be32));
>=20
>  	/* Exclude final 2 NOPs from size */
>  	return i - EIP197_FW_TERMINAL_NOPS;
> --
> 2.23.0

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com