Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] libfdt: reduce the number of headers included from
 libfdt_env.h
To:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        DTML <devicetree@vger.kernel.org>
References: <20190617162123.24920-1-yamada.masahiro@socionext.com>
 <CAK7LNATtqhxPcDneW0QOkw-5NyPNP06Qv0bYTe7A_gCiHMiU7A@mail.gmail.com>
 <CAK7LNASMwqy0ZUZ=kTJ7MJ6OJNa=+vbj5444xzmubJ8+6vO=sg@mail.gmail.com>
 <CAK7LNAS=9yGqMQ9eoM4L0hhvuFRYhg6S4i6J3Ou9vcB1Npj4BQ@mail.gmail.com>
From:   Frank Rowand <frowand.list@gmail.com>
Message-ID: <57c33deb-651b-3357-0e5a-95379be8a965@gmail.com>
Date:   Thu, 17 Oct 2019 12:23:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <CAK7LNAS=9yGqMQ9eoM4L0hhvuFRYhg6S4i6J3Ou9vcB1Npj4BQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/16/2019 06:01, Masahiro Yamada wrote:
> Hi Andrew,
> 
> Could you pick up this to akpm tree?
> https://lore.kernel.org/patchwork/patch/1089856/
> 
> I believe this is correct, and a good clean-up.
> 
> I pinged the DT maintainers, but they did not respond.

Sorry for the delay in responding.

libfdt_env.h is imported from an upstream project, using
the script scripts/dtc/update-dtc-source.sh.  Inside
that script are some 'sed' commands to modify the
imported files before committing them.  Please add
a sed command to make the change that the proposed
patch makes.

Thanks,

Frank

> 
> Thanks.
> 
> 
> 
> 
> On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>>
>> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>>
>>> On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
>>> <yamada.masahiro@socionext.com> wrote:
>>>>
>>>> Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
>>>>
>>>> <linux/kernel.h> pulls in a lots of broat.
>>>>
>>>> Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
>>>> macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
>>>> <linux/limits.h>.
>>>>
>>>> This saves including dozens of headers.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>> ---
>>>
>>> ping?
>>
>> ping x2.
>>
>>
>>
>>
>>>
>>>
>>>>  include/linux/libfdt_env.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
>>>> index edb0f0c30904..2231eb855e8f 100644
>>>> --- a/include/linux/libfdt_env.h
>>>> +++ b/include/linux/libfdt_env.h
>>>> @@ -2,7 +2,7 @@
>>>>  #ifndef LIBFDT_ENV_H
>>>>  #define LIBFDT_ENV_H
>>>>
>>>> -#include <linux/kernel.h>      /* For INT_MAX */
>>>> +#include <linux/limits.h>      /* For INT_MAX */
>>>>  #include <linux/string.h>
>>>>
>>>>  #include <asm/byteorder.h>
>>>> --
>>>> 2.17.1
>>>>
>>>
>>>
>>> --
>>> Best Regards
>>> Masahiro Yamada
>>
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
> 
> 
>