Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191017164223.2762148-1-songliubraving@fb.com> <20191017164223.2762148-2-songliubraving@fb.com>
In-Reply-To: <20191017164223.2762148-2-songliubraving@fb.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Thu, 17 Oct 2019 10:37:40 -0700
Message-ID: <CAHbLzkqL4iUVF5d01uBU8HhT7U3jq4urdNZNCE3pK2QfySSYHw@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] proc/meminfo: fix output alignment
To:     Song Liu <songliubraving@fb.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        matthew.wilcox@oracle.com, kernel-team@fb.com,
        william.kucharski@oracle.com,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 17, 2019 at 9:42 AM Song Liu <songliubraving@fb.com> wrote:
>
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> Add extra space for FileHugePages and FilePmdMapped, so the output is
> aligned with other rows.
>
> Fixes: 60fbf0ab5da1 ("mm,thp: stats for file backed THP")
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Tested-by: Song Liu <songliubraving@fb.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>

Acked-by: Yang Shi <yang.shi@linux.alibaba.com>

> ---
>  fs/proc/meminfo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> index ac9247371871..8c1f1bb1a5ce 100644
> --- a/fs/proc/meminfo.c
> +++ b/fs/proc/meminfo.c
> @@ -132,9 +132,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
>                     global_node_page_state(NR_SHMEM_THPS) * HPAGE_PMD_NR);
>         show_val_kb(m, "ShmemPmdMapped: ",
>                     global_node_page_state(NR_SHMEM_PMDMAPPED) * HPAGE_PMD_NR);
> -       show_val_kb(m, "FileHugePages: ",
> +       show_val_kb(m, "FileHugePages:  ",
>                     global_node_page_state(NR_FILE_THPS) * HPAGE_PMD_NR);
> -       show_val_kb(m, "FilePmdMapped: ",
> +       show_val_kb(m, "FilePmdMapped:  ",
>                     global_node_page_state(NR_FILE_PMDMAPPED) * HPAGE_PMD_NR);
>  #endif
>
> --
> 2.17.1
>
>