Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1287460ybg; Fri, 18 Oct 2019 15:15:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjnzV3PEhJcrr2+gTpgLDMik26OyXnhTLnyjuAiE/oGmJk+unB6fHq5+A2MVwRJSnjasN2 X-Received: by 2002:a05:6402:886:: with SMTP id e6mr12423902edy.152.1571436945481; Fri, 18 Oct 2019 15:15:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571436945; cv=none; d=google.com; s=arc-20160816; b=dl17aK3UAvWk494sNhrCHx8JR0pS9F572h2SyOnwthBaGrgAZ02+z0JzUHw29MM3fn IgcZJ0xUfW5JIIxasUZnTypcqXqPf2m7blJ9HIlLX3VV2Ih9HS6ZH2LNhAiLxtxjhNnc AU+Xgen8zvc5gDT81tXDV7+1q6YB1GL9OVEVU9LfCvDKy4WjcJCPlOx9zRi4iN/I01Nu y3gqNTbokB4x5vpymRf0GnLDKZ3RmBof8G5meAApnzoRiN3HxKcNaDjkasTj/0R34MRu j5FAFB8WRNeFwPFW8QCK0G+x7ipMWe0SCQ7ehWc7hBsMpArJaKqgSMLdabUT7xESiqPR P9Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6pNn+3a0mSOImc8lwCiiMBTaCf4ZMHWOyJsIWR4MRyo=; b=nIKDWXmgLpa9pKCYRcnA37CYgVOilxtvIRpilDEMwWe6Cq8ZVptmzGk9PHpn88f9Jw BGhiD7MpipcH+ZnH18WPe5KqOWswne78zZ9Z7yVlY1iyh8L5xjiazK5NhBJOffb/S+NW 9+kHgAgzx0x9sdbB5wm5AnS/0jjoataBgS54knIG+IQO622I5ESJT9LVrEpd9Acnd1GZ J0yGkCUDFoDO3dYCtIpI4zNzR2+nntgOa+JP+lNuCdKrulqNI+2zebMAcjfqw4TuPi4L doYKcrqgU1OcK7s1PbBzUv9+qN+tB/aUb8oIn8PrNCKFLWE3+uNmT0dWNeY4O8Vj+jRQ 1txw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si4025961ejx.213.2019.10.18.15.15.22; Fri, 18 Oct 2019 15:15:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441473AbfJQTLy (ORCPT + 99 others); Thu, 17 Oct 2019 15:11:54 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:35058 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbfJQTLy (ORCPT ); Thu, 17 Oct 2019 15:11:54 -0400 Received: by mail-oi1-f195.google.com with SMTP id x3so3145987oig.2; Thu, 17 Oct 2019 12:11:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6pNn+3a0mSOImc8lwCiiMBTaCf4ZMHWOyJsIWR4MRyo=; b=OQDVLCuzkwM5MvVNgeXUM2wwe23MX7r52ZpL0jVT9mxxUS9ez/vABY2I8NGYzIX6hx veOIo7uZc1ZVmYxC95DnvM8xT4erPAm30HMtcXub2xmiKUuDEoC2BKZCNOb8e6zD9TxT DjdYjwvuWOT7c4zwIpyViPA2q8bVtrMiBsxYuFRxyPIuk4jJY1PSaxXhI8OfSQl1xQ0Y 9PKtvUISZOZ553pro5dU33I2OkcRAPaNNFYGiAPfT7Jcqq+OeN5ZD4n4SHYRF0yUE/fb vLy5oenpvbIjLDOuY2E0LcYwUGvqn4Ks2QtQoRmD+OxOumF7O+Ior0QkdEOH42D/BAnC 9G9Q== X-Gm-Message-State: APjAAAVyylqEvjuUM+csr5H0TJMWYFUMs70fbNfYmeXaLhIrajeQPzR+ 8UYBYwsvGgbuSRw3xsNZ3g== X-Received: by 2002:aca:5148:: with SMTP id f69mr4711582oib.172.1571339513398; Thu, 17 Oct 2019 12:11:53 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o184sm731351oia.28.2019.10.17.12.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 12:11:52 -0700 (PDT) Date: Thu, 17 Oct 2019 14:11:52 -0500 From: Rob Herring To: Marcelo Schmitt Cc: jic23@kernel.org, dragos.bogdan@analog.com, alexandru.ardelean@analog.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH v2 2/2] dt-bindings: iio: adc: Add DT docs for AD7292 Message-ID: <20191017191152.GA11222@bogus> References: <20191016025220.td3xb7oxlfkznxl6@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016025220.td3xb7oxlfkznxl6@smtp.gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 11:52:23PM -0300, Marcelo Schmitt wrote: > Add a device tree binding doc for AD7292 monitor and control system. > > Signed-off-by: Marcelo Schmitt > --- > .../bindings/iio/adc/adi,ad7292.yaml | 107 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml > new file mode 100644 > index 000000000000..40028332d9e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7292.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7292 10-Bit Monitor and Control System > + > +maintainers: > + - Marcelo Schmitt > + > +description: | > + Analog Devices AD7292 10-Bit Monitor and Control System with ADC, DACs, > + Temperature Sensor, and GPIOs > + > + Specifications about the part can be found at: > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7292.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7292 > + > + reg: > + maxItems: 1 > + > + vref-supply: > + description: | > + The regulator supply for ADC and DAC reference voltage. > + maxItems: 1 Not necessary, regulator supplies are always 1 item, so drop maxItems. > + > + spi-cpha: > + description: | > + See Documentation/devicetree/bindings/spi/spi-controller.yaml > + maxItems: 1 This is just wrong because spi-cpha is a boolean. Just 'spi-cpha: true' is sufficient. If this device needs this property, then it should probably be required. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + > +patternProperties: > + "^channel@[0-7]$": > + type: object > + description: | > + Represents the external channels which are connected to the ADC. > + See Documentation/devicetree/bindings/iio/adc/adc.txt. > + > + properties: > + reg: > + description: | > + The channel number. It can have up to 8 channels numbered from 0 to 7. > + maxItems: 1 > + > + diff-channels: > + description: see Documentation/devicetree/bindings/iio/adc/adc.txt > + maxItems: 1 > + > + required: > + - reg > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ad7292: ad7292@0 { adc@0 > + compatible = "adi,ad7292"; > + reg = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + spi-max-frequency = <25000000>; > + vref-supply = <&adc_vref>; > + spi-cpha; > + > + channel@0 { > + reg = <0>; > + diff-channels = <0 1>; > + }; > + channel@2 { > + reg = <2>; > + }; > + channel@3 { > + reg = <3>; > + }; > + channel@4 { > + reg = <4>; > + }; > + channel@5 { > + reg = <5>; > + }; > + channel@6 { > + reg = <6>; > + }; > + channel@7 { > + reg = <7>; > + }; > + }; > + } Missing ';'. Make sure this builds with 'make -k dt_binding_check'. The '-k' is due to some other breakage ATM. Rob