Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1289006ybg; Fri, 18 Oct 2019 15:17:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGl+QcUlmE6IldCddCN2BUKaYo3IiX0LEDlx5zcwNOXdO8L44RU7xbOSfZ6HMdiL/PfNfC X-Received: by 2002:a17:907:10d3:: with SMTP id rv19mr10567941ejb.301.1571437030280; Fri, 18 Oct 2019 15:17:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571437030; cv=none; d=google.com; s=arc-20160816; b=eGcrYao2gt1tg2tK0HAI6ewB0GJf1tNnOsIL5mwZFUhUW7KZ9MwHXCnnLHh3bQr/9L xnNqDy7i5xUf1ZZzIrsE3g6p68iVWsEx4rNs3ZAIY/hFg79S1nUPgULwIMKN3nlVvzIy WdpbX7/ZQH0F/bGjLz1EvmRwF80YdtnCCYi3BAX3zrMNxZVD13Kv70TNyZYMXgUPy+Oa tXxvagcJ67CYf27FQOQ2o0TZIsEx8fcxP6dUYIHxYTjCq99DnrPgsfAgLmHne0ELH1my igiEv0UNulkTM3Xv8smejN3qZjJtVLgzNiPuPtLb+1cyhqF9q3LZehVr/0KgipyObcHY t0tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=c+JSziCIyR7jEoPejg0jZMUCf7ofAFubnedRF7WBDMc=; b=Z64GxAImJoIY4I6fqmkyhb0R8KrpPnFNM58GJm/3jZFkT20OD7SIGxxrNOW0XVUZfl Umvz2PNdD08CN/KW5ucI0RY3ZPgwWr/w5Lj1bYhew71UW1ejiEe4GBhnD6m4oUFrvhbg h4y/lbHyRikuZwOZESFnZf69b+acXJjjncXzi93ZJyZ+yZx8JyjwsBxH8l7EG++NbVR0 cKkojf2tEZQPnDdQekwpaI+vVqlPGvVj/nY/zmN6RVBf+tp5nPybmgIKiwMfPI/FLDFI 2dPfek7sLBgsj5UH1a4AcDfTORRpEany6hwaQZxbbeaCzDmp4ajSOfHIH1H5fuO/N5EQ iLgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si4223627ejy.353.2019.10.18.15.16.47; Fri, 18 Oct 2019 15:17:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440137AbfJQTjx (ORCPT + 99 others); Thu, 17 Oct 2019 15:39:53 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:45074 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437851AbfJQTjq (ORCPT ); Thu, 17 Oct 2019 15:39:46 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLBce-0006fk-Et; Thu, 17 Oct 2019 19:39:44 +0000 From: Al Viro To: linux-scsi@vger.kernel.org Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Al Viro Subject: [RFC PATCH 8/8] SG_IO: get rid of access_ok() Date: Thu, 17 Oct 2019 20:39:25 +0100 Message-Id: <20191017193925.25539-8-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191017193925.25539-1-viro@ZenIV.linux.org.uk> References: <20191017193659.GA18702@ZenIV.linux.org.uk> <20191017193925.25539-1-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro simply not needed there - neither sg_new_read() nor sg_new_write() need it. Signed-off-by: Al Viro --- drivers/scsi/sg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index f3d090b93cdf..0940abd91d3c 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -896,8 +896,6 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg) return -ENODEV; if (!scsi_block_when_processing_errors(sdp->device)) return -ENXIO; - if (!access_ok(p, SZ_SG_IO_HDR)) - return -EFAULT; result = sg_new_write(sfp, filp, p, SZ_SG_IO_HDR, 1, read_only, 1, &srp); if (result < 0) -- 2.11.0