Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1298649ybg; Fri, 18 Oct 2019 15:26:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+kxd26xFZHVJOlw3GH428SL3cdIcEhaCY0XCidmxWhgedrDumiTZ7pQrrfIa7RfQJFoXq X-Received: by 2002:a17:906:d8c5:: with SMTP id re5mr3445557ejb.254.1571437610599; Fri, 18 Oct 2019 15:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571437610; cv=none; d=google.com; s=arc-20160816; b=jk8O4YQSIOXQ5e9EmqZfARq8D4iCY3QzNgP4tK2nZLGzP2DGMe0vR8LlJP3uiO7I4k BJP/ILD80lEHqfRCo/rI5SURe4PCtDN1NGamhPZWyQWq3gIw6XxVekfv+Kbo4jaQ11sC JDaezTXAvdNPd67SQhRBDNJmu2XI5MaP+dIpD0LZlGfL7DwnhcEzNuRaHfbuJ5pfbQ5B /jBhQ9yED8YnipRpKJnjVZnaLcOQFT/LmyY4fuY0+GyXpNlA8uZ0YyQlAP2oRnrwzmqD zromQFD1xePrNhSOIBkrl8rJ47o7L64a0SWWqUMvQiL2jj7ge0+bwXL7yk+5Ft5JasXM UBBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tfGt3fWr1kwumbPQFxe11qp25uq0tySIsvg724aDQmA=; b=xuAV3NT7483OKqITabh51B/Zq1+gyD/HWlt2g7F+Q/IF5dJVYyIwt4xwIE5b2okua2 FsJ0m36wBsSdC0A0H9/xkW+ObMZhG/R7ghHiQZErr4WL0gbwovb4K4crEDoXrRF5oV8I JzNsWGgcPoMDlgukpI8MCg0zD3bvy8z1bCGqzKEvaCdx8f+Ntbbv1s6kUAacyWhVDCxn 77LBNb7z0MgMABPYv8dtqP7O0MZwpLPEnS8wpAZ+gQkgEdkh8bAQTiupzVny7WHRlex7 yoWT0YVOUT8OOSN9NE34k1rfnw9iW4S0qZTZ9oUvjSTe8+cC6oMu5UdUnsvtEFz+Xq7R wi1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KGFuI8CR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11si4316921ejr.234.2019.10.18.15.26.27; Fri, 18 Oct 2019 15:26:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KGFuI8CR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441943AbfJREyx (ORCPT + 99 others); Fri, 18 Oct 2019 00:54:53 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:35296 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2441927AbfJREyv (ORCPT ); Fri, 18 Oct 2019 00:54:51 -0400 Received: by mail-pl1-f195.google.com with SMTP id c3so2250244plo.2 for ; Thu, 17 Oct 2019 21:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tfGt3fWr1kwumbPQFxe11qp25uq0tySIsvg724aDQmA=; b=KGFuI8CR3x3LxE3B6tHHY82iaAVS9aFWFJQHPc+YDlC6ws2OgEqL2mZavAKH21Hx+N urFDi/fRju5x2WB1BQ8XO1R+jhVlMWSksN/B4/UY9zRT3GTIcsTPoK6OGJbzVh6MkCSn dWSfodppq81ggRbPJUAJlDxbG0cLFaVUy8WsN3qlimvn6ycSFTD5JwLQ3CNuPKBMSrph vIPwi1Lc8Bs1jCYz0FoGNy+3P+Dc3DVtB/zJtA5q6eF7nIiOnVVVaayioIwtLC7GhW5g EoIGr7xKR0+i4AplYvDAQaua3auhBQQw/9I4V00lXjVImKCm2cQvEpKgzvUDqgTf6iup /P7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tfGt3fWr1kwumbPQFxe11qp25uq0tySIsvg724aDQmA=; b=aHJADbX+/UubDkUj2ftYSyfYjSaUl6ExFTgh+ucRUdrSxmJGDQuPrJUyouwsIlMzIU eNav8C/EPCds2KanKvC8CkyOWAGHS7RkooLp8DxIx4ocBu3EZFjI328UiTheQ+u66hCh gieQHMSS27AP55NOrLWLCsQxMkVcS4kPD49zqB3WitMZi/IB6v7V+RDKHFXcG/QOkrgi FZgLC62dPxUoeesyBY8BNTTQ12PJJRqSc1Ns2G+1+4Vx4Ay3OhbahjWtPIi45dMbhejg UTzkiwEggoD9PzqhJJqq49vHymJvGq+LMk5EoZxiujwi6ZvTgWJ3WSYhLYVGH1n7jJxy ivvw== X-Gm-Message-State: APjAAAWvKQYlAndcKlANklyq4MKZL5DQzI5oVHsOE8CsqtSMfwKLSAM4 mbw+9Ort6CQTPw7kz2+DHrfAXW+pw/Y= X-Received: by 2002:aa7:93de:: with SMTP id y30mr4189899pff.98.1571373029465; Thu, 17 Oct 2019 21:30:29 -0700 (PDT) Received: from localhost ([122.172.151.112]) by smtp.gmail.com with ESMTPSA id i184sm4192692pge.5.2019.10.17.21.30.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Oct 2019 21:30:28 -0700 (PDT) Date: Fri, 18 Oct 2019 10:00:26 +0530 From: Viresh Kumar To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar , Nishanth Menon , Stephen Boyd , Mark Brown , Dmitry Osipenko , Bartlomiej Zolnierkiewicz , Kamil Konieczny , Krzysztof Kozlowski Subject: Re: [PATCH] opp: core: Revert "add regulators enable and disable" Message-ID: <20191018043026.xm7a6emczm6w7bck@vireshk-i7> References: <20191017102758.8104-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017102758.8104-1-m.szyprowski@samsung.com> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-10-19, 12:27, Marek Szyprowski wrote: > All the drivers, which use the OPP framework control regulators, which > are already enabled. Typically those regulators are also system critical, > due to providing power to CPU core or system buses. It turned out that > there are cases, where calling regulator_enable() on such boot-enabled > regulator has side-effects and might change its initial voltage due to > performing initial voltage balancing without all restrictions from the > consumers. Until this issue becomes finally solved in regulator core, > avoid calling regulator_enable()/disable() from the OPP framework. > > This reverts commit 7f93ff73f7c8c8bfa6be33bcc16470b0b44682aa. > > Signed-off-by: Marek Szyprowski > --- > This is a follow-up from the following discussion: > https://lkml.org/lkml/2019/10/9/541 I suppose this must go the v5.4-rcs, right ? -- viresh