Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1716415ybg; Sat, 19 Oct 2019 00:59:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyRza7CtvfL/1YYog6yep6j2KTanUXmWPoS/UtF/cB7A+UDa2AopwNbM0NuETyQDKzh1bK X-Received: by 2002:aa7:cf12:: with SMTP id a18mr14062568edy.278.1571471953185; Sat, 19 Oct 2019 00:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571471953; cv=none; d=google.com; s=arc-20160816; b=dhkB3m4UYm4McMszqDQrcTfNq4JvguookvGNpeoa3UynwcrTUjm6tyc7i8ITclvakc TuT+FAE0ePJJ+Xfj5XDEaVt+0Gjkhbq44SPBGD9Yx9KWTBJSTpwgZAgK3226E1k+69TM ndcLiLrd5n08rapaw5nZplsuI/TF7Fxf97GKKsmACYBMakSilezXN64RdWCzyL3wu0Wx otk/GgWdbbHUqTmTxlINxt+YbeZje1U8/m4ZAgFJaBpNqcWOdKbN0A+wHWLtMHfxsU3E RN4Cijmb8jvyxVMBC6pL0ulPubhZv8oekgAFpQZnzZQieCy3qC1RGYKSeCoOrBzHgvNj R26w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=TWA3RByuSpLlgW3J+QDjWeKzgpE5kDWTs6QUNvWVh+c=; b=AvdmgT8umh1mCIk08l9zrCOoR/Jj0375+Z49Tp3LVBO8PQ/z7Njh3uZxXwfQJYNKS2 v2ZDoEHcs2hUtkbtksevywZibh6zhA0e3J2MMEVe/HvFXTObsJhHJppVgu7VTBpfVrIr eS6jyrO+4mVfRvJxfYT2iR5lmjcuIlnT0tFYkDd8XZdokArxSpxtx35osKCaGX1c4/3E QkXWsoJPGfoLaYH6QuYZoNlWLe7+uNEf/37r03OZt2Fgea2TtUEMjatncYTpZbODSLHS MWXw1IcRkqCoGvyBCe2LmyUvRpnLzLhZdKxRz8CjfaY2Ym/K1G+kbSpxtC36PjH8rJEG 8p7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x9si4656339eju.147.2019.10.19.00.58.50; Sat, 19 Oct 2019 00:59:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2632757AbfJRIZB (ORCPT + 99 others); Fri, 18 Oct 2019 04:25:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:47770 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2391890AbfJRIZB (ORCPT ); Fri, 18 Oct 2019 04:25:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 04E8DAD87; Fri, 18 Oct 2019 08:24:59 +0000 (UTC) Date: Fri, 18 Oct 2019 10:24:59 +0200 From: Michal Hocko To: David Hildenbrand Cc: Naoya Horiguchi , Qian Cai , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Mike Kravetz Subject: Re: memory offline infinite loop after soft offline Message-ID: <20191018082459.GE5017@dhcp22.suse.cz> References: <1570829564.5937.36.camel@lca.pw> <20191014083914.GA317@dhcp22.suse.cz> <20191017093410.GA19973@hori.linux.bs1.fc.nec.co.jp> <20191017100106.GF24485@dhcp22.suse.cz> <1571335633.5937.69.camel@lca.pw> <20191017182759.GN24485@dhcp22.suse.cz> <20191018021906.GA24978@hori.linux.bs1.fc.nec.co.jp> <33946728-bdeb-494a-5db8-e279acebca47@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33946728-bdeb-494a-5db8-e279acebca47@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] > However, if the compound page spans multiple pageblocks Although hugetlb pages spanning pageblocks are possible this shouldn't matter in__test_page_isolated_in_pageblock because this function doesn't really operate on pageblocks as the name suggests. It is simply traversing all valid RAM ranges (see walk_system_ram_range). -- Michal Hocko SUSE Labs