Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1717349ybg; Sat, 19 Oct 2019 01:00:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3I6WTBGzmRJoPhFRANvrLUoP6RigwAOM1rfxo4zbcKtwcd/WuyPDrSq/1OhaxTVkuuR+C X-Received: by 2002:aa7:c259:: with SMTP id y25mr13723300edo.117.1571472024938; Sat, 19 Oct 2019 01:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571472024; cv=none; d=google.com; s=arc-20160816; b=UZGu7lfY50B6rhk79dLxh/qUs6yKuEOVr/gq7oK3UGLkYtaawkRN3RTFuQi+qO6a1d EjfPbFclAbHXcCr/eEGpo3W8/Fsm7CYtZmDiiOXRFRLJxby1mqKRBXsG0UlZjGT6aEz1 r+3KknTeLu75f9XtPTcWs8o3cPaUCf1uDlOMTp6hrK6Tf86C9XS8dAfmLzEwRhYk3JUV hd2FjVaRL6mZi2SUzIFndx8VyQPNasYjKeozJ5lFVqktPo/PniFiIeZ8Awd66kGAUF/4 QCPOSmMCo64wQblyY4lglkN9/qZzpv19xs+ezAmAG07bgxZJ1e3oDz/JCknfUoaP2IFg 2faw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=Qfr6bFytbmGgLzgEm1hGIzL8WMqWqOXukKX91Wj49oQ=; b=MNj1CuHkMmuIInxkFvEf4FIfTl67aFh4GUIan4rAIfeAeiWFNQ+yP+i6HdyHBfza5i 9DPn/AIzpVTCucwKG/+r9g2LEK3vXZunqzog9KTLlUOkx8AJQpdl5q2JqGoSlOozb0PN N+Jiv4Y36cfujPZvg+xJ71C3zMMZgXHnCnx3jzMSdGX5N2pZaKObbyyxPieIpDbRP3hX +eJo+MIN1PAvJlXZRBE+SGjU1FjO+xVy8qbTj9iFJPRSRRc0VK/hC+a8yHZnVEQve1Ur as4Z3ueibmKkH6cguXESmPtw/PUfR1cAD91/VYy5SnRSBXxH+b/z7XXp7mmIA90HwJL5 bxvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b35si6033513edb.204.2019.10.19.01.00.02; Sat, 19 Oct 2019 01:00:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442211AbfJRISQ (ORCPT + 99 others); Fri, 18 Oct 2019 04:18:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:40810 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2442192AbfJRISQ (ORCPT ); Fri, 18 Oct 2019 04:18:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3F37BB445; Fri, 18 Oct 2019 08:18:14 +0000 (UTC) Date: Fri, 18 Oct 2019 10:18:14 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: , , , Subject: Re: [PATCH v6 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence In-Reply-To: <20191018073848.14590-1-kai.heng.feng@canonical.com> References: <20191018073848.14590-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019 09:38:47 +0200, Kai-Heng Feng wrote: > > A driver may want to know the existence of _PR3, to choose different > runtime suspend behavior. A user will be add in next patch. > > This is mostly the same as nouveau_pr3_present(). > > Reported-by: kbuild test robot It's confusing -- this particular change isn't reported by the test bot, but only about the lack of the CONFIG_ACPI ifdef. thanks, Takashi > Signed-off-by: Kai-Heng Feng > --- > v6: > - Only define the function when CONFIG_ACPI is set. > v5: > - Add wording suggestion from Bjorn. > v4: > - Let caller to find its upstream port device. > > drivers/pci/pci.c | 18 ++++++++++++++++++ > include/linux/pci.h | 2 ++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index e7982af9a5d8..1df99d9e350e 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -5856,6 +5856,24 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode, > return 0; > } > > +#ifdef CONFIG_ACPI > +bool pci_pr3_present(struct pci_dev *pdev) > +{ > + struct acpi_device *adev; > + > + if (acpi_disabled) > + return false; > + > + adev = ACPI_COMPANION(&pdev->dev); > + if (!adev) > + return false; > + > + return adev->power.flags.power_resources && > + acpi_has_method(adev->handle, "_PR3"); > +} > +EXPORT_SYMBOL_GPL(pci_pr3_present); > +#endif > + > /** > * pci_add_dma_alias - Add a DMA devfn alias for a device > * @dev: the PCI device for which alias is added > diff --git a/include/linux/pci.h b/include/linux/pci.h > index f9088c89a534..1d15c5d49cdd 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2310,9 +2310,11 @@ struct irq_domain *pci_host_bridge_acpi_msi_domain(struct pci_bus *bus); > > void > pci_msi_register_fwnode_provider(struct fwnode_handle *(*fn)(struct device *)); > +bool pci_pr3_present(struct pci_dev *pdev); > #else > static inline struct irq_domain * > pci_host_bridge_acpi_msi_domain(struct pci_bus *bus) { return NULL; } > +static bool pci_pr3_present(struct pci_dev *pdev) { return false; } > #endif > > #ifdef CONFIG_EEH > -- > 2.17.1 >