Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1718980ybg; Sat, 19 Oct 2019 01:02:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqymqByW4GhmtohgV8E5fRQf+m+RVRFZNrfIZ9g5kmbQguH+j+xpcQKqWNSV1PFmgWo2By7H X-Received: by 2002:a17:906:1655:: with SMTP id n21mr12579186ejd.110.1571472124363; Sat, 19 Oct 2019 01:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571472124; cv=none; d=google.com; s=arc-20160816; b=ihmqqDduBaQgKoQr+su9XM9BotY3srTpUCP0fvuk4rM74tEoNwUXX5towrdlkaioHN 65I3/IR7Ti24O7EiLiSKigDx9Izls97aYd5lLEX5vA/p11GJo0X9Q+lFZrjURuJ78eFu JzpMQnHzNhs9mKDyhnssbvATNk3L1tSGDuLhzZK2AgcAhjQj4LoKnNvNypo5gw/7XB7U SfIi+mvxdi1LcSMe4bwalYUIxjLA4kS4WMmLdsUmQaofqK12MiLWPBLFzIYZa+73Kf/v YiB7EJZvCOOTLx89IRyGgv+Yt+1nOrZAu/4tVY5txta5ghVfzyRd5hxyruIWLQRn0ZeE yrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=NkApBMWXI6KSBCy/CceZLI8ycOLWOg8BCtlFadZBvgw=; b=fV2kW+CZoWO+LeFl8aG5Zl3VG6G9t6/OIKdEnptlimcXB9M2YGIbREJSj4JjnfV56y VWKvetv/ijDU2oWw5aBSFaUIj48uxIQg/Cwynz9kVd3JrpIcnGnTrarWNptrE4iPRftk 671OAAp1pbvEO3+1yLtmmq1JTP/+TbBuN8wP+KL9sZtjFQ0CdYU1ZBT9EM49umS1lwrP BUJ1xl0CeCj0M12AUHUH1FIt/PQuGgs3UoLlArYwCN4PzX45yW3qi7vL71m/Etq8XlAr I2jum0tKFta5ps1uTsZGypDKXfdNCW/R/7WZiAtA95GJosYg/H8sJjuQxIVudnZdbwru tkPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si6600532edk.315.2019.10.19.01.01.41; Sat, 19 Oct 2019 01:02:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504951AbfJRIpr (ORCPT + 99 others); Fri, 18 Oct 2019 04:45:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:34338 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730669AbfJRIpq (ORCPT ); Fri, 18 Oct 2019 04:45:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2FDDEB4D0; Fri, 18 Oct 2019 08:45:44 +0000 (UTC) Date: Fri, 18 Oct 2019 10:45:43 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence In-Reply-To: <4C18DF4A-FAE8-4762-AF65-F892A4845297@canonical.com> References: <20191018073848.14590-1-kai.heng.feng@canonical.com> <4C18DF4A-FAE8-4762-AF65-F892A4845297@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019 10:30:11 +0200, Kai-Heng Feng wrote: > > > > > On Oct 18, 2019, at 16:18, Takashi Iwai wrote: > > > > On Fri, 18 Oct 2019 09:38:47 +0200, > > Kai-Heng Feng wrote: > >> > >> A driver may want to know the existence of _PR3, to choose different > >> runtime suspend behavior. A user will be add in next patch. > >> > >> This is mostly the same as nouveau_pr3_present(). > >> > >> Reported-by: kbuild test robot > > > > It's confusing -- this particular change isn't reported by the test > > bot, but only about the lack of the CONFIG_ACPI ifdef. > > Hmm, because the test bot asked to add the tag. Yes, but it's only if you add a new fix patch on top of it. You can write some their credit, too, but basically it'd be enough to point to the Link tag to the thread. > If it's not appropriate will you drop it? I can also send a v7. I can modify in my side. thanks, Takashi > > Kai-Heng > > > > > > > thanks, > > > > Takashi > > > >> Signed-off-by: Kai-Heng Feng > >> --- > >> v6: > >> - Only define the function when CONFIG_ACPI is set. > >> v5: > >> - Add wording suggestion from Bjorn. > >> v4: > >> - Let caller to find its upstream port device. > >> > >> drivers/pci/pci.c | 18 ++++++++++++++++++ > >> include/linux/pci.h | 2 ++ > >> 2 files changed, 20 insertions(+) > >> > >> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > >> index e7982af9a5d8..1df99d9e350e 100644 > >> --- a/drivers/pci/pci.c > >> +++ b/drivers/pci/pci.c > >> @@ -5856,6 +5856,24 @@ int pci_set_vga_state(struct pci_dev *dev, bool decode, > >> return 0; > >> } > >> > >> +#ifdef CONFIG_ACPI > >> +bool pci_pr3_present(struct pci_dev *pdev) > >> +{ > >> + struct acpi_device *adev; > >> + > >> + if (acpi_disabled) > >> + return false; > >> + > >> + adev = ACPI_COMPANION(&pdev->dev); > >> + if (!adev) > >> + return false; > >> + > >> + return adev->power.flags.power_resources && > >> + acpi_has_method(adev->handle, "_PR3"); > >> +} > >> +EXPORT_SYMBOL_GPL(pci_pr3_present); > >> +#endif > >> + > >> /** > >> * pci_add_dma_alias - Add a DMA devfn alias for a device > >> * @dev: the PCI device for which alias is added > >> diff --git a/include/linux/pci.h b/include/linux/pci.h > >> index f9088c89a534..1d15c5d49cdd 100644 > >> --- a/include/linux/pci.h > >> +++ b/include/linux/pci.h > >> @@ -2310,9 +2310,11 @@ struct irq_domain *pci_host_bridge_acpi_msi_domain(struct pci_bus *bus); > >> > >> void > >> pci_msi_register_fwnode_provider(struct fwnode_handle *(*fn)(struct device *)); > >> +bool pci_pr3_present(struct pci_dev *pdev); > >> #else > >> static inline struct irq_domain * > >> pci_host_bridge_acpi_msi_domain(struct pci_bus *bus) { return NULL; } > >> +static bool pci_pr3_present(struct pci_dev *pdev) { return false; } > >> #endif > >> > >> #ifdef CONFIG_EEH > >> -- > >> 2.17.1 > >> >