Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   Brian Starkey <Brian.Starkey@arm.com>
To:     John Stultz <john.stultz@linaro.org>
CC:     "Andrew F. Davis" <afd@ti.com>, nd <nd@arm.com>,
        Sudipto Paul <Sudipto.Paul@arm.com>,
        Vincent Donnefort <Vincent.Donnefort@arm.com>,
        Chenbo Feng <fengc@google.com>,
        Alistair Strachan <astrachan@google.com>,
        Liam Mark <lmark@codeaurora.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>,
        Hridya Valsaraju <hridya@google.com>,
        Ayan Halder <Ayan.Halder@arm.com>,
        Pratik Patel <pratikp@codeaurora.org>
Subject: Re: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)
Thread-Topic: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)
Thread-Index: AQHVZOOE06vVhxy1kU6dQZ4T2LR+p6ddx+OAgAGsdgCAAAQmgIAAGMaAgADZPAA=
Date:   Fri, 18 Oct 2019 09:55:17 +0000
Message-ID: <20191018095516.inwes5avdeixl5nr@DESKTOP-E1NTVVP.localdomain>
References: <20190906184712.91980-1-john.stultz@linaro.org>
 <CAO_48GFHx4uK6cWwJ4oGdJ8HNZNZYDzdD=yR3VK0EXQ86ya9-g@mail.gmail.com>
 <20190924162217.GA12974@arm.com> <20191009173742.GA2682@arm.com>
 <f4fb09a5-999b-e676-0403-cc0de41be440@ti.com>
 <20191014090729.lwusl5zxa32a7uua@DESKTOP-E1NTVVP.localdomain>
 <a213760f-1f41-c4a3-7e38-8619898adecd@ti.com>
 <CALAqxLV6EBHKPEaEkyfhEYyw0TXayTeY_4AWXfuASLLyxZh5+Q@mail.gmail.com>
 <a3c66479-7433-ec29-fbec-81aef60cb063@ti.com>
 <CALAqxLWrsXG0XysL7RmhApbuZukDdG5VhdHOTS5odkG9f1ezwA@mail.gmail.com>
In-Reply-To: <CALAqxLWrsXG0XysL7RmhApbuZukDdG5VhdHOTS5odkG9f1ezwA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
user-agent: NeoMutt/20180716-849-147d51-dirty
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Brian.Starkey@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: b0aa5e44-3f91-474c-476f-08d753b14fc8
X-MS-Office365-Filtering-HT: Tenant
X-MS-TrafficTypeDiagnostic: AM6PR08MB5271:|AM6PR08MB5271:|AM6SPR01MB0020:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM6SPR01MB0020E8E208AB5DF6B1DC3135F06C0@AM6SPR01MB0020.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
x-forefront-prvs: 01949FE337
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(199004)(189003)(9686003)(66446008)(7416002)(316002)(66066001)(256004)(71190400001)(4326008)(6916009)(6116002)(305945005)(7736002)(2906002)(6512007)(71200400001)(54906003)(446003)(102836004)(14454004)(476003)(486006)(186003)(478600001)(76176011)(26005)(3846002)(53546011)(6506007)(386003)(25786009)(44832011)(58126008)(11346002)(6246003)(66476007)(81156014)(5660300002)(1076003)(561944003)(229853002)(64756008)(81166006)(99286004)(66946007)(8936002)(6436002)(6486002)(86362001)(66556008)(52116002)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB5271;H:AM6PR08MB3829.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: MfEiwEg/pTkl6s8pKhrfTDBMhC7DRncF9QPBl1TyFK9HW1yuIcxTRKjF+jddqYbfhDuRxadfBrznWcUmC/dOgx85BZCwaOOxkDI7lEAeHIY16705Md2cerredkxszDMs5aV9GFk32QeTF2nrIWnRUU1v330PHZMOYfDyLbL2PN/L/V+Cga8p3tlhw6PmiDj2bfS39oDjtZvPGAQHfqq8sjEpC9ENg3LrSSryvHq4TIVOayfqPYtaYWk85FyKCcsJUv6yD9ilRvl0lmLFdCO/Y2hn7qMtWCC4Pc87jnBgrFhQMgPqkMcCiMjDIkYMssRvaF7nMYtChIV7tsCeEgYoJpNcBhTxtLaMo3owWugPgi8xIkUBKrx+mD3xspIjtUktraMulLuBxKLN7Y63djDM5GSoSnG1K9GPYHId9xVzMqM=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A2518C9FE01EAE4A9C3BE5F62A612E3D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5271
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Brian.Starkey@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(346002)(136003)(376002)(396003)(199004)(189003)(6506007)(386003)(46406003)(53546011)(99286004)(102836004)(186003)(5660300002)(97756001)(22756006)(76176011)(26005)(336012)(70586007)(70206006)(446003)(25786009)(11346002)(63350400001)(86362001)(356004)(476003)(81166006)(81156014)(486006)(126002)(9686003)(6512007)(76130400001)(54906003)(3846002)(36906005)(6862004)(478600001)(316002)(66066001)(47776003)(305945005)(7736002)(23726003)(14454004)(6116002)(4326008)(2906002)(26826003)(50466002)(1076003)(6246003)(8746002)(229853002)(6486002)(8936002)(58126008)(8676002)(561944003)(107886003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6SPR01MB0020;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 4a911976-8c78-4ead-c6a9-08d753b147c8
NoDisclaimer: True
X-Forefront-PRVS: 01949FE337
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9GPx7U2MXxXWHTh+Zdqd4cayPndhD2YaeGWR7cMDjlDEHw+UARPxo5VrHESYafqWbNCpnJRpGWTAxdDP25kUdNoLB7ckX27+MBbC8y/uEOEeveY+TLCqfCzzFcIORXmTbzR0CCymwzRvrMDtou0/tgvVEl4Dt1zgIVDi/eoTLe8gureT8EOQTP6M645cvKA4CIAUnAWKgrfJi44JDfT35MRvPmplEBDTJJ9EV5m4P5u7L7cdiusRyzq96Z3Uem9E2PZT1fVRoHVPf7fI860bfGbG5ng7fgCERXA9Jwu/kxaERBMeAy/X42K7ozh8y+7vVK6peevEisO65TzP7NsMXiMfe6i3DAd3Ei6F6bB0jBoXJAdTt7gQoWW1bbek1A/F+ZVrNLcQvpQpe+JiSzRlIr6a+ecstR9TEjrnmfyZK9xjo6mEut3VvKkKS65WX2n9
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2019 09:55:30.8486
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b0aa5e44-3f91-474c-476f-08d753b14fc8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6SPR01MB0020
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 17, 2019 at 01:57:45PM -0700, John Stultz wrote:
> On Thu, Oct 17, 2019 at 12:29 PM Andrew F. Davis <afd@ti.com> wrote:
> > On 10/17/19 3:14 PM, John Stultz wrote:
> > > But if the objection stands, do you have a proposal for an alternativ=
e
> > > way to enumerate a subset of CMA heaps?
> > >
> > When in staging ION had to reach into the CMA framework as the other
> > direction would not be allowed, so cma_for_each_area() was added. If
> > DMA-BUF heaps is not in staging then we can do the opposite, and have
> > the CMA framework register heaps itself using our framework. That way
> > the CMA system could decide what areas to export or not (maybe based on
> > a DT property or similar).
>=20
> Ok. Though the CMA core doesn't have much sense of DT details either,
> so it would probably have to be done in the reserved_mem logic, which
> doesn't feel right to me.
>=20
> I'd probably guess we should have some sort of dt binding to describe
> a dmabuf cma heap and from that node link to a CMA node via a
> memory-region phandle. Along with maybe the default heap as well? Not
> eager to get into another binding review cycle, and I'm not sure what
> non-DT systems will do yet, but I'll take a shot at it and iterate.
>=20
> > The end result is the same so we can make this change later (it has to
> > come after DMA-BUF heaps is in anyway).
>=20
> Well, I'm hesitant to merge code that exposes all the CMA heaps and
> then add patches that becomes more selective, should anyone depend on
> the initial behavior. :/

How about only auto-adding the system default CMA region (cma->name =3D=3D
"reserved")?

And/or the CMA auto-add could be behind a config option? It seems a
shame to further delay this, and the CMA heap itself really is useful.

Cheers,
-Brian

>=20
> So, <sigh>, I'll start on the rework for the CMA bits.
>=20
> That said, I'm definitely wanting to make some progress on this patch
> series, so maybe we can still merge the core/helpers/system heap and
> just hold the cma heap for a rework on the enumeration bits. That way
> we can at least get other folks working on switching their vendor
> heaps from ION.
>=20
> Sumit: Does that sound ok? Assuming no other objections, can you take
> the v11 set minus the CMA heap patch?
>=20
> thanks
> -john