Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1732981ybg; Sat, 19 Oct 2019 01:18:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzW3iDFMn+NUKQTtk9GCzt43dS3n6bO/zineKw/SdJoXu4Okdr5rpoyHsKAz01i9sN/uSJI X-Received: by 2002:a17:907:2132:: with SMTP id qo18mr12339640ejb.247.1571473138076; Sat, 19 Oct 2019 01:18:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571473138; cv=none; d=google.com; s=arc-20160816; b=mGpJydZgIvLJrgY8KB3NkU4f9W+MTtRX55pLIm9KzHJfp0aTbGGaNOdbeTMJLFZsCA 3NFn03WT92kwnpj9qY7GDSykFC9pU38YMvSbPcj7Hsf8DrVaxSGz275JJw8tO2qLKkkT lREAbG5KgClSKtTbSUVOsfNX2azqhjBGB29yhmBPL0LxUR2o6V/DZrsfJhXHQ8BqV7aX oorBI1yGcUH7nX4liadDsPT55z4eYc+lAUFMYlFMgAXToN/slcFywdk6s201tajMEgJH UG11Rcw14FUz3xKbTF0zEJujr+N8FwkDDHPqHyflGa/a8IuBEAx35JWHdLj5Q33ZwHhI gyKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3DByddWkc5cdTXqfZ8p4x/nfiNubhnhdBlB/o+i+ezM=; b=Of3cHzCkCd9Fq3zgBUYf2mDggwTj9mBHWL1Nih1VPhcJq7o19I1oLdM+5i9p8wuU4K dPmFIcDG42io9gqp0WZavI/GewyMP5BE27j2KWbg7oDsBuKGhzPdAwcnWrxrR7uilZtl yh6oXV2/vhGO3gZsLHGL8V4JkrLqd3Jm/M0qFezHGoByDHLY1LhSO83Ht7OH8LNMwjDe p9DtPxc3mx8sFUtNFUgFArzzWjxPb7TFpyYKKqVMSHkqXy0yx5oz6p92a4y4vuLtsr6Y nrhcHlv4k2XoEGWzsUaqrgMF7UGNwxxmvKY4ThDpbajhjPn4Wxv51h+yW3VuysGBB1YU GeXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeblueprint-co-uk.20150623.gappssmtp.com header.s=20150623 header.b=HFD3g+Y6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si4626643ejw.229.2019.10.19.01.18.34; Sat, 19 Oct 2019 01:18:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeblueprint-co-uk.20150623.gappssmtp.com header.s=20150623 header.b=HFD3g+Y6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392655AbfJRL6x (ORCPT + 99 others); Fri, 18 Oct 2019 07:58:53 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45143 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392487AbfJRL6x (ORCPT ); Fri, 18 Oct 2019 07:58:53 -0400 Received: by mail-wr1-f65.google.com with SMTP id q13so981798wrs.12 for ; Fri, 18 Oct 2019 04:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3DByddWkc5cdTXqfZ8p4x/nfiNubhnhdBlB/o+i+ezM=; b=HFD3g+Y6OPB8fRJSvhg77Uh3VrsobKCLs+qlqxAsDrwyyaIR1S28n2tEgpMGmME3N1 eSC8Y5L4spPuKlYR8IDXqVqPNkE3wCI57nEpQix5fZ1YSbdbMHfNnJ2PpqBII60CfCEy Ok14KMQdXroVK9EVkaLhU/WnvCdAn0n9Yah3KkgBKAeK6jWnnL950i+rFk0vvprF+Kgl VqJvd/gOuFEwIWQMsWaydU/DXQuhWBkZ7YMJEinq57kTrYMMSQMVXzK9KiODoYDMp4BE FlsEC7VTKImLcUvhnKjXjyBaTk5xpaLL5zLi8eShGH+77khULSLWGpfm6eAmW0CvOW3c TUUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3DByddWkc5cdTXqfZ8p4x/nfiNubhnhdBlB/o+i+ezM=; b=ncbv3OG4r3lf4CPWhA34x/7VohemlUGM0LYmbvqPe9XL7U7goVkzq3/aHpov9ck8KK ViM0wv9H7TTbFLue4ucnSWGfnDnkGjpJJKlBAINjRl61dJS598Ubh4I9DmLWnlBf9Dgf EuISJW8MucH3Y9bgPfMCaaldhi8W4nQSFpmdVvNCO4Xzthnt2jifPagUo8m3HsA2+h4s TCHpt/vAM+enRjMtTixbh3SIfF2ajtzUenjAOkYlxmTede4BSPF32ZZxZj1+AKhQ3dMW JncjCVK8z02UQeOhVmsdWlHhFP1b3Cdafx26mT5/ILQ0sPfz6mH9pqV8OWAVs2j0+Gvy JR/Q== X-Gm-Message-State: APjAAAVL0TvyBS4h9AMcQWVY/O4q4j5qESJLxgQ4/CLqS53SUi/6nAg9 t7Ev/lo6xpXRVdZmvT6CNuwim83YrZ0= X-Received: by 2002:a5d:638b:: with SMTP id p11mr7031669wru.372.1571399931236; Fri, 18 Oct 2019 04:58:51 -0700 (PDT) Received: from localhost (97e34ace.skybroadband.com. [151.227.74.206]) by smtp.gmail.com with ESMTPSA id a204sm6947970wmh.21.2019.10.18.04.58.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 04:58:50 -0700 (PDT) Date: Fri, 18 Oct 2019 12:58:49 +0100 From: Matt Fleming To: Mel Gorman Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Thomas Gleixner , Borislav Petkov , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 0/3] Recalculate per-cpu page allocator batch and high limits after deferred meminit Message-ID: <20191018115849.GH4065@codeblueprint.co.uk> References: <20191018105606.3249-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018105606.3249-1-mgorman@techsingularity.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct, at 11:56:03AM, Mel Gorman wrote: > A private report stated that system CPU usage was excessive on an AMD > EPYC 2 machine while building kernels with much longer build times than > expected. The issue is partially explained by high zone lock contention > due to the per-cpu page allocator batch and high limits being calculated > incorrectly. This series addresses a large chunk of the problem. Patch 1 > is mostly cosmetic but prepares for patch 2 which is the real fix. Patch > 3 is definiely cosmetic but was noticed while implementing the fix. Proper > details are in the changelog for patch 2. > > include/linux/mm.h | 3 --- > mm/internal.h | 3 +++ > mm/page_alloc.c | 33 ++++++++++++++++++++------------- > 3 files changed, 23 insertions(+), 16 deletions(-) Just to confirm, these patches don't fix the issue we're seeing on the EPYC 2 machines, but they do return the batch sizes to sensible values.