Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1735987ybg; Sat, 19 Oct 2019 01:22:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/tSUSLYRQG97i7BdiEHEe6NjGSWJRv0ESo2RR7pgUA8ZUoLEvVMpltwb7qM9QCWIMkDg2 X-Received: by 2002:a17:906:b245:: with SMTP id ce5mr12489167ejb.52.1571473370431; Sat, 19 Oct 2019 01:22:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571473370; cv=none; d=google.com; s=arc-20160816; b=iGKr2+VnVbmsE/5MMo8W2r1JOa12shphb94GPXNu9Y5u6r6Vb5N4mAg5UlA3Y2RYfQ 2AJbUsXsYJC4hsTB9lmw139HK+WXuHM/E0gHlnrxAHxDHU+SHrsx++WIDj4urXxvU9Jo 2KdZ0olCJLQqVv89baknNoCm84UA810RtFVb9oQ9GXVnmlxr6OVVxDe43u27Xk6Z3mPa SFiNsusLlDC9omQqma2SmHayJCEwpA2+tl6KdyL2ar31vd5qLGk2VGfXui3wOGheoRnG cd5E5D+hum3PNEplEwO9Tdn7qUi424lXb2CTm7Jgs5D5flmmKzS9+H0uuOQuZjAolQzU ZYFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id; bh=2alwk/Hr9rmIQvG9OVjQg8MHE5hGbUtwanOpCXvsFNQ=; b=c3kcidcPxpU6v3iQBCLhOWVEjn0u+H4ipjKO/YaIHsLDCZmeCTDqAd2VkDJGTP0qC8 1MsnxK65cbNJfOf/+b1eINlZYU5H+nGt3Q88mtvAVikp1iOcfTwSfV5zZAjIqKuuxTBu vyBmdg/PExyXdblROWsZekg7P8FoHt4QI6U5gW+A7JMDysLLuqM41dEGwNo8K0/DYMzV iDDf8NB2C4Eku6YUgyqzRAtcQywWnGOcVtprzgFWCVJHBaQxCNE/0XxS2DTLmCdmEPX3 s9zm3zgi3dAfeKTAq2S7mSum9NJA5YhUO5rfa6Sp1lYpF4kVRx+jvZm7793QuIex5Wgh s68Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x25si5156944edr.128.2019.10.19.01.22.27; Sat, 19 Oct 2019 01:22:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634040AbfJRMtQ (ORCPT + 99 others); Fri, 18 Oct 2019 08:49:16 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:57916 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2634008AbfJRMtP (ORCPT ); Fri, 18 Oct 2019 08:49:15 -0400 Received: from [167.98.27.226] (helo=xylophone) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iLRgs-0001mQ-3j; Fri, 18 Oct 2019 13:49:10 +0100 Message-ID: <1984049ff0e359801401fbbcbdbc21ee0a64c1a9.camel@codethink.co.uk> Subject: Re: [Y2038] [PATCH v6 31/43] compat_ioctl: move WDIOC handling into wdt drivers From: Ben Hutchings To: Arnd Bergmann , Al Viro Cc: y2038@lists.linaro.org, linux-fsdevel@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org Date: Fri, 18 Oct 2019 13:49:09 +0100 In-Reply-To: <20191009191044.308087-32-arnd@arndb.de> References: <20191009190853.245077-1-arnd@arndb.de> <20191009191044.308087-32-arnd@arndb.de> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-10-09 at 21:10 +0200, Arnd Bergmann wrote: > All watchdog drivers implement the same set of ioctl commands, and > fortunately all of them are compatible between 32-bit and 64-bit > architectures. > > Modern drivers always go through drivers/watchdog/wdt.c as an abstraction > layer, but older ones implement their own file_operations on a character > device for this. > > Move the handling from fs/compat_ioctl.c into the individual drivers. > > Note that most of the legacy drivers will never be used on 64-bit > hardware, because they are for an old 32-bit SoC implementation, but > doing them all at once is safer than trying to guess which ones do > or do not need the compat_ioctl handling. > > Reviewed-by: Guenter Roeck > Signed-off-by: Arnd Bergmann > --- > arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 1 + > arch/um/drivers/harddog_kern.c | 1 + > drivers/char/ipmi/ipmi_watchdog.c | 1 + > drivers/hwmon/fschmd.c | 1 + > drivers/rtc/rtc-ds1374.c | 1 + [...] It Looks like you missed a couple: drivers/rtc/rtc-m41t80.c drivers/watchdog/kempld_wdt.c Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom