Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1739349ybg; Sat, 19 Oct 2019 01:27:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4Jzh0KyjnTLTVajZehaUsWbkxj+UicYnJTAgcwMJ94bGBQVtN150VcYcHBl3LKc3g3T4e X-Received: by 2002:a17:906:418:: with SMTP id d24mr12651316eja.305.1571473659646; Sat, 19 Oct 2019 01:27:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571473659; cv=none; d=google.com; s=arc-20160816; b=0kk0P8Kz0LN1LqrW3RY9fYXmGSI60KoDX02liAoYLtKvNaeuUT+npQ+9hywQp8mKue pAg+4UzmpA2vkuW6ld1RMaglj96BQIm7uSgxAmZ5dugVCFumlRbRrCKZTFneo+cCaB4w 9fjP9vcFCltT9BCnD+ZZp+io4ux01iNMH5aRb88FNL88s1zvBZ5bfnnstoJ8QDSlL/Ml teztNVAxG8uh0R//gcEPIiu9fgI9GoFNP0KGAaqTJNGt6N+UdiMpNt7WlDYzdUYvbAai Rg9Mqt3OUtwGkurKMBTNvchPPz8kfKon+CokqKsSXUNPwjdc66OMEEweRXLfixhrGdTR osSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=tpuqPfUBPTEqWzHgbYNa7ad4BsKzW7eS2KnXx2Hiqco=; b=XZc2vq1FUi7RkfjDE85zpXu1sB2EXIT69QzuG5mFlnrrEMCBhCs6xR61GoHjNprWrq bUWbn2IP2r7LA6pQz31WDSllkxz6HJ2AICT5E1f20ydzKv5H3aAJQxPoDLR+/n3+sc7K XN6RKzDqJLwF3Py3/5obM7OXgF/Qu3cZhL0J80eNbfCb9Gf/vTq5MIcjRlEKf5kuBjbR XAFQZsuVOlE9g+guo5ZjRPdD2Tk/ZiUlZAD2oukv9Alz90V8c27htTmjj80oWD2+bh0w qGZRq3sNcpYsPYzHWwBqe2QJ+X2l1klLpZeeDXgHyfhOj5CgIj+md/Ajj31CwpyCBHLl ayWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si4812126ejj.70.2019.10.19.01.27.16; Sat, 19 Oct 2019 01:27:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410345AbfJRNbe (ORCPT + 99 others); Fri, 18 Oct 2019 09:31:34 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:45416 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408509AbfJRNbe (ORCPT ); Fri, 18 Oct 2019 09:31:34 -0400 Received: by mail-qk1-f194.google.com with SMTP id z67so5230288qkb.12; Fri, 18 Oct 2019 06:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tpuqPfUBPTEqWzHgbYNa7ad4BsKzW7eS2KnXx2Hiqco=; b=txP5fwCI3WUIZws4MVeGifPoLuCDRPA7Plw7TyNdkA53uP+G8MWtyuFOH+lfR22JFj +DroiMesz8CxtTpkRL1TAWOLARyE8GPTdVUuz4VBpaxHcrcDh8SsaP5rNqfgP3gm7+PN ECLoGVu53k9z9B41BZ7G2Fvj0FV7WIWC1JQEOUlKpxpz7LN7w/P/x4aumhm3oFXKXMrz y/kizVxtj4OOLWW7XnSkC4aRq9wCoSX/ADsRGlobqepGAglSjvtLxnjF1zOmbc9K9jIv OkOv9fmie4IjnvHRGizDncx3j1RD4EriOoE4zj41tho/ptxHB3XqvWyImDxmI3/gdHPL k8zQ== X-Gm-Message-State: APjAAAUC6wfDQkGolXKY+AfONn+/eXLzKpkD+4amJQt1tzKwYOpq3Nd1 JaV54ly69MkRPgWEKu6Y9s0c+pEdrVdr+1Oyi8o3zqo+ X-Received: by 2002:a37:9442:: with SMTP id w63mr8599892qkd.138.1571405492947; Fri, 18 Oct 2019 06:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20191009190853.245077-1-arnd@arndb.de> <20191009191044.308087-32-arnd@arndb.de> <1984049ff0e359801401fbbcbdbc21ee0a64c1a9.camel@codethink.co.uk> In-Reply-To: <1984049ff0e359801401fbbcbdbc21ee0a64c1a9.camel@codethink.co.uk> From: Arnd Bergmann Date: Fri, 18 Oct 2019 15:31:16 +0200 Message-ID: Subject: Re: [Y2038] [PATCH v6 31/43] compat_ioctl: move WDIOC handling into wdt drivers To: Ben Hutchings Cc: Al Viro , y2038 Mailman List , Linux FS-devel Mailing List , Guenter Roeck , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 2:49 PM Ben Hutchings wrote: > > On Wed, 2019-10-09 at 21:10 +0200, Arnd Bergmann wrote: > > All watchdog drivers implement the same set of ioctl commands, and > > fortunately all of them are compatible between 32-bit and 64-bit > > architectures. > > > > Modern drivers always go through drivers/watchdog/wdt.c as an abstraction > > layer, but older ones implement their own file_operations on a character > > device for this. > > > > Move the handling from fs/compat_ioctl.c into the individual drivers. > > > > Note that most of the legacy drivers will never be used on 64-bit > > hardware, because they are for an old 32-bit SoC implementation, but > > doing them all at once is safer than trying to guess which ones do > > or do not need the compat_ioctl handling. > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Arnd Bergmann > > --- > > arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 1 + > > arch/um/drivers/harddog_kern.c | 1 + > > drivers/char/ipmi/ipmi_watchdog.c | 1 + > > drivers/hwmon/fschmd.c | 1 + > > drivers/rtc/rtc-ds1374.c | 1 + > [...] > > It Looks like you missed a couple: > > drivers/rtc/rtc-m41t80.c No idea how I missed this. Adding it now. > drivers/watchdog/kempld_wdt.c This one is covered: the watchdog_ops->ioctl is called by the wdt_dev_ioctl() function as a fallback. After checking once more, I did find another instance I missed though: drivers/hwmon/w83793.c, I'm adding that as welll now. m41t80 does not seem to have any 64-bit machines using it, but w83793 does, and they clearly both should have been changed. Thanks for the review! Arnd