Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1743797ybg; Sat, 19 Oct 2019 01:33:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/qAQPfcjPRxyU0i6x5BgPdf4ttSSEJLPAblZig8/xaKmXtVozovrA5SfJC97wi4MMS6hL X-Received: by 2002:a17:906:fcd4:: with SMTP id qx20mr12725262ejb.257.1571474007606; Sat, 19 Oct 2019 01:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571474007; cv=none; d=google.com; s=arc-20160816; b=wIX9WMBXXMEs+6g1HijWv7bvXuiopoklxdegYqEAemAkgNxkLx+CX+jCrz1SLRTd9H 7zcSBxDUTo1or9jERf2wYLTRMssdD9F4i5jGhP4pfL8hXCs2T1Ezb6IQWoqcIwJdXGbd /Ymw7jpGeSq8dyUebrg8fPOF2sM45FLiOXfaPxhDbOiYW/Oo4xgm9qa49TNzBQp95ssb 5yAbpdINCAYW2JsnwEgGYtZp3A4vCpogy5VtYHlKOk5eszEorE3Wl+kUgYUSr7iJmdn3 6EOzTytxzg5LpQMxxMcM1otcAapY+81F77YHa8K6JCbil+IOoesoJDcOyRLVMmX4nOE+ C4VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ei51YZAvEhA4r5N+YGs4qYhuh8+slSCkMfLH0jqZnD8=; b=f+aNYBr614u7XmMgDW+Bt++L/Ufr4dhTiLp1BZP78Rh+iaKjdYkwLMwuVxCllro3GW GAl8asrhJdfKVil80p2Jc+MwZR21OHkcemxhx2LsPo1lyFAJvba1G0uR4ooxcPFDe9ZV Gp4nHb01sZPGxCB0T2C2mRC/lE3k62CLYmP+TXTbDmDFJQfpw5rjwAJwv0t+kpa+F8qY DGoYM6sCUFsVHbtysjG9hdYfv2J5hzu6Bgc+hKJkyLiz4q/N0dimN7TFm1EL8InUawuf 5afxrtbmFMScLDqEJUTkJIIZjWIXjl/o7n6DwwRxhG9ZyUaxtKVtRi/luzc7GgxcFabS DQPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GiAD4YwW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21si5953053edb.164.2019.10.19.01.33.04; Sat, 19 Oct 2019 01:33:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GiAD4YwW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410575AbfJRPcC (ORCPT + 99 others); Fri, 18 Oct 2019 11:32:02 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:40279 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410487AbfJRPcB (ORCPT ); Fri, 18 Oct 2019 11:32:01 -0400 Received: by mail-lj1-f194.google.com with SMTP id 7so6658470ljw.7; Fri, 18 Oct 2019 08:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ei51YZAvEhA4r5N+YGs4qYhuh8+slSCkMfLH0jqZnD8=; b=GiAD4YwWVjSWvaK8Av5lcBHH0qomSRpUNph7poGrauD6glP+bDoN6fcrk3m03qOOai BpEJN6xOeocNXiR+hA8o3lvvVplAu+l/cN05qIFs38/3DttNJn7v/2iCRbvOmYZeJD4Y //Wwnbd99k1MgCsN6sMjwDh4XdsoGgQSHDYzT9dIgGRW0Kndhyhgm7PgRgGZOgL8aBDw SJrj2LewHiHI/23l1XERDDAQhm5Pipp8KaFxovjtCqxKxRPRmTAUDM49qyTeUadt0rrd ydeaXk+nlcwUchVz4XV40YcgIMkVgyHx2Ub3gu710baDSvs03w9D9cS1qD8B/HNFyfyE RYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ei51YZAvEhA4r5N+YGs4qYhuh8+slSCkMfLH0jqZnD8=; b=G7bUb/P2ATuBUGy8nyEaLugzKSN+zYnKQWi9oupRpEnkwzhI30aYYxd/SNHHv6wRPM QzOE6MK/FJ2zOZLxxZRnb/qT2umWfgbVxBdsTJBbiTmmav3uugBS2ULmWzfYpi5ZRvee 4JwpBzoRvT/vJ8Mlec70YWBCxhB0qcYMY+h1eeFbL3FHHUN3xMH7o8jw/7k/01U76G0m zK06JWKY/qG2cuV9TunQZaROZp4vfEuOmhZpQwOYBaUPl1VOW++ci/E76DWDcjYLGzpi zlSLG0XTjcdgkH6YPHmQ1GHq6uTP+fiGOes65MPzug2FL7e5JlrSL7YzMe7CHO0C6ztD aqpg== X-Gm-Message-State: APjAAAVRiwfTMncMGrP3oo2ES/6safKZJtNLL4ySCa3xuTrsLVreFeAM yqQXc+mmmyZ5iOrMSTNwnMNBPfqg X-Received: by 2002:a2e:9205:: with SMTP id k5mr6297192ljg.246.1571412719588; Fri, 18 Oct 2019 08:31:59 -0700 (PDT) Received: from [192.168.2.145] ([94.29.10.250]) by smtp.googlemail.com with ESMTPSA id s1sm2274235lfd.14.2019.10.18.08.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2019 08:31:58 -0700 (PDT) Subject: Re: [RFT][PATCH 2/3] cpufreq: Use per-policy frequency QoS To: Viresh Kumar Cc: "Rafael J. Wysocki" , Linux PM , Linux ACPI , LKML , Sudeep Holla References: <2811202.iOFZ6YHztY@kreacher> <20154332.AJkCBzCetj@kreacher> <1707f018-fc6b-0122-17e0-635340daa4ef@gmail.com> <20191018092933.2i7dpr35wkxemgby@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Fri, 18 Oct 2019 18:31:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191018092933.2i7dpr35wkxemgby@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 18.10.2019 12:29, Viresh Kumar пишет: > On 18-10-19, 00:29, Dmitry Osipenko wrote: >> Viresh, the warning is actually triggered by this line: >> >> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/opp/of.c#L664 >> >> So it looks like the cpufreq-dt driver removal drops >> opp_table->list_kref more times than it should be. I may try to take a >> closer look at it later on, please let me know if you have any suggestions. > > I was able to reproduce it and have sent a fix and cc'd you on it. > Please give it a try. Thanks!