Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1756009ybg; Sat, 19 Oct 2019 01:51:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzs/9DxhUNzJ9nhP3Uo63lvVbddb7+WEJzzKdxHeQ3oTwyzj9dsnERqMkjQPwErlGYma4ra X-Received: by 2002:a50:d615:: with SMTP id x21mr14149247edi.297.1571475061724; Sat, 19 Oct 2019 01:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571475061; cv=none; d=google.com; s=arc-20160816; b=AbCwoXjiNNMHMkBTj9FqXQsy8CAYr27YrsQAZtinlFswZTz9x5oK7qTzc3hbheXoKY lF0ed6wR1ulJryCMm2HLlq3sEgDw94Thc0XoQY6hQMJUfPHMCpaADG1yPyNPQ7nbbebo 3wBK/k1Ze/HFU4XOUjLqPKWsouUsgnI2EPqQqgxRaNBdLQpdQGPNyt6k7Vnx9mjxiouS Bcf0ti4QKvPyqjtXclHTrs0KihC/PFrl9YaLacOUh5lm+ZBP8ekmw1KgV4Z4kLGhq7AX 8Baeinpch8m96svutL3K/CjgS5R1FsOVTQTAFcIXZdacQ7qLjVqQODY1Oot6csDJQXi6 3T9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=P2HH2SEAew8fPnT7kanY5vZdJ/omlbNVcjOXItS/b5A=; b=V5G3AtrBp/WuTqNRaCjob6nO2EyZ5gw8b3qWGduDTfzVuvehPCcMOpV8ir4wepIsKd pSUChuaZmICntwTOU63FE0eF1ndXcNH211PtdY9sNVq4mWwmIhf4MM1WTjqW0E4mewVV 4efAf/Xh+nV4/Dn2dViw55MUfEWiL35NS5sO40mgw57JYarW3HLsfIPUUNyi67X23WMj KU/pGcCCzE6H0BBVowTg1h85/2roebEZZD4AUsLOItk75C9J7L07QYldsEGDVkQrrMmW ePWSWHyVKyCPsjc56gNR44Xa88s1WpM71zQlE+oe4gjuoHK137TbdsrfzRl8abgZrRgW 4tAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f33si5840912edb.281.2019.10.19.01.50.38; Sat, 19 Oct 2019 01:51:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409353AbfJRQ5E (ORCPT + 99 others); Fri, 18 Oct 2019 12:57:04 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:52096 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405642AbfJRQ5D (ORCPT ); Fri, 18 Oct 2019 12:57:03 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 578A81560D; Fri, 18 Oct 2019 17:57:01 +0100 (BST) From: Mans Rullgard To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: "David S. Miller" , Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] net: ethernet: dwmac-sun8i: show message only when switching to promisc Date: Fri, 18 Oct 2019 17:56:58 +0100 Message-Id: <20191018165658.9752-1-mans@mansr.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Printing the info message every time more than the max number of mac addresses are requested generates unnecessary log spam. Showing it only when the hw is not already in promiscous mode is equally informative without being annoying. Signed-off-by: Mans Rullgard --- Changed in v2: - test only RXALL bit --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 79c91526f3ec..c186de64e552 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -646,7 +646,8 @@ static void sun8i_dwmac_set_filter(struct mac_device_info *hw, } } } else { - netdev_info(dev, "Too many address, switching to promiscuous\n"); + if (!(readl(ioaddr + EMAC_RX_FRM_FLT) & EMAC_FRM_FLT_RXALL)) + netdev_info(dev, "Too many address, switching to promiscuous\n"); v = EMAC_FRM_FLT_RXALL; } -- 2.23.0