Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Fri, 18 Oct 2019 15:07:38 -0300
To:     Jiri Olsa <jolsa@kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Stephane Eranian <eranian@google.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>
Subject: Re: [PATCH 05/10] libperf: Add _GNU_SOURCE define to compilation
Message-ID: <20191018180738.GD1797@kernel.org>
References: <20191017105918.20873-1-jolsa@kernel.org>
 <20191017105918.20873-6-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191017105918.20873-6-jolsa@kernel.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Why?


Em Thu, Oct 17, 2019 at 12:59:13PM +0200, Jiri Olsa escreveu:
> Link: http://lkml.kernel.org/n/tip-m7t1e9kgea4jc3piyvjju7ps@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/lib/Makefile       | 1 +
>  tools/perf/lib/tests/Makefile | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/tools/perf/lib/Makefile b/tools/perf/lib/Makefile
> index 0f233638ef1f..20396f68fcad 100644
> --- a/tools/perf/lib/Makefile
> +++ b/tools/perf/lib/Makefile
> @@ -73,6 +73,7 @@ override CFLAGS += -Werror -Wall
>  override CFLAGS += -fPIC
>  override CFLAGS += $(INCLUDES)
>  override CFLAGS += -fvisibility=hidden
> +override CFLAGS += -D_GNU_SOURCE
>  
>  all:
>  
> diff --git a/tools/perf/lib/tests/Makefile b/tools/perf/lib/tests/Makefile
> index a43cd08c5c03..78c3d8c83c53 100644
> --- a/tools/perf/lib/tests/Makefile
> +++ b/tools/perf/lib/tests/Makefile
> @@ -12,6 +12,8 @@ else
>    CFLAGS := -g -Wall
>  endif
>  
> +CFLAGS += -D_GNU_SOURCE
> +
>  all:
>  
>  include $(srctree)/tools/scripts/Makefile.include
> -- 
> 2.21.0

-- 

- Arnaldo