Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1763127ybg; Sat, 19 Oct 2019 02:01:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqy68gm9vryixQk5c4jHKcMYR+gF+WTYf3ankf04JZP9yxZoEyf5l+T0Il4jZsEKbXCjZAxx X-Received: by 2002:a17:906:9246:: with SMTP id c6mr12464236ejx.64.1571475683027; Sat, 19 Oct 2019 02:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571475683; cv=none; d=google.com; s=arc-20160816; b=Ds9AksVxMkdR9KvnvSxJojnd9Mz6snLflwOqrRuz30fBBf1gPT8BSliHSS3BPhbtgs LAPCSmhbZIRVseqwxCmENLdzLzlQYLBQuoJgZ1fNKfwSRXrfl/1LPklm72Vx7qStZOZP MobWLrTCgmAHwWLMv5R0ITDJxU8DhERzElyMaXz4EfLGcvaPoTD3ZJNphnpxfmrJYzrM 7q/eMg6rfpeMo5CIc7Xa0D0+k2Y2Y1Txtpv2spfuk6/1taZG29qK1Rq5nWG/+w6QzOGw JFTqqrEod3/yBqYc02A3aogJmW/RwrAnIXxQ74E9EliHuu67EDwzFPz9kyDLNsHZk/+x nQvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=bmhg+/17g88lQSaN0+48g3/Zis9k7Udg88qlSS1o+MA=; b=nJ3OtgXuEwq8OKP82vNRG6oQCAtvumNNR1pNW4Nr3seBesW3pgpZlas/1cZwQftvlL AUceUXGZOe1xIoDy00oiFuAzglA81RfAUcD1Ht6u7MdH6hzinS24qqnvSOB8DdS7LitV pr9NQoM+JQaPO0HyCIUEv0NJES2TiHoQdfYAlbVxuB3lHzjA2GZfkrHy7UXUUk1yG/X3 OzULTkiD7qukpuqT3aQn/dg4MK6oAmKUFWl6DMziSvSH/1wR9qR8Ui4pBemavcQViodW FvdXJM4Ftvhxlu5+xh5t3ujwvVh16uEMKvpShoTAV++Jc5n4dFixJzOrlD2/RbEFCFwf IYfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WsrEodvR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si5437686edc.404.2019.10.19.02.00.59; Sat, 19 Oct 2019 02:01:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WsrEodvR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505725AbfJRSHL (ORCPT + 99 others); Fri, 18 Oct 2019 14:07:11 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44890 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505717AbfJRSHI (ORCPT ); Fri, 18 Oct 2019 14:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=bmhg+/17g88lQSaN0+48g3/Zis9k7Udg88qlSS1o+MA=; b=WsrEodvRhBXE HYpwMKN35mSEhssW9zftk8eief4ZLz+Rs53Ri8erePRh6FWXNXHsQCcombxSTejhJS2mmMtOvVN4w P+7W+5KalXA5f0D6NEZDUlI8ECSQrg5WiXOVP26k3sHGxXDK3W7i/hRe7WIgwjammdTLJt0MLivsp KByxo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iLWeR-0004Es-0T; Fri, 18 Oct 2019 18:06:59 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 691AA2741DEA; Fri, 18 Oct 2019 19:06:58 +0100 (BST) From: Mark Brown To: Chuhong Yuan Cc: alsa-devel@alsa-project.org, "Cc:"@sirena.co.uk, "Cc:"@sirena.co.uk, Jaroslav Kysela , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Takashi Iwai Subject: Applied "ASoC: tlv320aic32x4: add a check for devm_clk_get" to the asoc tree In-Reply-To: <20191018081448.8486-1-hslester96@gmail.com> X-Patchwork-Hint: ignore Message-Id: <20191018180658.691AA2741DEA@ypsilon.sirena.org.uk> Date: Fri, 18 Oct 2019 19:06:58 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: tlv320aic32x4: add a check for devm_clk_get has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 1092b09708882e3c216f0b9c02e606b3c0942c5b Mon Sep 17 00:00:00 2001 From: Chuhong Yuan Date: Fri, 18 Oct 2019 16:14:49 +0800 Subject: [PATCH] ASoC: tlv320aic32x4: add a check for devm_clk_get aic32x4_set_dai_sysclk misses a check for devm_clk_get and may miss the failure. Add a check to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191018081448.8486-1-hslester96@gmail.com Signed-off-by: Mark Brown --- sound/soc/codecs/tlv320aic32x4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index 68165de1c8de..b4e9a6c73f90 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -573,6 +573,9 @@ static int aic32x4_set_dai_sysclk(struct snd_soc_dai *codec_dai, struct clk *pll; pll = devm_clk_get(component->dev, "pll"); + if (IS_ERR(pll)) + return PTR_ERR(pll); + mclk = clk_get_parent(pll); return clk_set_rate(mclk, freq); -- 2.20.1