Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1768036ybg; Sat, 19 Oct 2019 02:06:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2VuEWp9z97H8SbBwlHW0/8v7UFyBXyWCMZbihNtMOTKVKqV55alqcWyDAIJQ8iKiGzQ9b X-Received: by 2002:a05:6402:1511:: with SMTP id f17mr14108931edw.232.1571475979978; Sat, 19 Oct 2019 02:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571475979; cv=none; d=google.com; s=arc-20160816; b=e/Jy64UFAqUhWA9agwcrwJi9JJNx5/89TXxC/oj+5D1AeUOZM/wQOu4Vv6L7Fkuy6D TE7vZB9uhplnIGi+5FiHnTxaxy7yXOrv1K0sSCcANwrOvHBUoSz9qnfY3UcAbxyBsfM5 ePnb0ATa1MWPXkXeHnUXlnDAeUXSoyBxVumRwu4nwrsMTHvcXNN/MzhbNIQBQzXu2i+A dlnItNSxj2QB3GSvDiLAg8C6RNQh/2Ayf2IhrjOPGDGPWKXV65niRWkWP6iEs1jz3X6t qv8OwHlYa8E2J82YrheAreAgHn6G74wo09cQWSSqb670FKsKP10yS31oVtejjh0AyO6P S8wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=DO/a/phXhl0ktnXCOi2dJ5+kOviduNbcapLpkYYyEWk=; b=vgDGANQXykM9ln9BHT0/oG0XFlbbG7eTwYPMQ0fc+g/UZgiAF1+gPVUllFr2KmENsu ZYCVXHzGyi1r5W3JCuqPb7VINLg8X/AZqsT+hX2FsABLlAwcggxa13l/FJ/5OkmH3Kzc Wt3aNh/21b3/IMZYmC7HlO6A+wJ56cNc5m9tX8+dCM+7+49AOZrwdaR4LjDAPMRs+NCI EJpgIULXKiJbauFpW/w/S9vadLMwvlzfUQISp2/3lFmt7MaBOz37gmy3l65coyDaxfYe j0XraCwJUw184rV0QDF2M+Tv6XJLIKKi3tQfmuaE7/aknhxouFgxR7W0b1UcUkOmE2Ih TAGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=cjFTfPVv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si4626643ejw.229.2019.10.19.02.05.56; Sat, 19 Oct 2019 02:06:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=cjFTfPVv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505920AbfJRSkd (ORCPT + 99 others); Fri, 18 Oct 2019 14:40:33 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46042 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502264AbfJRSkc (ORCPT ); Fri, 18 Oct 2019 14:40:32 -0400 Received: by mail-lj1-f194.google.com with SMTP id q64so7175402ljb.12 for ; Fri, 18 Oct 2019 11:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=DO/a/phXhl0ktnXCOi2dJ5+kOviduNbcapLpkYYyEWk=; b=cjFTfPVvbl8MsUWT2blqjI7D/UzWWqMscY/aoCSNagnAdLyZQUeALz92b4699wBlT+ IdWkW+u7rupW5TONGtLImo8d+MudfU57UxSXGjgQclwP2J1fL00HtCvYrSnItcRQGqqA wqAVx4fbKWYXA6welrsOhQbGhWXCy3BH8mA97gbL/9FgT8AxoAL0PzpvUlxvnq5PbQY2 LEUyZn1y8d0hk2zpgTe/pXYFmaS5Jld+iImenu3pIk7Cue4giiHplBtsQdUznpFBfj72 4XFpY/UEBA7D54cOpRL8puvNcQ4v8gC62q5GcVphNUe3k1nSIxV8+LVNiYjRAIvABOOg mn3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=DO/a/phXhl0ktnXCOi2dJ5+kOviduNbcapLpkYYyEWk=; b=YA39QSuZwNNakKxAmiQCmbdTeyoF+Fc/7Pk2u2XW6EYeYd7tpKPxPSSwfIlxD02C1q t+yvnjwYC/Tfta9dH0l8r+i77qC2+aDzoKFwFT9lNLBfdt4P8I4XhKj1OmifWLxmmAFn mEpP3HXGhR1DOVbi2RAdESUQIku3Uxb9gBQWlv/L8y+g1ZCN/rVwha468i1EljMybkud +bm9R4sq4hKmeAr5a+Telrxs/kJ8Ox2MLl/NWR/rgLWL5ufJfENSr69CuEgaJJw0CxeD patvJ03i5lK9HbZjz8L6IJv2VHdsoQEzoA5JGJFYV2s0iyyzaCPNa2RTC0Krgxo483f0 zPvw== X-Gm-Message-State: APjAAAUlu8MoZwewcTuz6hs/eqF5GyV/5HwqgrWekfwIKQ0QTmk4atvQ atUO+4HPdhtkWdifC2Isfn07kw== X-Received: by 2002:a2e:a41a:: with SMTP id p26mr7331304ljn.49.1571424031135; Fri, 18 Oct 2019 11:40:31 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c4sm2716034lfm.4.2019.10.18.11.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 11:40:30 -0700 (PDT) Date: Fri, 18 Oct 2019 11:40:24 -0700 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , , Yonglong Liu Subject: Re: [PATCH net] net: hns3: fix mis-counting IRQ vector numbers issue Message-ID: <20191018114024.2102cde5@cakuba.netronome.com> In-Reply-To: <1571370179-52008-1-git-send-email-tanhuazhong@huawei.com> References: <1571370179-52008-1-git-send-email-tanhuazhong@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019 11:42:59 +0800, Huazhong Tan wrote: > From: Yonglong Liu > > Currently, the num_msi_left means the vector numbers of NIC, > but if the PF supported RoCE, it contains the vector numbers > of NIC and RoCE(Not expected). > > This may cause interrupts lost in some case, because of the > NIC module used the vector resources which belongs to RoCE. > > This patch adds a new variable num_nic_msi to store the vector > numbers of NIC, and adjust the default TQP numbers and rss_size > according to the value of num_nic_msi. > > Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") > Signed-off-by: Yonglong Liu > Signed-off-by: Huazhong Tan LGTM, thanks!