Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1770661ybg; Sat, 19 Oct 2019 02:09:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUSy+wEFA/ltHK9QC1G1wKTzcgzHheidE/sB49fYjHXWylGnWqoXECUGobRKJuHAHP0Fer X-Received: by 2002:a05:6402:13d5:: with SMTP id a21mr14409878edx.242.1571476156969; Sat, 19 Oct 2019 02:09:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571476156; cv=none; d=google.com; s=arc-20160816; b=aVFMKeqJuwqEOtUSYr/VNB7t4qOxocUzulndAlKDzf8Uu6K0LBNZHr34SWFrmVa3uq dzb8ZORXUHgzE7QHjwc6g6khFzMI+dhbqn/V8OoNdQiCEwvT6V63sZxbTlVuXnVhnTAW 5y2UsQO+GlTOm8Mc3mcP6kNji76hHvuvgoqHODxqfqMZ3jmEindlJyeKdvQ+vRJPC2bG x6OemSYLGh8LUoXLCZdfsWrItL+7pug3AMTmvMnTkXbkzriC36AQz0OM6CEXlWiQPZ2N BEE2Bo1WmiLLnEv1FFhsliicNYoNNB/6oMQAPltlxvRjbTj9bgEb2dgYQVCoDjsnOBLs 5kCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=azNOXQ1eb3b7cYf5iWwCVazwZ8Rn2J9TtJTxsJIkr2c=; b=gmIoXJvZCbjzqYQeksdby7QE0dTwy/FKVQQCf/HVj1r8MFHrPEcWAuhyRh6idd6hlp aDb9LV3GyFbv+dKHMtYEiwlt91IeB8OLAWj8CKjD2WVF4po2+C4aYzm/+EpV/t/gsWaS L+Cpf01yPwycc6UKj9q/hXEJvZ7e6nxoTRfr7e/voJTAKfPhQsSSaU8BFRdGc+LScamE fQlEfo6lObgptyphAvei5yJ90xaCZ0b8Kwkbl9SRbGatHLJSL3YtytMuZtgsNPvyIL5v igYpCblM0fbP0ZMArt/VJHB+vI85IJd4W+3tsW59ZYsBkeWP36TougxkfrqyzNubPJ3d fvng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16si5092081ejj.360.2019.10.19.02.08.53; Sat, 19 Oct 2019 02:09:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442996AbfJRSqc (ORCPT + 99 others); Fri, 18 Oct 2019 14:46:32 -0400 Received: from www62.your-server.de ([213.133.104.62]:55790 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfJRSqc (ORCPT ); Fri, 18 Oct 2019 14:46:32 -0400 Received: from 55.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.55] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iLXGf-00048I-Mt; Fri, 18 Oct 2019 20:46:29 +0200 Date: Fri, 18 Oct 2019 20:46:29 +0200 From: Daniel Borkmann To: Steven Rostedt Cc: Yonghong Song , YueHaibing , "mingo@redhat.com" , "ast@kernel.org" , Martin Lau , Song Liu , Andrii Nakryiko , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH bpf-next] bpf: Fix build error without CONFIG_NET Message-ID: <20191018184629.GD26267@pc-63.home> References: <20191018090344.26936-1-yuehaibing@huawei.com> <20191018142025.244156f8@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018142025.244156f8@gandalf.local.home> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25606/Fri Oct 18 10:58:40 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 02:20:25PM -0400, Steven Rostedt wrote: > On Fri, 18 Oct 2019 18:11:07 +0000 > Yonghong Song wrote: > > On 10/18/19 2:03 AM, YueHaibing wrote: > > > If CONFIG_NET is n, building fails: > > > > > > kernel/trace/bpf_trace.o: In function `raw_tp_prog_func_proto': > > > bpf_trace.c:(.text+0x1a34): undefined reference to `bpf_skb_output_proto' > > > > > > Wrap it into a #ifdef to fix this. > > > > > > Reported-by: Hulk Robot > > > Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers") > > > Signed-off-by: YueHaibing > > > > Acked-by: Yonghong Song > > I'm getting ready for another push to Linus. Want me to pull this into > my tree? It's related to bpf-next, so only bpf-next is appropriate here. We'll take it. Thanks, Daniel