Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1771387ybg; Sat, 19 Oct 2019 02:10:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVCIvo2ZOaRTGykp12PWR0P7pWsKdXmKIfe/AvAJ63A4hUgvDHKPARvvm3B36M5Z1Yzkyb X-Received: by 2002:a17:906:1342:: with SMTP id x2mr12520845ejb.304.1571476208205; Sat, 19 Oct 2019 02:10:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571476208; cv=none; d=google.com; s=arc-20160816; b=vm9m7jjAM/j0XpfuQJ430VR/xxDE+EBHFaFV2pmkT6ezSRHIYP7yBR1HD0o7nk+uR2 vx+Itu8+XaXJVP/XZ6OQ5VsBwNNyhgFNPWixp7VnmNXBSjM3p629T5yzgb2MtDj+vx1X 3xHKNtV+FFQwXydQRmhBOJxQBAZaYEyzAMG6BQDWpyvKrxDUY45r96cgM/LTCjEd4hQs Q8hisFcLFrlq3Frq5qjgmlsS55JsGmuwk7oBvgSdbjji3cxKjjvLa6oX3EtR9eHsVgCP IdtDkMjOx2sNp6XzQnXZJhAgG5GSdGMEyUzgzwry7GxblnZqNHjL6QskkUnVyw2jeQzf ouPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gChMufF7pDlsTELG5XA6EwZSwB7D7Bj07q+bOG1oGb4=; b=mqt4vEn0AEcjFYgq84mN9pz9aQEfJwfTQEPGZXSmjJne65aRRGyTGCaZmsQacl9qrK uOk1d819tyEXzWMs2c//Y32C8QwUF6R9AsgqDLBOk4OtkTfg6C8uQKtEyOZghwObaV9b JW9xGd8jp41/ZmNoJrPIG7YNeJgJhNnCP3UzWrMdFeJ+V3XOpjhI5HNj5mEJuec+4BBl xTERqhF8e1maEwcXoSwLe2efZzjLcYqrCREuG3dBRkb5XvYrmyWRszp51kgKQ5m8rfVb 2/0gGLObNpmOwYWQ+zE9Img8B5tc+Rkj6vTrdkA+vqCbh352J5kHoGLTz8g/LFxG/iNz ao9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=IGyKEOZx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si5203236ejc.366.2019.10.19.02.09.45; Sat, 19 Oct 2019 02:10:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=IGyKEOZx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443242AbfJRTEo (ORCPT + 99 others); Fri, 18 Oct 2019 15:04:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2443231AbfJRTEo (ORCPT ); Fri, 18 Oct 2019 15:04:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gChMufF7pDlsTELG5XA6EwZSwB7D7Bj07q+bOG1oGb4=; b=IGyKEOZxoCUxnUeBCWOSJG2WA1 pwJZL0JfM1HnI+xcXSvrTouBqKE3Mc7qzDHniX8gNfhsM2muWm6BjYSAn1xIqqVE3EXORzkqF1y5C XOJvSFQxejNpDcR5xhWrLVoezqOGDnZrYxYswo7rAkTvoiDzEtyWq7LjfIYxen+XJk08=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iLXYA-0002oW-Fo; Fri, 18 Oct 2019 21:04:34 +0200 Date: Fri, 18 Oct 2019 21:04:34 +0200 From: Andrew Lunn To: Chen Wandun Cc: igor.russkikh@aquantia.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Message-ID: <20191018190434.GG24810@lunn.ch> References: <1571394037-19978-1-git-send-email-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571394037-19978-1-git-send-email-chenwandun@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 06:20:37PM +0800, Chen Wandun wrote: > From: Chenwandun > > add an error handling in aq_nic_set_multicast_list, it may not > work when hw_multicast_list_set error; and at the same time > it will remove gcc Wunused-but-set-variable warning. > > Signed-off-by: Chenwandun Reviewed-by: Andrew Lunn Andrew