Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1773383ybg; Sat, 19 Oct 2019 02:12:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdB7mvLc6gScCDG/ifDne+En9euAqAB/RVUiQdLEpmrGq3oL0Hcs6LwgNTbUMJ7jrfYqwU X-Received: by 2002:a17:906:6011:: with SMTP id o17mr12235463ejj.172.1571476348600; Sat, 19 Oct 2019 02:12:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571476348; cv=none; d=google.com; s=arc-20160816; b=qs5WO0261ObSowdTTFqql3N8Iw1h0J5aSca4Wgv9BtVcGmioAxpiU7JcSTyd1u+QWk +8JLl/dE/mVFXfV1pHqIFcnNRKfgt3EWWCJUNlocnjpzXdYkCjZ53TQDcJT/Z48jmpR2 x5Y0NaC2qa6bi7HESCi963uRdort5T0gRaLQOFK2BhZeeLo+chEcbOw/OQW0Fxs2zJ3n ScU4vO1C1Q+JC2ZEbAKyxqSZpo1YzXRYsxEO6ba+w8Wv6zzSPF5IZQ+6F4Dnd0g3PWsB 6KyDZzcbScyWBNZ7syk8G2naOBZadJRPm1MlMizbhfjUtT6w++BiGfCNAHYwKKDtaqD2 LNvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=axKpVbFOFaa+n4Qf4ecERSnPwSYEN3pzDrn7BnFEAL4=; b=FAVPpbHZWYDpPy5LtNHyIhbcB1TcP0uHNAXLVV8Ph0W1Ajae1dG2nZt8253mvzePrq lWEuYHs4MMpoFvBtVlP8la5Ph40uIakv2ipu6zjR7/RQoxC2NH9C73AAO0vx0Ex//8b7 uIOtddT/CiAza04JcHhtRAi1lpSLb7R7BaTypQsg/daqLrL6VMFlyMnfQ2sGA7O3iHNC ZScNG8W1SoYKueT7UG5tw5AjAMLDsj7atr6h6cZQKnpAEb386wF/yjq670flXeV2sS0N iyrCRaj4uRDPiPUlGoHIABuHA85ruR9ad7GAfLIVtNL58IjYfCfs6hV0KcWW0LaWmYiV CYPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si4626643ejw.229.2019.10.19.02.12.05; Sat, 19 Oct 2019 02:12:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505878AbfJRTLB (ORCPT + 99 others); Fri, 18 Oct 2019 15:11:01 -0400 Received: from www62.your-server.de ([213.133.104.62]:60092 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502792AbfJRTLB (ORCPT ); Fri, 18 Oct 2019 15:11:01 -0400 Received: from 55.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.55] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iLXeM-0005sD-1a; Fri, 18 Oct 2019 21:10:58 +0200 Date: Fri, 18 Oct 2019 21:10:57 +0200 From: Daniel Borkmann To: YueHaibing Cc: rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] bpf: Fix build error without CONFIG_NET Message-ID: <20191018191057.GG26267@pc-63.home> References: <20191018090344.26936-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018090344.26936-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25606/Fri Oct 18 10:58:40 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 05:03:44PM +0800, YueHaibing wrote: > If CONFIG_NET is n, building fails: > > kernel/trace/bpf_trace.o: In function `raw_tp_prog_func_proto': > bpf_trace.c:(.text+0x1a34): undefined reference to `bpf_skb_output_proto' > > Wrap it into a #ifdef to fix this. > > Reported-by: Hulk Robot > Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers") > Signed-off-by: YueHaibing Applied, thanks!