Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jayachandran Chandrasekharan Nair <jnair@marvell.com>
To:     Will Deacon <will@kernel.org>
CC:     "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Linux ARM Kernel Mailing List 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] arm64: Fixes for -rc4
Thread-Topic: [GIT PULL] arm64: Fixes for -rc4
Thread-Index: AQHVhe/ZwIy5QqJa20KlS/0SJEuoMQ==
Date:   Fri, 18 Oct 2019 20:09:02 +0000
Message-ID: <20191018200839.GA18931@dc5-eodlnx05.marvell.com>
References: <20191017234348.wcbbo2njexn7ixpk@willie-the-truck>
In-Reply-To: <20191017234348.wcbbo2njexn7ixpk@willie-the-truck>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [199.233.59.128]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: aa853055-6cdc-4518-590a-08d75407051c
x-ms-traffictypediagnostic: CY4PR1801MB1848:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <CY4PR1801MB1848DCF95FA2BAC2DEB90E21A66C0@CY4PR1801MB1848.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 01949FE337
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(199004)(189003)(66066001)(256004)(6916009)(25786009)(4326008)(305945005)(966005)(7736002)(86362001)(71200400001)(71190400001)(478600001)(3846002)(6116002)(14454004)(6246003)(64756008)(316002)(8676002)(446003)(6306002)(186003)(476003)(229853002)(6436002)(2906002)(6512007)(8936002)(386003)(11346002)(1076003)(99286004)(81156014)(81166006)(33656002)(102836004)(5660300002)(76176011)(6486002)(52116002)(66946007)(66556008)(66476007)(66446008)(26005)(486006)(6506007)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1801MB1848;H:CY4PR1801MB1895.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8MLjwgqLQ+Nc1ElAB6myhCap8imJIZWmLWyNEA7M3+yOw74+O+qBsVIKlhITUs0jDUS1Z6xW7vpbD7K7g63GHC6vj0fw+p1LGl9pHc/1v020BryWmliHyukwllP4Scyc/KtNCAsVEWkg+YfZzqF6HJzIAS1xTtUzi07xVYjNbx5eG72+7STDmCyrXg3m3chGFT7ORBsV4hDs2fK9PT7qK4RaDbDJA50b22IM7XhTBqco5QMjmxvGlFPb2aJAkBS4/YuqGp/jyRzSTVNTE6Y0YtN40ZNkFytEyCKH6HuU9Y2LAcURdPW5c9rrDulAu9uqFbGfIcjN/MTbZuUnTiLeQYt1m/mjM1eXWhi0MCzg29VnkeYtr6qcCzhixvMDQ7h0Wks6neM70BZQfUUcaZBXDU2TABOlg6FPj9V+9Pbk3xe/DLUaJCmUNFjKEoOHq73E6TKEhIquOc2x+ryhZguU7w==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E2818D79E9DF874186874DB6F2C5141A@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aa853055-6cdc-4518-590a-08d75407051c
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2019 20:09:02.6580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H/RuhIHLsoIkbXckRdl0p92N5A0KDkCRyLRNCdxmDl2cfSDCDuWJGa9+MUW43oAk764Tk5nB0J+U2T9ui+UMKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1848
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-18_05:2019-10-18,2019-10-18 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 18, 2019 at 12:43:49AM +0100, Will Deacon wrote:
> Hi Linus,
>=20
> Please pull these arm64 fixes for -rc4. The main thing here is a
> long-awaited workaround for a CPU erratum on ThunderX2 which we have
> developed in conjunction with engineers from Cavium/Marvell. At the momen=
t,
> the workaround is unconditionally enabled for affected CPUs at runtime
> but we may add a command-line option to disable it in future if performan=
ce
> numbers show up indicating a significant cost for real workloads.

As the Cavium/Marvell engineer who was involved in this, I will note
that I had suggested a patch providing a runtime override[1] while
providing safe defaults.

Marc's patchset adds a trap to hypervisor in the system call path when
KPTI is enabled, and KPTI is generally enabled on stock VM images. So
normal users will see some performance regression (e.g I see something
in the range of 3-4% on guest kernel compile).

As a policy, I don't agree with having errata workarounds that can be
left to the discretion of the admin to be forced at compile time.
Since most of these workarounds use run-time code patching with
alternatives, there is no need to do this at all.

But given that this is already merged and cc:ed to stable, I will see
if I can come up with enough data to convince Will.

JC
[1]
https://lore.kernel.org/linux-arm-kernel/20191011232031.GA29752@dc5-eodlnx0=
5.marvell.com/T/