Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1781902ybg; Sat, 19 Oct 2019 02:23:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzeEEH9FCQjbh1blcSJOnq69zguEp67tdJWoL89W6P1iLP0AhDUYTfT2+ipATn+FeMwXic5 X-Received: by 2002:a17:906:792:: with SMTP id l18mr12357930ejc.170.1571476991321; Sat, 19 Oct 2019 02:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571476991; cv=none; d=google.com; s=arc-20160816; b=WGY0Bh0eQdrGs1ZAjTQXKzL75J170jwZG+YQl/8TiON14OKv/905qYXf+IsrEGnLD5 ieWGA32iSFkPWnpuCbWn5TwfCgsCwwr4hOxj2hH4Ollg/NvJsR8WbuD7UfXgah9TAx7v 1jJyaloKeNHJZvfGyIZY2sfXZlwFuV557zKwSwWfVBz6tjWufjwVAzy6KyxBWCecg3xU QkunULTGkCgFcgoj3zlqLso2Sut3gSX98ydteCof+6fIDAhyfFA3cZB6RDArw7O92bs6 bMRfcinCMWpVF7iY5NKx1UsaUgAioRg/jXrGry2/WaYk6ELLxdYzFtsH6r0OzvMcHAhi gnNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=oIXMUgijEE7y4qWQFymThn8iY/Hvr2ojgKSft1IuDyY=; b=xsXWGWg/EpawdEGix7dWXOV2fAvxDlYDTuF5n1uP9SFMMNDR7uloY2qUs62K4XzMfL 2xt+vGwrEzAbhrkjJxCeHGbZe0hpDbLjj6jDX1+UyhxWJOImMIQSz7Tn3cttXJRLOFnY HoHMhfdSzZgodNxYv/v1Z4WZkHOj86/emzfksGermusKJL3sQZIO8jcMirzrI8oypF+0 KG1Bn7hOs0eCxv+K7nXWOI/b6S9hQw4cg+mLW3WEZDRyzdxjQwgIp2vyNN2GP81RvRQm P4GU9upgGWjqv+RU+JneuZGYWdBjCoZivpjHwW6sSQLojtyCN5KqLhVtErV97SRIzSoq 03Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=piDmvKdx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h45si1298296eda.356.2019.10.19.02.22.48; Sat, 19 Oct 2019 02:23:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=piDmvKdx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbfJRWAV (ORCPT + 99 others); Fri, 18 Oct 2019 18:00:21 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:55084 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbfJRWAV (ORCPT ); Fri, 18 Oct 2019 18:00:21 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9ILsWTJ086675; Fri, 18 Oct 2019 22:00:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=oIXMUgijEE7y4qWQFymThn8iY/Hvr2ojgKSft1IuDyY=; b=piDmvKdxJ5TnfUlXn6c421JbfpL6LXLCDkdUf5X6UIJ8h32bLEazGQyPl+ZBiKKW7n1q OxCBnnqvzIaM2P3p67D9ywIRIoBtUJjQtvsr2St3ldPSTbgTxUQmm6EasYVVg2XnP4Ep o/EtcBSMFmPPjI2nRCQYxul+sQBrlVJxkqhctJWrfuhUVtnfKudLDvLQdcLM0GxVsiz5 TutkJKO5WJjA0/G0GknC93l8FF+T5sJC4BfqFmX0xp+/462zMzdhKD8ENBFt0HT8yCD6 eqbwkS+bvftUHl7ioXEIMCBiuu32ionniYpKPQsHUNI3ex0EBPYD9EOq1i9pSZSkul4R YQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2vq0q468rn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 22:00:15 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9ILt11n097336; Fri, 18 Oct 2019 22:00:15 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2vq0eexd3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2019 22:00:14 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9IM0Bee021712; Fri, 18 Oct 2019 22:00:11 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 18 Oct 2019 22:00:11 +0000 To: Daniel Wagner Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Dick Kennedy , James Smart Subject: Re: [PATCH] scsi: lpfc: Check queue pointer before use From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191018162111.8798-1-dwagner@suse.de> Date: Fri, 18 Oct 2019 18:00:09 -0400 In-Reply-To: <20191018162111.8798-1-dwagner@suse.de> (Daniel Wagner's message of "Fri, 18 Oct 2019 18:21:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9414 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=500 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180193 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9414 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=599 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910180193 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel, > The queue pointer might not be valid. The rest of the code checks the > pointer before accessing it. lpfc_sli4_process_missed_mbox_completions > is the only place where the check is missing. Applied to 5.4/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering