Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1806609ybg; Sat, 19 Oct 2019 02:55:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOMTmdIwYv/TQp4T52N8NXnVn8qR5HNT8B+QqTebRIGc7YG0fwLcavFMKu+A/E7H7iHWVb X-Received: by 2002:a17:906:60c2:: with SMTP id f2mr12766512ejk.21.1571478951598; Sat, 19 Oct 2019 02:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571478951; cv=none; d=google.com; s=arc-20160816; b=IzDnzz8py9weH5HL42jerEHMTzF3mmw93wlu2fUe/DSdrEJ7U8avs6fsk8I2JzCP72 gh+2/kvDaFgOs4Rdw8ZkzakarzDtROO8mv7B2iKsvVtQGGDM3XYzoVimzCgGvArgdqEj a5O76GYvPtKNy7OvRaSV7dliHBKRKpdOc3LzikEFR9mU//xCRFpCoeWl2W5lx6KtkFIE LaK18zgzj0/y3XtN70m9P86cfjs7AjyWMpy9Q0NjhsJOkDOrqxZR0yE97pcDRZCcL1fc mOrse6sFr45Uy/6AtZGg8PxCLk04yYG3HhF+uhSfc4plutHL2+orzFEantbxWovLuroS /pfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sBhdJJsKEU5N2pXvvia6LRQuh+baua5m3sswozX8DKc=; b=ND1u7p7jwATaoFq8/Ncei36YN04McHctpHWvlsQeiPKIyeFDF//LekWCtK49ASNv0J 1oQYSDo2sexmz+4g/LelT10FWns2Aehp499PwkD5TbpZo3NZD+1Ri/FWH05P/1cn3eko KKBdZH4QntlQekTizIxYh1RKvoaxvRd6gFewWyi8FhGCQBvoAiDRuDgI+PpXon+Q3uKz DT89IoPkeGojczbAs881mARuzPY9Zf2/J5xebBsBnXjqsZ0mN5uplwsFtlaREi2QOrQn Bix1lzrFkbupNBM0FgQtFKL3vVSRivWpJeyoLfQ0kOvc/+n0vTGi71MGFFTpiV+5UXLu DiGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=By988nsu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si409843ejf.346.2019.10.19.02.55.28; Sat, 19 Oct 2019 02:55:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=By988nsu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727917AbfJSIMT (ORCPT + 99 others); Sat, 19 Oct 2019 04:12:19 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59696 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfJSIMT (ORCPT ); Sat, 19 Oct 2019 04:12:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sBhdJJsKEU5N2pXvvia6LRQuh+baua5m3sswozX8DKc=; b=By988nsuxisz7nl4WH5MhPeZZ jfBw4xssv+LaWS45bLrL+8d42ic9ebOR32b2OhRN4YglMDlSygEwsGiuAnwJrPSUW2mkezUMM/27l 6hkaG1KaE7EKHxT1838ED6voBzww35PKkPCsfXLY9m0PJeIycXFhtfeqYEOpUzaKiiqnTVubkYjDn n3TJcI4D6/TucIxaCZ3jKcTZUpjOEAomRKk+xKpG/9SDeCuQ0xNOtZgWQ7tW2wI7mPN3N+1NF82Z6 0ZFaUcPB0MoijrsN5QlH2JDTyVQdZWxhrhJ0fpgj8LVihB7OZj/7P1Apmx23HJvI9CR9urnxiQ/0H 3monsTkMg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLjqS-00006r-Ow; Sat, 19 Oct 2019 08:12:16 +0000 Date: Sat, 19 Oct 2019 01:12:16 -0700 From: Christoph Hellwig To: Thomas Meyer Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: replace homemade binary search Message-ID: <20191019081216.GA21691@infradead.org> References: <20191019072033.17744-1-thomas@m3y3r.de> <20191019072033.17744-2-thomas@m3y3r.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191019072033.17744-2-thomas@m3y3r.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 19, 2019 at 09:20:33AM +0200, Thomas Meyer wrote: > use newly introduced bsearch_idx instead. > > Signed-off-by: Thomas Meyer What is the point? This adds more code, and makes it slower by adding an indirect function call.