Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 19 Oct 2019 19:37:31 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Stephane Eranian <eranian@google.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>
Subject: Re: [PATCH 05/10] libperf: Add _GNU_SOURCE define to compilation
Message-ID: <20191019173731.GA12782@krava>
References: <20191017105918.20873-1-jolsa@kernel.org>
 <20191017105918.20873-6-jolsa@kernel.org>
 <20191018180738.GD1797@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20191018180738.GD1797@kernel.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 18, 2019 at 03:07:38PM -0300, Arnaldo Carvalho de Melo wrote:
>=20
> Why?

it's passed when the library is compiled with perf, but not
when you compile it standalone.. and 2 '-D_GNU_SOURCE' on
command line are ok

jirka

>=20
>=20
> Em Thu, Oct 17, 2019 at 12:59:13PM +0200, Jiri Olsa escreveu:
> > Link: http://lkml.kernel.org/n/tip-m7t1e9kgea4jc3piyvjju7ps@git.kernel.=
org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/lib/Makefile       | 1 +
> >  tools/perf/lib/tests/Makefile | 2 ++
> >  2 files changed, 3 insertions(+)
> >=20
> > diff --git a/tools/perf/lib/Makefile b/tools/perf/lib/Makefile
> > index 0f233638ef1f..20396f68fcad 100644
> > --- a/tools/perf/lib/Makefile
> > +++ b/tools/perf/lib/Makefile
> > @@ -73,6 +73,7 @@ override CFLAGS +=3D -Werror -Wall
> >  override CFLAGS +=3D -fPIC
> >  override CFLAGS +=3D $(INCLUDES)
> >  override CFLAGS +=3D -fvisibility=3Dhidden
> > +override CFLAGS +=3D -D_GNU_SOURCE
> > =20
> >  all:
> > =20
> > diff --git a/tools/perf/lib/tests/Makefile b/tools/perf/lib/tests/Makef=
ile
> > index a43cd08c5c03..78c3d8c83c53 100644
> > --- a/tools/perf/lib/tests/Makefile
> > +++ b/tools/perf/lib/tests/Makefile
> > @@ -12,6 +12,8 @@ else
> >    CFLAGS :=3D -g -Wall
> >  endif
> > =20
> > +CFLAGS +=3D -D_GNU_SOURCE
> > +
> >  all:
> > =20
> >  include $(srctree)/tools/scripts/Makefile.include
> > --=20
> > 2.21.0
>=20
> --=20
>=20
> - Arnaldo