Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 19 Oct 2019 19:49:00 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Steve MacLean <steve.maclean@linux.microsoft.com>
Cc:     Steve MacLean <Steve.MacLean@microsoft.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] perf inject --jit: Remove //anon mmap events
Message-ID: <20191019174900.GC12782@krava>
References: <1571336600-21843-1-git-send-email-steve.maclean@linux.microsoft.com>
MIME-Version: 1.0
In-Reply-To: <1571336600-21843-1-git-send-email-steve.maclean@linux.microsoft.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 17, 2019 at 11:23:20AM -0700, Steve MacLean wrote:
> From: Steve MacLean <Steve.MacLean@Microsoft.com>
>=20
> While a JIT is jitting code it will eventually need to commit more pages =
and
> change these pages to executable permissions.
>=20
> Typically the JIT will want these colocated to minimize branch displaceme=
nts.
>=20
> The kernel will coalesce these anonymous mapping with identical permissio=
ns
> before sending an MMAP event for the new pages. This means the mmap event=
 for
> the new pages will include the older pages.
>=20
> These anonymous mmap events will obscure the jitdump injected pseudo even=
ts.
> This means that the jitdump generated symbols, machine code, debugging in=
fo,
> and unwind info will no longer be used.
>=20
> Observations:
>=20
> When a process emits a jit dump marker and a jitdump file, the perf-xxx.m=
ap
> file represents inferior information which has been superceded by the
> jitdump jit-xxx.dump file.
>=20
> Further the '//anon*' mmap events are only required for the legacy
> perf-xxx.map mapping.
>=20
> Summary:
>=20
> Add rbtree to track which pids have sucessfully injected a jitdump file.
>=20
> During "perf inject --jit", discard "//anon*" mmap events for any pid whi=
ch
> has sucessfully processed a jitdump file.
>=20
> Committer testing:
>=20
> // jitdump case
> perf record <app with jitdump>
> perf inject --jit --input perf.data --output perfjit.data
>=20
> // verify mmap "//anon" events present initially
> perf script --input perf.data --show-mmap-events | grep '//anon'
> // verify mmap "//anon" events removed
> perf script --input perfjit.data --show-mmap-events | grep '//anon'
>=20
> // no jitdump case
> perf record <app without jitdump>
> perf inject --jit --input perf.data --output perfjit.data
>=20
> // verify mmap "//anon" events present initially
> perf script --input perf.data --show-mmap-events | grep '//anon'
> // verify mmap "//anon" events not removed
> perf script --input perfjit.data --show-mmap-events | grep '//anon'
>=20
> Repro:
>=20
> This issue was discovered while testing the initial CoreCLR jitdump
> implementation. https://github.com/dotnet/coreclr/pull/26897.

I posted some questions for previous version in here,
but can't find answers:
  https://lore.kernel.org/lkml/20191003105716.GB23291@krava/

thanks,
jirka