Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2247866ybg; Sat, 19 Oct 2019 11:09:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOzbTP9j8yRuG+pFDAP8nJAQCw91SK9UPKSdZFTxY3crnZCAXzpNK8W+uLDnIVNUFzYpDW X-Received: by 2002:a17:906:58d:: with SMTP id 13mr14358197ejn.293.1571508588452; Sat, 19 Oct 2019 11:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571508588; cv=none; d=google.com; s=arc-20160816; b=Rr0x2RpwFByowMoL74Zod0ChAWuDdsKFF3iEO3QNaL48Y9BTS2T1sUmQqMwFWM/mLz K6FMsn4zx9j8DuQckKP6Y/NJs7nd2hkBjChv7Q2crJRbP8svG/lXtoxkjyPDoMO6cztP g9iqhcfcTq5fdh7gNR/fgxFdGWt4XEk3tz+wwUBWAFYdW5MucgrFRWqrCHw7qTWv4fRM vttgF3l6rr8ZYoFIBLAKZVsF7JuTIZK0YRJAUK5DZBav1icYmOWoiSg86mu4b/cmVaWU BFw2nA+6lg03JkAbNXHicNVz9FQJbwnIsfrrnU3ugdhREbjlkSnc8pJIU8idypBbz5gy YiOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xzaow11/xSCqBracFjPSult9QZ36gtDXdo3LvSEBtNo=; b=TKZzq2A4p0EgbhYIFPuRkJ680yGRPRrG9K3MT2vAvVgciSugdPnW2SZTp/U+3EW9yx LpyZ4Zuyx4QN7vBEIxLZR00AI+ghPo5bWENRku5V0l0j58lDF8XzVZcKkFRqtQZ2+AXW 1NLjWFzmKNEw4vPJDC1jImG1qooZrgfTUgAkcdSSaFI+myHnKHvCv897Fz9pk4PeqA8J Wq55Np6HfZZu0oawJm6w0alixz4L8esU6VK42KvzhbR/C1wqF33R4U5MN5pkDd8lvnFq MRCpAis10YuHzcwSoUGJqMxm4fQ4IBFkup0iVk30bP1h3ui5L7qBoUZ5uBDV95dCLD7D pw/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=iDtdMIIk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si6579815edt.32.2019.10.19.11.09.25; Sat, 19 Oct 2019 11:09:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=iDtdMIIk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfJSSHf (ORCPT + 99 others); Sat, 19 Oct 2019 14:07:35 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:40250 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfJSSHf (ORCPT ); Sat, 19 Oct 2019 14:07:35 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9JI4PpP055516; Sat, 19 Oct 2019 18:07:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=xzaow11/xSCqBracFjPSult9QZ36gtDXdo3LvSEBtNo=; b=iDtdMIIk2Ez8a4Y7MNJiIuvn7RpyEMjJg6bALuhHOrokqqRWY0LxR0L1Rk1lZEuwyRJf jT5IoSHoudMQe46OEo5xDPYf7McxF1JI+DjVF/V8Hy9ba9Bpv9eDwunKmRuPr2J7T0nL MP/2Fm81f9/KvbH2dbynifA7r2/MhQcN6/q5YD6ZwLFnYXmJa5+14PX1r9X1vTRLEIsh n5m4A0zf+KYByoNz4HtDSsDNgzEWGfqGE0/f6QoZZ/VX5distDMipKOER2mw/uZAX9I5 vF8Quo/3IBxxyVyscp4wpQseKrKLVWeROqJ5iM1c4NWumI1QP8rIDUXbfs7T4BSlRL6V vg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2vqtep9kp1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Oct 2019 18:07:30 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9JI3sUI036452; Sat, 19 Oct 2019 18:05:30 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2vqrhe7fe8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Oct 2019 18:05:30 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9JI5SJB019107; Sat, 19 Oct 2019 18:05:28 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 19 Oct 2019 18:05:27 +0000 Date: Sat, 19 Oct 2019 21:05:14 +0300 From: Dan Carpenter To: Jules Irenge Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary Message-ID: <20191019180514.GI24678@kadam> References: <20191019140719.2542-1-jbi.octave@gmail.com> <20191019140719.2542-2-jbi.octave@gmail.com> <20191019142443.GH24678@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9415 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910190170 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9415 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910190170 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 19, 2019 at 04:09:03PM +0100, Jules Irenge wrote: > Checkpatch was complaining about space between type cast and the > variable. I just get rid of the space. Well I don't know whether this was > false positive one. > > Thanks for the feedback. I will update the patch. No no. The patch is fine. I was saying that in the *future* you might want to look at the void casts. Some of them are not required and others are buggy code. regards, dan carpenter