Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 20 Oct 2019 14:30:14 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Dan Murphy <dmurphy@ti.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt: power: Add the bq2515x family dt bindings
Message-ID: <20191020123014.trvn5auxbv6ftngj@earth.universe>
References: <20190930143137.21624-1-dmurphy@ti.com>
 <20190930143137.21624-2-dmurphy@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rtitbtohtnvbnysq"
Content-Disposition: inline
In-Reply-To: <20190930143137.21624-2-dmurphy@ti.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--rtitbtohtnvbnysq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Dan,

On Mon, Sep 30, 2019 at 09:31:36AM -0500, Dan Murphy wrote:
> Add the bindings for the bq25150 and bq25155 500mA
>  charging IC from Texas Instruments.
>=20
> Datasheet:
> http://www.ti.com/lit/ds/symlink/bq25150.pdf
> http://www.ti.com/lit/ds/symlink/bq25155.pdf
>=20
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  .../bindings/power/supply/bq2515x.txt         | 48 +++++++++++++++++++

This should use the new YAML binding style.

>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515=
x.txt
>=20
> diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.txt b=
/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> new file mode 100644
> index 000000000000..98203ab53d44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> @@ -0,0 +1,48 @@
> +Binding for TI bq25150 500-mA Linear charger
> +
> +The BQ25150 is a highly integrated battery charge management IC that int=
egrates
> +the most common functions for wearable devices, namely a charger, an
> +output voltage rail, ADC for battery and system monitoring, and
> +push-button controller.
> +
> +Required Properties:
> +	- compatible: Should contain one of the following:
> +		"ti,bq25150"
> +		"ti,bq25155"
> +	- reg: int I2c address 0x6b
> +	- #address-cells: 1;
> +	- #size-cells: =3D 0;
> +
> +Optional Properties:
> +	- ti,battery-regulation-voltage: integer, maximum charging voltage in m=
V.
> +		Values range from 3600->4600mV
> +	- ti,charge-current: integer, maximum charging current in mA.
> +		Values range from 50->600mA

Those values should be in uV and uA. Also the values basically
describe the dumb battery, so please use this binding:

Documentation/devicetree/bindings/power/supply/battery.txt

> +	- reset-gpios: GPIO used for Master reset
> +	- low-power-gpios: GPIO used for low power mode of IC.
> +	- charge-enable-gpios: GPIO used to turn on and off charging.
> +	- pg-gpios: GPIO used for connecting the bq2515x device PG (Power Good)
> +		pin.  This pin should be used if possible as this is the
> +		recommended way to obtain the charger's input PG state.
> +		If this pin is not specified a software-based approach for PG
> +		detection is used.
> +
> +Example
> +bq25150@6b {

charger@6b

> +	compatible =3D "ti,bq25150";
> +	reg =3D <0x6b>;
> +	#address-cells =3D <1>;
> +	#size-cells =3D <0>;
> +
> +	pg-gpios =3D <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +	reset-gpios =3D <&gpio0 14 GPIO_ACTIVE_HIGH>;
> +	low-power-gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>;
> +	charge-enable-gpios =3D <&gpio0 13 GPIO_ACTIVE_LOW>;
> +
> +	ti,charge-current =3D <300>;
> +	ti,battery-regulation-voltage =3D <4200>;
> +};
> +
> +Reference Datasheet:
> +http://www.ti.com/lit/ds/symlink/bq25150.pdf
> +http://www.ti.com/lit/ds/symlink/bq25155.pdf
> --=20
> 2.22.0.214.g8dca754b1e
>=20

-- Sebastian

--rtitbtohtnvbnysq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl2sU1YACgkQ2O7X88g7
+pqvZA//fM8eIVmOvdIvzuodwv79zMkuzA/5HrJENqTYa/T773WMaP40yDvuX9Yl
kO9WCni/qc2GWPcDPhILF+0XmHdhguWNA23Rr4/g5cFvHDSvEYdmEYmJr7jXSA7u
JsH5u2lcc3ou4dHizRlX73PJJH42mhuhydkcmmqUHVZI0RIOboEmjpRi+4zczF0h
qg7ED6/0PAUbc/QrAj89tTUuVqDma05YZUTAK0ZHITGGnuGNbgIzZBVm+/gf1j8Q
KaGyGbq1AWKypDY8BSRvndC1Jpsv/A9i0mbqEtFN/U4+CVMG8j1yDT16M0pq5fB0
iNgJQkCPSxJKLE56BpDoESBAb25AdZ5fEjTPCy7A4lB0aVpTVxXzwkc8rpPPkCXv
6uaOgmucLH9oDpNQizDjP6DCUKEUXx/eXIXySJYYDYeATcZK2txU2VHYSjYi7uSE
HjdsBmRUVhTukqQBOQeIwcRAYL66hjDap/AJXvdcKZ3tLpmXv2uO5/YiRmAQH6hB
RPAvm7maH0hp66+9C/NJ8UAnvuSILPgzzkrbYjFtu55mBFDv4SIM1GflnwR8wGeJ
qiUmgsnZmUuNbbO77vvMR1owYsa2a/ao4bHeNemJG8ptjIrHTlVhG9T/Y6G9SIh3
UMcxDvl6sPbr0DMZFDNxHyyl4bVfgG3/TzQiGtUlQdc0zrtc0uU=
=2E8i
-----END PGP SIGNATURE-----

--rtitbtohtnvbnysq--