Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3081791ybg; Sun, 20 Oct 2019 06:25:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHvrx3bAgXrkMCYNWdSXQ67bIy7aHjFB7v8dDiPg9QZw15EcW8IK8h3nxCopk5Md1ThAvD X-Received: by 2002:aa7:d8d5:: with SMTP id k21mr16916938eds.286.1571577920387; Sun, 20 Oct 2019 06:25:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571577920; cv=none; d=google.com; s=arc-20160816; b=XmEsryf5+qQNU2ej6rTzevRHSdpp24YpbEgdaJAQisLtz7uJYxjIFuNnUAtP4Ql4QV jbqkNIgHf+8uf+2phV4YdChfj5Ah37bcihzdpCWQ4Z12nDoVZ9W4b8zaZI34rIdJukxV q5zeK5Of51aFf8xFoP+iRm5H684wSZkK35GguGtVe2qaQdc2dBvvGZT+SgLv8dLvU2gk diS80KCaCFfpDF/MeFwEAOMlp4Rb2lOL3u1ZEZYF2uO6F3flS+LEBn0rNIxkHRCbZHvn GuqU5im5fyHrzTPVsx7hIPFWaRNJ2L7kI7QnSnKjrKE8kMnROS0v3FaKYg9gLl2GKUry 44CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kgnKDag5Njmv+rGtf5xl7Z2OHj6KY/gFr9KOu6+MjXQ=; b=pOdEB7N4gSDisajccGZBPUINSe3FeD/YF4xY4UZw2Bzepc0eFgRimZl4EPYRbl8ERI oSmfBmS2wWXJSLzSdd8hdgoYhgj2ICBGClkKjM9YeijZyHSRxQlXmt6BWGVzxRM8Lab3 DC6LuCNhAHD0NTqH3y2ikGlRGJU9EsImZDx5ip/UJGUfhC21MoVD2Ugm6ea3duzMUVjD RQrC65E50GXhsCjg02lXsLOhW6VGVeVT/vSf6WPss8Pz0Wn1Lagt+HRANc87dYer5GQa +J36XMSKJS8vRW2K7fPW5kXk5qILfcVBkuvjprURwSRAkI2yGE6vRpYBa7t+Qg+CXpC9 7nOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u5296Dpp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u14si7702551edq.167.2019.10.20.06.24.56; Sun, 20 Oct 2019 06:25:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u5296Dpp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726453AbfJTNYC (ORCPT + 99 others); Sun, 20 Oct 2019 09:24:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:33928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbfJTNYC (ORCPT ); Sun, 20 Oct 2019 09:24:02 -0400 Received: from earth.universe (tmo-104-243.customers.d1-online.com [80.187.104.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6989218BA; Sun, 20 Oct 2019 13:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571577841; bh=JUeyhbY4XLPzl8wkAxz5gj6htNnsDXVN8k8a2GTjy1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u5296DppeCP7gcRjsD5Ko3IbgyouQOgb9XoB8emX153V/EMvyLDkFDoGUYxh7LwB8 xTqZ2yCcAfeo4GfEPMurOZ80hpOZmt7vt7trMvqd0gKqtcBE79LmUEWuvzjzpFh1fw T1Tfo8h9cnf4okIUkT8g8bsIzDeENCn6jxLgH49A= Received: by earth.universe (Postfix, from userid 1000) id ADA5B3C09B1; Sun, 20 Oct 2019 15:23:52 +0200 (CEST) Date: Sun, 20 Oct 2019 15:23:52 +0200 From: Sebastian Reichel To: Linus Walleij Cc: Krzysztof Kozlowski , "Gustavo A. R. Silva" , Linux PM list , "linux-kernel@vger.kernel.org" Subject: Re: [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order Message-ID: <20191020132352.seo2seahsq2k32mb@earth.universe> References: <20191004150738.6542-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bpnqgwqyh5qys2js" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bpnqgwqyh5qys2js Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Oct 16, 2019 at 10:33:12AM +0200, Linus Walleij wrote: > On Fri, Oct 4, 2019 at 5:07 PM Krzysztof Kozlowski wrot= e: >=20 > > It is logical to cleanup in probe's error path in reverse order to > > previous actions. It also makes easier to add additional goto labels > > within this error path. > > > > Signed-off-by: Krzysztof Kozlowski >=20 > For all 3 patches: > Acked-by: Linus Walleij >=20 > The battery charging code is currently disabled on ux500 simply > because no platforms with batteries were available for testing > or supported by any device trees. >=20 > This is getting fix: PostmarketOS is brewing patches for enabling > all Ux500-based Samsung phones, all with batteries. So we will > soon be able to test and turn this on. >=20 > The patches are fine to merge, however notice that we are > refactoring all drivers using ADC through the IIO tree: > https://lore.kernel.org/linux-iio/20191011071805.5554-4-linus.walleij@lin= aro.org/ > https://lore.kernel.org/linux-iio/20191011071805.5554-2-linus.walleij@lin= aro.org/ > https://lore.kernel.org/linux-iio/20191011071805.5554-3-linus.walleij@lin= aro.org/ >=20 > It would be nice if we could avoid colissions. Thanks, I merged your immutable branch for the ADC work and this patchset. -- Sebastian --bpnqgwqyh5qys2js Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl2sX+UACgkQ2O7X88g7 +poy/w/8DMZnLieBPLWUCwhIO5fbuByhIgR2X4Aa8sgjZMXRD5ZyreiZNY5HopAV 5NhV18pa8YcqWLaZO5uar+snOyI959yctBrTSU0ddwt+WAflTxR/sS3d49pNwZDY OPz6j85seXjYVqlwSjv+FlN3oBBOoAt2dC0F688OZKyoRQ2+rGoVMasNcG3hIeLm XtJ1Snmb05Jbky8j2YD9WJ/6txAMdoy1xYRpLQxM2J6W6ekZ+DBfFkQc2MPYnuBm hNKQHvm3wiZ/wXr33UumZc/qJ0ZJx6qzASF9zeiyThn7lGbXMRCyTY1Gow+ECo39 ZxboDpTt7bGbhcDDjl1mAFeDhC7ceZh1iimq6s5n4dgz8Kg3/uPGacMn+ilZnh8a Ab021CnrZzpwDw2+hgfkJfc7GwgkmwfJ5WwvW37iu/0FITDAvIDZMbsAlRLv6c/d amB+4VwuA8GXziINCde7f362Gvd0XDJzqSt7ZD3NMR4YNNeYaGd1NZYxd/ox3k6X KFrF6Wyl8oQlSkGjBAgSCkh9zqjUv6AN8XtLFzd0G+YnyVqC7WzjPxco+ZA95Aft kASFujCAFOBtyU4q1mwIcHhbcZUPHSD9WJ7uzrbH7lx8lrwbs87XV2iIPRCJN66s CoCbsUz4ryxNbUcd9xQaAXp9e4wPVb/6rfhBNr+iYVVCjd4agAk= =rfQl -----END PGP SIGNATURE----- --bpnqgwqyh5qys2js--