Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Joel Savitz <jsavitz@redhat.com>
To:     linux-kernel@vger.kernel.org
Cc:     Joel Savitz <jsavitz@redhat.com>,
        Fabrizio D'Angelo <Fabrizio_Dangelo@student.uml.edu>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-fsdevel@vger.kernel.org, fedora-rpi@googlegroups.com
Subject: [PATCH] fs: proc: Clarify warnings for invalid proc dir names
Date:   Sun, 20 Oct 2019 18:17:42 -0400
Message-Id: <20191020221742.5728-1-jsavitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

When one attempts to create a directory in /proc with an invalid name,
such as one in a subdirectory that doesn't exist, one with a name beyond
256 characters, or a reserved name such as '.' or '..', the kernel
throws a warning message that looks like this:

=09[ 7913.252558] name 'invalid_name'

This warning message is nearly the same for all invalid cases, including
the removal of a nonexistent directory. This patch clarifies the warning
message and differentiates the invalid creation/removal cases so as to
allow the user to more quickly understand their mistake.

Signed-off-by: Fabrizio D'Angelo <Fabrizio_Dangelo@student.uml.edu>
Signed-off-by: Joel Savitz <jsavitz@redhat.com>
---
 fs/proc/generic.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 64e9ee1b129e..df04fd4f02af 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -173,7 +173,7 @@ static int __xlate_proc_name(const char *name, struct p=
roc_dir_entry **ret,
 =09=09len =3D next - cp;
 =09=09de =3D pde_subdir_find(de, cp, len);
 =09=09if (!de) {
-=09=09=09WARN(1, "name '%s'\n", name);
+=09=09=09WARN(1, "invalid proc dir name '%s'\n", name);
 =09=09=09return -ENOENT;
 =09=09}
 =09=09cp +=3D len + 1;
@@ -386,15 +386,15 @@ static struct proc_dir_entry *__proc_create(struct pr=
oc_dir_entry **parent,
 =09qstr.name =3D fn;
 =09qstr.len =3D strlen(fn);
 =09if (qstr.len =3D=3D 0 || qstr.len >=3D 256) {
-=09=09WARN(1, "name len %u\n", qstr.len);
+=09=09WARN(1, "invalid proc dir name len %u\n", qstr.len);
 =09=09return NULL;
 =09}
 =09if (qstr.len =3D=3D 1 && fn[0] =3D=3D '.') {
-=09=09WARN(1, "name '.'\n");
+=09=09WARN(1, "invalid proc dir name '.'\n");
 =09=09return NULL;
 =09}
 =09if (qstr.len =3D=3D 2 && fn[0] =3D=3D '.' && fn[1] =3D=3D '.') {
-=09=09WARN(1, "name '..'\n");
+=09=09WARN(1, "invalid proc dir name '..'\n");
 =09=09return NULL;
 =09}
 =09if (*parent =3D=3D &proc_root && name_to_int(&qstr) !=3D ~0U) {
@@ -402,7 +402,7 @@ static struct proc_dir_entry *__proc_create(struct proc=
_dir_entry **parent,
 =09=09return NULL;
 =09}
 =09if (is_empty_pde(*parent)) {
-=09=09WARN(1, "attempt to add to permanently empty directory");
+=09=09WARN(1, "attempt to add to permanently empty directory in proc");
 =09=09return NULL;
 =09}
=20
@@ -670,7 +670,7 @@ void remove_proc_entry(const char *name, struct proc_di=
r_entry *parent)
 =09=09rb_erase(&de->subdir_node, &parent->subdir);
 =09write_unlock(&proc_subdir_lock);
 =09if (!de) {
-=09=09WARN(1, "name '%s'\n", name);
+=09=09WARN(1, "unable to remove nonexistent proc dir '%s'\n", name);
 =09=09return;
 =09}
=20
--=20
2.23.0