Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3689076ybg; Sun, 20 Oct 2019 19:35:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRNC+poHi4zmWklTgvRRDIl3bP3lL/0cyOAu6o6lNct5I2hPtRRsEjf+sbeKp9YUTOwjI0 X-Received: by 2002:a17:906:c443:: with SMTP id ck3mr20325310ejb.0.1571625339473; Sun, 20 Oct 2019 19:35:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571625339; cv=none; d=google.com; s=arc-20160816; b=seZQ6MTIOGQ4Pn1sE372k+X8hdvuSAOSOECoe+nlYJub4lvtp5aCZUaKEqwRbcX5bY vJCedbcqR9Z64BXm7zRtj68NMW6TJ/L/5sd2i4XXeKA0kpLbreHb7gydMHR+jxQUqz44 7djgERm4wyAApJ7AB1EH7TRmnI/MEj03jq4WautSUn9JkzU6qIgtiUu9HBq89+wxUtcq 3ree1qMPOjw5LWqfsmEf2TuoGFgkfsdKVOqPRkbi5qKfR6jLdbU8b3L9aCkazerUwmQD IpNFcLmWTzmnEmYu2qDFe5dr1GFjto8mXkHF/N8BAVBSUHIwrHG9yA7Kh/6NXwLGZQpu sffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=4dTX5QEeIMl1rHSa77n8K4615s4yY1hd+Bbq0tmT6Iw=; b=a1ywRSRlbaPFUyR7j7msbNU++DVm48aKmweiD9amGNNd+RcSxlz/CUYGxnrMe/WA7c ZsrTeZO01/KvaUdbgC3GnNz3lkON6gWxzKID0LtKCNdStTwkj5kVHrTIQqk4LOaqZg33 XCY5XiHu62PS3O8F3boVTShnulcSIXlDxPk9yzhmW3NP0zSy3Zin17ELdzhfm742uEyN yMK0GS/2PV7ILcxGzYhHBTUR5OJFzHQ9r+KoBFpf/+E8BxnvpKqJNzl8rbQlnGe0E3bA Ft2UdAkcZFH65Z2yOSaXNW5Pu0IKwrIwXdPaXvixrbQVnU5cY4ZiQmBKwsTdMzi2Do1j 9UPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SbVXqm9R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11si1034ejv.310.2019.10.20.19.35.16; Sun, 20 Oct 2019 19:35:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SbVXqm9R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726881AbfJUCfB (ORCPT + 99 others); Sun, 20 Oct 2019 22:35:01 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:37463 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726726AbfJUCfB (ORCPT ); Sun, 20 Oct 2019 22:35:01 -0400 Received: by mail-pg1-f193.google.com with SMTP id p1so6808505pgi.4; Sun, 20 Oct 2019 19:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4dTX5QEeIMl1rHSa77n8K4615s4yY1hd+Bbq0tmT6Iw=; b=SbVXqm9R6gVBxOC4iuCx7FtSH2VL4fGpSlu6lIm9eFNs1Bum6ZDzI6powSwnqd0D6/ NRY86YgDt67SYJqqE334D6Et7203nBFuzWrWgVqlbwOCilnq5/BxR53I1kSyJYCmvRku dg0v/D5LUusYdvR5uZVR2IosWWbIobXrzzuqNP3wyYcUaqKKylgBCKdcORL1YW9jXO8X P8GyJB2z193Fycc7g+UD9QL65+7PGFXNYwmwZQeOrOe4ZR7OAKTG3ji15e/scSUieFsN iovGbhgUJlhPy4QJEv7pBIsix4cq2KnqiKK7wpD8DNr+O9az/EQE/cIPRQDeaG3MZpD+ S7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4dTX5QEeIMl1rHSa77n8K4615s4yY1hd+Bbq0tmT6Iw=; b=Xg3Si0YsaaNXOiNlC+mlszQ6VnHpGw3Yv2zmD2TzsXlznv+txRM8JZVJ2jWVMV12+y 7+xygjw62xNyJPtfO1NquhJo7ZolaQKRr5u14BRBzMOF3xBfCUuEgw+7Y+Sw5m2Gc94i k37mb0Oq9jsFesZiCScq+dP4g9iEAAWilmmCjjj2jDiQBzDMb3PqlwVwZpbo4zjOTMAy l5mksU7CXgqVkwJDtHzUfVMDvsbDCdbJq/PcULrtbT/Gxfr8qhZfBtj11a33MMVSI4SW moyGQJb28n2dVjrL6HHWkPSchxTJcDS0YTCkMZ627ZCriTlgPUse7BNQAU0AraOc0UvD nfjA== X-Gm-Message-State: APjAAAUGjRQG+iYsUCspw7spOfBPS3511XB9roqYmX9USQwSGLmXTq4B Xwp1MLW1baBFpuVmDxM2UiRCDfm3 X-Received: by 2002:a65:6082:: with SMTP id t2mr23332023pgu.363.1571625298770; Sun, 20 Oct 2019 19:34:58 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id t13sm14441333pfh.12.2019.10.20.19.34.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2019 19:34:58 -0700 (PDT) Subject: Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere To: Vivien Didelot , "David S. Miller" Cc: linux-kernel@vger.kernel.org, Andrew Lunn , netdev@vger.kernel.org References: <20191020031941.3805884-1-vivien.didelot@gmail.com> <20191020031941.3805884-2-vivien.didelot@gmail.com> From: Florian Fainelli Message-ID: Date: Sun, 20 Oct 2019 19:34:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191020031941.3805884-2-vivien.didelot@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2019 8:19 PM, Vivien Didelot wrote: > Do not let the drivers access the ds->ports static array directly > while there is a dsa_to_port helper for this purpose. > > At the same time, un-const this helper since the SJA1105 driver > assigns the priv member of the returned dsa_port structure. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian