Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3886278ybg; Sun, 20 Oct 2019 23:54:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHZehCKfcXvFl+MRSqcBEga/Kdq9dMW8EHHhnif6YjNNEAuj8+w2euT5XvbP/iyX5mw3yz X-Received: by 2002:a17:906:1fc8:: with SMTP id e8mr20538688ejt.86.1571640842424; Sun, 20 Oct 2019 23:54:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571640842; cv=none; d=google.com; s=arc-20160816; b=vd8QUsSVkxjObcWkG9dkIGeKKnRPmmVGQmJMjQhkjjkzQgN+8VK88IryvYWd9TlUGv HPuPLg5zMY+zs9JZOzAsILXy2zMkEuLfRvDMI9/uTZKws1LnkPVk97dOXnryojfyxbF3 gvlDSPkZCo23cZ8AFiGJ103Fni6BIuhzUEbZNrnliBeyY42FNYEKM6eoipwRubk+NFJr CeFfUd0QiDCkXQn57JuNSAPoXgfz3FvDQXwNp411ZJAsoqi9+QNkF+fbmuSwhup1Pu6t ztzFZYHWl4lekyR0yFM8+S+qU5DEAcgDfsAG+4JfdQ9/d35h8/5EgNKzeGpTEDtgNYjX SegA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=LuobqEl83tBhFSc2uoL10qi/akD8+eO/KFp/lKzryZk=; b=qQjfSMep8E0QHMrAdfkmEJUMmni5rTZ9vu8uvWNjGqvoK5hVbF2vOfbCyTfhZqihnT EzlsgI/HZPa+bV4hNUeG4KsSQoQwSmsJezDQBdk61IAZCvo0z72LyOTiHzhFJtyzAWzl 4rPFK7XwfqU8i8IJi3E3im1C9jgCFVCkvHJTutaRjyAKjyjjot4/LzK3T1K6rxxwDjfw k+ur5Zf/FzvSDL0DW0iOjWFyFPRpVUaevNthdISUa4T09ZYk0Nolcn+OVu41RdUTGp92 vkhXSdXLS99PvyfFNRyfEH9HFFVWRLLYrJx40qOxV0pgGu7Xu4rEuBCl12wafdJGnMqh NK9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s46si1263226edd.336.2019.10.20.23.53.39; Sun, 20 Oct 2019 23:54:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727144AbfJUGw6 (ORCPT + 99 others); Mon, 21 Oct 2019 02:52:58 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33638 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfJUGw6 (ORCPT ); Mon, 21 Oct 2019 02:52:58 -0400 X-IronPort-AV: E=Sophos;i="5.67,322,1566856800"; d="scan'208";a="407139933" Received: from ip-121.net-89-2-166.rev.numericable.fr (HELO hadrien) ([89.2.166.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 08:52:55 +0200 Date: Mon, 21 Oct 2019 08:52:55 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Dan Carpenter , Jules Irenge , devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary In-Reply-To: <6e6bc92cac0858fe5bd37b28f688d3da043f4bef.camel@perches.com> Message-ID: References: <20191019140719.2542-1-jbi.octave@gmail.com> <20191019140719.2542-2-jbi.octave@gmail.com> <20191019142443.GH24678@kadam> <20191019180514.GI24678@kadam> <336960fdf88dbed69dd3ed2689a5fb1d2892ace8.camel@perches.com> <20191020191759.GJ24678@kadam> <6e6bc92cac0858fe5bd37b28f688d3da043f4bef.camel@perches.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > btw2: > > I really dislike all the code inconsistencies and > unnecessary code duplication with miscellaneous changes > in the rtl staging drivers.... > > Horrid stuff. I'm not sure what you mean by "miscellaneous changes". Do you mean that all issues should be fixed for one file before moving on to another one? Or that there are code clones, and all of the clones should be updated at the same time? julia