Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peng Fan <peng.fan@nxp.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Andy Duan <fugang.duan@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com>
Subject: RE: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
Thread-Topic: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1
Thread-Index: AQHVh/DvpHNuw1YCQUS80eeiIyy4HKdk2FcAgAAAb0A=
Date:   Mon, 21 Oct 2019 09:46:10 +0000
Message-ID: <AM0PR04MB448170DA0486707775C3DABA88690@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <1571649512-24041-1-git-send-email-peng.fan@nxp.com>
 <20191021094420.wmy5w2tp532dibqm@pengutronix.de>
In-Reply-To: <20191021094420.wmy5w2tp532dibqm@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 08ad44a4-615c-42ad-53f9-08d7560b8156
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 09:46:10.9702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XMdnxD4KWgsBByXxc38AQLGbCAO4HoWwN2OCgp6RPUF638rETexCTUQCcHoI4PsRl26HOPEryCKp9/6/rBpmew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4612
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
>=20
> Hi,
>=20
> On 19-10-21 09:21, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on U-Boot to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> >  	pinctrl-0 =3D <&pinctrl_fec1>;
> >  	phy-mode =3D "rgmii-id";
> >  	phy-handle =3D <&ethphy0>;
> > +	phy-reset-gpios =3D <&gpio4 22 GPIO_ACTIVE_LOW>;
>=20
> Where is the pinctrl done?

https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freesc=
ale/imx8mm-evk.dts#L328

Regards,
Peng.

>=20
> Regards,
>   Marco
>=20
> >  	fsl,magic-packet;
> >  	status =3D "okay";
> >
> > --
> > 2.16.4
> >
> >
> >
>=20
> --
> Pengutronix e.K.                           |
> |
> Industrial Linux Solutions                 |
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.p
> engutronix.de%2F&amp;data=3D02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6
> 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C637072478688921047&amp;sdata=3DxZI60uyyQ%2BkX%2Fpf07n
> CgVhGt1ApYBKSnndGB3Dk2578%3D&amp;reserved=3D0  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |