Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4038423ybg; Mon, 21 Oct 2019 02:47:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHXyrP8+c3xAjEq2cAOz5OpfWQ5AnX5rx9bnZrRWnnXmwmK+B80mtbcPh71xVpXFGDzbP7 X-Received: by 2002:aa7:db59:: with SMTP id n25mr24412318edt.288.1571651239723; Mon, 21 Oct 2019 02:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571651239; cv=none; d=google.com; s=arc-20160816; b=twhkljIsuwiAcseDPNnJKzL8IqXRggFStl+5tpUcFvnLJCze0nEqm1fEgkS0TDEY2O XaMCkC72T8yZu2cckuqF/YV0xwuNSZq0BEvd65TO1oOaBCUiDnXS945aT5ytVD+JXg3r fBbXPBwqrQxk/c0Xue0HxIH1fk9WF4XoV4yVRUtW+HjherE4LkMc7jM/yQ7r06ubYp7u a/kJJSQDRX33qv1OuslQHktYTrX/8COCdds44RGGgLK/XN+69mIZjYeVFC3LSKeXi8vR 0S2sZvnAnaxQXh4jZXuZlSeL4nqK0tk1BYqJ4DQDWPZB6j79oDG2b9EgQIkWrIIlcmFF SIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=KCSqhUIkgNVUNc/2AtiBJlX/RTnIOJcDBK6aNUsAjU8=; b=BLPL3Vyc5UZeyD4X94lFgsiPnLSJplOh5M+v3NI84wNti76fqjCJvJe4NP8LDRcyAA HBxkErXGlv09FSQlzmGA7m74LU3NUw6g8b1pNOEW4ZhWgRw/xQpGzcS0+Ays6pIF24yX f1MjO2QZMUfthcSWSoSwoe1ObXaX/MkO6hQ6JUn9YNtGUasXKJwNvgXmcrseXK9vYGWu 7GtYAiwu4Gq1G2tM9BWMG2xCrZERqYKbIobnV14UGl1R+zqLSwVd8k8BUVWh3Ex1B165 8fEGJQbAl7zulPWNIyHXHaxfj4ByK60GadAF+MJ+eyt23eKPCvVBAmZmlr8kmF6nvSvh zjtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id op4si8306719ejb.77.2019.10.21.02.46.56; Mon, 21 Oct 2019 02:47:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfJUJo2 (ORCPT + 99 others); Mon, 21 Oct 2019 05:44:28 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:39253 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbfJUJo1 (ORCPT ); Mon, 21 Oct 2019 05:44:27 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iMUEg-00031V-3v; Mon, 21 Oct 2019 11:44:22 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iMUEe-0003mQ-5G; Mon, 21 Oct 2019 11:44:20 +0200 Date: Mon, 21 Oct 2019 11:44:20 +0200 From: Marco Felsch To: Peng Fan Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "devicetree@vger.kernel.org" , Andy Duan , Jacky Bai , Anson Huang , "linux-kernel@vger.kernel.org" , dl-linux-imx , Leonard Crestez , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Jun Li Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Message-ID: <20191021094420.wmy5w2tp532dibqm@pengutronix.de> References: <1571649512-24041-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571649512-24041-1-git-send-email-peng.fan@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:43:52 up 156 days, 16:02, 98 users, load average: 0.12, 0.13, 0.10 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19-10-21 09:21, Peng Fan wrote: > From: Peng Fan > > We should not rely on U-Boot to configure the phy reset. > So introduce phy-reset-gpios property to let Linux handle phy reset > itself. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > index faefb7182af1..e4d66f7db09d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > @@ -80,6 +80,7 @@ > pinctrl-0 = <&pinctrl_fec1>; > phy-mode = "rgmii-id"; > phy-handle = <ðphy0>; > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; Where is the pinctrl done? Regards, Marco > fsl,magic-packet; > status = "okay"; > > -- > 2.16.4 > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |