Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4086126ybg; Mon, 21 Oct 2019 03:36:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfODvSyfOtmGDLDDRmSwNcHPvQ4QX65GGeY3lkp/cIcix3bejWPJwzWlHpWsj3ubXcJFko X-Received: by 2002:a17:906:b24c:: with SMTP id ce12mr21269223ejb.327.1571654196799; Mon, 21 Oct 2019 03:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571654196; cv=none; d=google.com; s=arc-20160816; b=AzVqfjv8dQuoys3lmJENtYIP77HG8KcWfnnZ/rIdS4pjEr4LFLuPDF0ypoW//yQq1i 4+QgUHTZHVrx9Y3JZ4PC8czVp3CxUVBvS7AFnc5xe3CQfPFWTzouJDc1T/aYR7f3Fohc eQuLuwAiXQVVomRA3x3K9gjZ6hcZqqBehCjyH2So4b7rYiY96Q8kfYQdog16+jD3XLeu Z4vwI5PMdqP5qIHt9t1ku+JZ28iYOA7ppysi7HG4D42JYqGRKz0BuDRJq6Bty0WdcrUs SawUgtw3NSy+UQdRjXqheDsQSZKxV7UXd8/z/gn+uUJ0LOQx/GdOHNmnQqqofba5qyFR rlCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ByQuSAprS9jXkayR9k8WNXgC0XRVOmuonTQ+tfTnFgQ=; b=femLfKP4YvlmV3rTbwq/fg1rlhV348z3D5D5MnMLjxEpRUumh0EhEd3/YiKN6UKNQe EqPL0NRprEGYm4dtYk+iEO3JBq/5Lj15d+2C1S+AXC3PdmUvK31u8/jdJBmH3fQnWArw RQgLsXTmqqgm6SZ+bgfHaS9ATL497eOsN1GNVnzcbIPPRi7XzQxWPamTMJxLZx6lHm94 EcIr5n9lhtrqZyEcrVKCaE6296gq2jVyjxJ4Zhjv50VqwxCBUPhFjQO40fmcu9+JgDA2 sCyUpA7V3DjJs4pcMoXEPOXzrumQumOZyTBNmJDmZ8je0TGY8nlhh2K/OmXTdr690ju9 4cxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F20sjx0y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jp22si2236342ejb.138.2019.10.21.03.36.13; Mon, 21 Oct 2019 03:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F20sjx0y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbfJUKfv (ORCPT + 99 others); Mon, 21 Oct 2019 06:35:51 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42008 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728212AbfJUKfu (ORCPT ); Mon, 21 Oct 2019 06:35:50 -0400 Received: by mail-pg1-f194.google.com with SMTP id f14so7538140pgi.9 for ; Mon, 21 Oct 2019 03:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ByQuSAprS9jXkayR9k8WNXgC0XRVOmuonTQ+tfTnFgQ=; b=F20sjx0yS3J6Y1j5JsXZ2Gpm20YNzlBp1Q9Sh/pFUqGmdiaOG2MjLbZMFn+mL+S7py 7Djb+E855QkNZOggjigBXw87iY0cOhXI27sUJwGAlVjCuJi1TaE+qHGoc98Ek08e3cpu 4vMffBQ+hcVwtddGYa1fPuYCu5mq2MYAL0l/iCEvWK+KdjIORO4pLVmaUmJjBpl8cJp3 VaDydgsopnGKZJzZ82yjCH4xJNyw//AaQLkLHFubBpHqrwF0IouKcslwojVBzUtI2uaQ 6r2SqNedzxv7HvJVJ0W+2OjkO81BdXDQfyVuPQoYVOccXuAZLQUY1J6qJhPiQWHpzpj0 +dmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ByQuSAprS9jXkayR9k8WNXgC0XRVOmuonTQ+tfTnFgQ=; b=gbY3gRrcF4/RE4r8veXXVvWPNK2suPArMuJnz6AxbocADCoBrGWgS8LNc4BNEGpqLk cVnc60yZuY4QazyZQ6RG+calBKgGM7Wa68hfLgLhA2hCproBMmF0zr0JNJNHXxCxjZOM I7nlYXKWX3FX+N4XPBg4SHw4pQzCgYcLWiXDxFUr5mbzfLHtbaC3lSebXG5oqOtMCE89 Qe7cfRSupiZg7Jaj9VhieIh2l/3rH4q+bXsyL07sByuuiVSXUl2yji/iFmbV4HQIBp2J QDzVL28vwiGwpaYIr+6Cnaraz6LFnwDznE/Jk8r0Q1eYq9E6Bcf4jokzYdQmgOEOYNpW DZ4w== X-Gm-Message-State: APjAAAU7cQnPu84OOIFXZ1YvoBVh6iOOsBvvNpZV3VAhBY9QfPPAEQVs RwzVAcfDk2GGtW8U4+Ew+ktMK9JxZ/TXcA== X-Received: by 2002:a17:90a:b304:: with SMTP id d4mr28610421pjr.27.1571654149379; Mon, 21 Oct 2019 03:35:49 -0700 (PDT) Received: from localhost ([49.248.62.222]) by smtp.gmail.com with ESMTPSA id k6sm20516678pfg.162.2019.10.21.03.35.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 03:35:48 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, julia.lawall@lip6.fr, Amit Kucheria , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v6 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Date: Mon, 21 Oct 2019 16:05:21 +0530 Message-Id: <184422dcc1c12553e71a58c62e01425fd7d1172a.1571652874.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 6ed687a6e53cd..542a7f8c3d962 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -149,6 +149,8 @@ static int tsens_probe(struct platform_device *pdev) priv->feat = data->feat; priv->fields = data->fields; + platform_set_drvdata(pdev, priv); + if (!priv->ops || !priv->ops->init || !priv->ops->get_temp) return -EINVAL; @@ -167,11 +169,7 @@ static int tsens_probe(struct platform_device *pdev) } } - ret = tsens_register(priv); - - platform_set_drvdata(pdev, priv); - - return ret; + return tsens_register(priv); } static int tsens_remove(struct platform_device *pdev) -- 2.17.1