Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/4] perf/core,x86: introduce sync_task_ctx() method at
 struct pmu
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>,
        Song Liu <songliubraving@fb.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <0b20a07f-d074-d3da-7551-c9a4a94fe8e3@linux.intel.com>
 <c75134ef-b71b-c080-8ee1-c09fb9fae764@linux.intel.com>
 <20191021102706.GE1800@hirez.programming.kicks-ass.net>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <975abbb4-7b3d-32a6-e21d-a9c161aabc01@linux.intel.com>
Date:   Mon, 21 Oct 2019 14:24:59 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191021102706.GE1800@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 21.10.2019 13:27, Peter Zijlstra wrote:
> On Fri, Oct 18, 2019 at 12:42:44PM +0300, Alexey Budankov wrote:
>> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
>> index 61448c19a132..60bf17af69f0 100644
>> --- a/include/linux/perf_event.h
>> +++ b/include/linux/perf_event.h
>> @@ -409,6 +409,13 @@ struct pmu {
>>  	 */
>>  	size_t				task_ctx_size;
>>  
>> +	/*
>> +	 * PMU specific parts of task perf event context (i.e. ctx->task_ctx_data)
>> +	 * can be synchronized using this function. See Intel LBR callstack support
>> +	 * implementation and Perf core context switch handling callbacks for usage
>> +	 * examples.
> 
> You're forgetting to mark this: Optional

Fixed in v4.

> 
>> +	 */
> 
>> +	void (*sync_task_ctx)		(void *one, void *another);
> 
> The traditional argment names for context switching functions are prev
> and next.

Fixed in v4.

Thanks,
Alexey