Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191021105822.20271-1-lee.jones@linaro.org>
In-Reply-To: <20191021105822.20271-1-lee.jones@linaro.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 21 Oct 2019 13:29:20 +0200
Message-ID: <CAK8P3a10w9Xg6U8EgUqPLbucP3A0wc9xO_WNG06LxHrsZkZc1g@mail.gmail.com>
Subject: Re: [PATCH v2 0/9] Simplify MFD Core
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Daniel Thompson <daniel.thompson@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Barry Song <baohua@kernel.org>, stephan@gerhold.net,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Daniel Drake <drake@endlessm.com>,
        Lubomir Rintel <lkundrak@v3.sk>,
        James Cameron <quozl@laptop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 21, 2019 at 12:58 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> MFD currently has one over-complicated user.  CS5535 uses a mixture of
> cell cloning, reference counting and subsystem-level call-backs to
> achieve its goal of requesting an IO memory region only once across 3
> consumers.  The same can be achieved by handling the region centrally
> during the parent device's .probe() sequence.  Releasing can be handed
> in a similar way during .remove().
>
> While we're here, take the opportunity to provide some clean-ups and
> error checking to issues noticed along the way.
>
> This also paves the way for clean cell disabling via Device Tree being
> discussed at [0]
>
> [0] https://lkml.org/lkml/2019/10/18/612.

As the CS5535 is primarily used on the OLPC XO1, it would be
good to have someone test the series on such a machine.

I've added a few people to Cc that may be able to help test it, or
know someone who can.

For the actual patches, see
https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t

    Arnd

> Lee Jones (9):
>   mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message
>   mfd: cs5535-mfd: Remove mfd_cell->id hack
>   mfd: cs5535-mfd: Request shared IO regions centrally
>   mfd: cs5535-mfd: Register clients using their own dedicated MFD cell
>     entries
>   mfd: mfd-core: Remove mfd_clone_cell()
>   x86: olpc: Remove invocation of MFD's .enable()/.disable() call-backs
>   mfd: mfd-core: Protect against NULL call-back function pointer
>   mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs
>   mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device()
>
>  arch/x86/platform/olpc/olpc-xo1-pm.c |   6 --
>  drivers/mfd/cs5535-mfd.c             | 124 +++++++++++++--------------
>  drivers/mfd/mfd-core.c               | 113 ++++--------------------
>  include/linux/mfd/core.h             |  20 -----
>  4 files changed, 79 insertions(+), 184 deletions(-)
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel