Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4150816ybg; Mon, 21 Oct 2019 04:41:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTVwICDSd9HGrbuyqdpgPsYN6Gw5O1wHfNntibV4FMgMJb7N1zffXfEkrj6a0zYfdXW9s/ X-Received: by 2002:a05:6402:1a33:: with SMTP id be19mr24305835edb.197.1571658078243; Mon, 21 Oct 2019 04:41:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571658078; cv=none; d=google.com; s=arc-20160816; b=BpTtPfR4oSMfS/NHlhLsGPgID99yA6FZufD71r/AXSInyj0nIa1ya+w1iIiii+gy/e zybWlbjoSCc34Oeb1QU6tVcuS4eqZS+sWL5JfWdoqGl3EvuKApv2/Wb8C3GIqP/TPdVB QqTtpbmxuH+2T/L+oSkIDtobvpfiyOhFY8GCmnlmk7gEEovrh205AB5l1Yh2Dtjup7H8 w/3ohoNAaAt8BUcy7D16bB+zBbomQERFOCe3VzSKsJclPcfJxtjrCE259EeDjVzKw6p4 ym0maUaBMmcqEQ2t7s0dFD3wmcsHNMmhmiPRbtX4F9+ZsztOCxDwnYpFuHngkohLVwf2 rqrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=SN+4LGusIWwb/H7uVEhoQcfn1VcDl1S3a1V5QFIxxYaEfXLYobDoJroPZ4skbBehYm 7i7UNyAiy4Ebk+lEZR2jkIe/apsFBNJDDTa9xKEMkkix3QgcubyenTdQHndlP5sonyKG ppmGBxG7Xv9eSqaaXNoJcFhzl8VjCN6lqj2O7diVyS6jr9jI/07tiNKuTgX8uhKsti9c V796Tt2FMxi2XNWxNXranXUDVlydloXgqQpXBHI92i/489UM6OGVoswWNc1RC1KS+z6M bmmrDMpG9Jf/KIg3lE4aBoMV5OayDBYt3bku2e5XqPUHainsIul5DdP2MJlHiaqx+f36 jzSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xIoHYOEM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18si1958906ejo.78.2019.10.21.04.40.54; Mon, 21 Oct 2019 04:41:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xIoHYOEM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728500AbfJULkD (ORCPT + 99 others); Mon, 21 Oct 2019 07:40:03 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43910 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfJULkD (ORCPT ); Mon, 21 Oct 2019 07:40:03 -0400 Received: by mail-wr1-f66.google.com with SMTP id c2so8331976wrr.10 for ; Mon, 21 Oct 2019 04:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=xIoHYOEMyhGDXoCpQ9jHFyb0ii1+Dwvu1Q9SEfKtsUww4GbJQQy6Z+jQ8cl+fpelw3 ThXt8MFnHE4WeoE8+UnlJTQA1ZYeRuSyGiCfFTKaC0OBBqbot6eli99dXr5TzBuwDLdg hv/656/7etodYAz4ZGpUNsv4u+8lHsnz3JDcP+0QvO0l0qDRgeRmohlWKezDuIXl11Ai bYLHo0gILQbudud59jMRUdxxPNbWw0pXm0FHqeuVlxs2z/vrj8cchV+e99cxB6Xbntp6 Qh4S59PcwuPmISifpJ/a8LUwevqg/nE1p3vXY/gT+dfP349mVoc7XFJ3DhM7T9EHY4cW un/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=qMsTJKiptUC+pupp8Z9IumIxIao0f/DtOpQ2eQ2y0WN10ohWqhk7p58lKysVlh39HX Ow5jGiz+sQyGsj7JTax4RLhurDJE8OyjThCQQcagIwQ5BUv+rpR6ncY2b7b5xAarA34Y OKLbe0lQJy8XdZYZQCGcA+J2TEI9OHclP5x2rIFUAfdYTBVWTskI2xyvAbfKwo5YBvhE SnuSCjlJ0WxX5qUz5yKYz8nVsazWj689YIENIrWM0/1dlCWXqCOyPg9WgkMhhPdCKUZ1 GaJaTToCoJtaqd5uRk4z6RSJQKVYLkSx/tuP7uDF1E57eLBJoR+zXQFkvdo/pymWWsk7 2y3Q== X-Gm-Message-State: APjAAAXV9pvUM3WJiNlH2GGb+DoM1tLxeLa5Xfp2yURGlfj4eF0Og3s1 5wLV6fywF/h1tgFuLYRB+WVp3g== X-Received: by 2002:a5d:5222:: with SMTP id i2mr14222242wra.271.1571657999840; Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id p20sm9851205wmc.23.2019.10.21.04.39.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Date: Mon, 21 Oct 2019 12:39:57 +0100 From: Lee Jones To: Arnd Bergmann Cc: Daniel Thompson , Mark Brown , Linus Walleij , Barry Song , stephan@gerhold.net, "linux-kernel@vger.kernel.org" , Linux ARM , Daniel Drake , Lubomir Rintel , James Cameron Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191021113957.GC4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Arnd Bergmann wrote: > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > cell cloning, reference counting and subsystem-level call-backs to > > achieve its goal of requesting an IO memory region only once across 3 > > consumers. The same can be achieved by handling the region centrally > > during the parent device's .probe() sequence. Releasing can be handed > > in a similar way during .remove(). > > > > While we're here, take the opportunity to provide some clean-ups and > > error checking to issues noticed along the way. > > > > This also paves the way for clean cell disabling via Device Tree being > > discussed at [0] > > > > [0] https://lkml.org/lkml/2019/10/18/612. > > As the CS5535 is primarily used on the OLPC XO1, it would be > good to have someone test the series on such a machine. > > I've added a few people to Cc that may be able to help test it, or > know someone who can. Wonderful. Thank you. > For the actual patches, see > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t > > Arnd -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog