Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   Mihail Atanassov <Mihail.Atanassov@arm.com>
To:     "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: Re: drm/komeda: Don't flush inactive pipes
Thread-Topic: drm/komeda: Don't flush inactive pipes
Thread-Index: AQHVg/q5HtMJ9aPBjkqhwpfRyiPcGKdlKMGA
Date:   Mon, 21 Oct 2019 14:03:48 +0000
Message-ID: <4038026.EQVCqvRzMf@e123338-lin>
References: <20191010102950.56253-1-mihail.atanassov@arm.com>
 <20191016082117.GA18601@jamwan02-TSP300>
In-Reply-To: <20191016082117.GA18601@jamwan02-TSP300>
Accept-Language: en-GB, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: fdb7ca8e-cea2-43cc-2530-08d7562f83ef
X-MS-Office365-Filtering-HT: Tenant
X-MS-TrafficTypeDiagnostic: VI1PR08MB3262:|VI1PR08MB3262:|VI1PR08MB5422:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <VI1PR08MB542257628CB3CB22C2C9C6238F690@VI1PR08MB5422.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:170;OLM:170;
x-forefront-prvs: 0197AFBD92
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(366004)(39860400002)(346002)(376002)(136003)(396003)(51914003)(199004)(189003)(14454004)(54906003)(9686003)(6512007)(6436002)(5660300002)(81156014)(33716001)(6246003)(305945005)(66066001)(7736002)(14444005)(256004)(6862004)(81166006)(8936002)(8676002)(2906002)(186003)(26005)(478600001)(71190400001)(71200400001)(446003)(11346002)(476003)(86362001)(316002)(6636002)(52116002)(6486002)(486006)(6506007)(99286004)(229853002)(76176011)(102836004)(386003)(3846002)(6116002)(66946007)(4326008)(66556008)(64756008)(25786009)(66476007)(66446008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB3262;H:VI1PR08MB4078.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: +MUz9LpuNA4fqRvIdNIYYqcAU/ADcCmqYQvfxg06UCCdBpGyL1/Fiu3Kvw9wVCbKOICnJhw4z5M7y7hQLJtVWxVGAJXD01EqV5P5L5PqKPV58cykoqxudW/X17HYy+1BEmSsRPuOIFAjw+KdqYZmmM9k5OoUpEj3OmJBHAf6C7lQlPDAmXRGFjZt/fx8IsZ6jPfU/SmGvmZnc8vZ7QuMGQWwKgmddTMhl3aOyIpUXChHRRD05gK+2kfx+N7vrb2E7rkzoUbXaNhKHUrvNLuP4uf2MgR7gpTfANmKXWU/nMGN7F0wF4KkHfCzdXQ/tsBeoNA1LSpZRE7rg5GDp8ip80x4pZyNukiE69GDVBZnmsaGy7JnwaTurRwun8cbV6tiqSuEHSxr+JW8Cya2eBxwrOpogO7QX1Ng2funxzwF4Dg=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0533DF58170BF348BE6D64481660898F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3262
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(376002)(39860400002)(346002)(396003)(136003)(189003)(199004)(51914003)(14454004)(46406003)(76176011)(26826003)(102836004)(478600001)(14444005)(6506007)(386003)(66066001)(25786009)(6512007)(9686003)(5660300002)(6486002)(99286004)(70586007)(70206006)(47776003)(36906005)(356004)(81156014)(81166006)(8676002)(316002)(50466002)(54906003)(7736002)(229853002)(305945005)(8936002)(8746002)(22756006)(3846002)(6116002)(446003)(23726003)(186003)(63350400001)(76130400001)(6636002)(6246003)(486006)(2906002)(97756001)(126002)(86362001)(33716001)(4326008)(26005)(6862004)(336012)(476003)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB5422;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d2f8b61-df74-4eb9-e65e-08d7562f7e4e
NoDisclaimer: True
X-Forefront-PRVS: 0197AFBD92
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kJIraMe9MSOd2cKDuumnbU8WuTisWYa5tMUBWgB8CAl+y1n3q+dnltICmEAvKGA6yfuBpuZpVPoz0/0RE4zOm9lF48p3/895s3Jh5b48m733UoeS7kQ2Bm0XDG1gw1rS48nekM2aInexogyaHRvOqMmj21Ke5DQbbVRDoxVp/4NDOZAPWM+eq83X0NtJ9Z0Lri0ZUFM5kDEgMh+1Dvju5hybAAzY4JL5qFjy0dt9X50gdPAWz+weiaePjhVeodap9gbQ2smdVazCfJ95Rv/1wzUiw3nrxmSUKqZHY03EAf+1sRziSxnolTDU1AHqxA5EcSFmW3drNaUL34KZ7ZvNwJcGuSQ+qafngGa2VhJonOHPVou9CXwiqNv2JwYMyaSMg6D0cQvrBcU13p74Syag35WGBWDrk9ES0N3bZtqqh88=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 14:03:57.2583
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fdb7ca8e-cea2-43cc-2530-08d7562f83ef
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5422
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, 16 October 2019 09:21:24 BST james qian wang (Arm Technology =
China) wrote:
> On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote:
> > HW doesn't allow flushing inactive pipes and raises an MERR interrupt
> > if you try to do so. Stop triggering the MERR interrupt in the
> > middle of a commit by calling drm_atomic_helper_commit_planes
> > with the ACTIVE_ONLY flag.
> >=20
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_kms.c
> > index 8820ce15ce37..ae274902ff92 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > @@ -82,7 +82,8 @@ static void komeda_kms_commit_tail(struct drm_atomic_=
state *old_state)
> > =20
> >  	drm_atomic_helper_commit_modeset_disables(dev, old_state);
> > =20
> > -	drm_atomic_helper_commit_planes(dev, old_state, 0);
> > +	drm_atomic_helper_commit_planes(dev, old_state,
> > +					DRM_PLANE_COMMIT_ACTIVE_ONLY);
> >
>=20
> Looks good to me.
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.=
com>

Thanks for the review, applied to drm-misc-fixes -
b88639b8e3808c948169af390bd7e84e909bde8d.

>=20
> >  	drm_atomic_helper_commit_modeset_enables(dev, old_state);
> > =20
>=20


--=20
Mihail