Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 21 Oct 2019 17:06:20 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     lee.jones@linaro.org, a.zummo@towertech.it,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        phh@phh.me, b.galvani@gmail.com, stefan@agner.ch,
        letux-kernel@openphoenux.org
Subject: Re: [PATCH 2/5] mfd: rn5t618: add irq support
Message-ID: <20191021170620.7a2b594b@kemnade.info>
In-Reply-To: <20191021090710.GT3125@piout.net>
References: <20191021054104.26155-1-andreas@kemnade.info>
        <20191021054104.26155-3-andreas@kemnade.info>
        <20191021090710.GT3125@piout.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/YRaonVMN0kbDymw3IkU_qG+"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/YRaonVMN0kbDymw3IkU_qG+
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 21 Oct 2019 11:07:10 +0200
Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:

> Hi,
>=20
> On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote:
> > +#if 0
> > +/*
> > + * REVISIT when implementing charger:
> > + * according to some other implementation it needs special treatment,
> > + * inverted but experiments seem not to confirm that.
> > + */
> > +	[RN5T618_IRQ_CHG] =3D {
> > +		.reg_offset =3D 0,
> > +		.mask =3D (1 << 6),
> > +	}
> > +#endif =20
>=20
> Please avoid submitting dead code.
>=20
ok, I can do some more testing here and add that thing properly.

Regards,
Andreas

--Sig_/YRaonVMN0kbDymw3IkU_qG+
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl2tyW0ACgkQl4jFM1s/
ye+l5Q/+PTqeFB0Jvhwc/dTNl37P1/O1cmppFbxi4jphvnDG8WTAuhg5zdhflsVA
JDERfMla2M3HyJmjbT3boDRoXo0aoSSOnwnlkNAg8PDCzpb8CdRXGBwuv7s6FCp0
uQn4hOulgCZXPxNmkp0A6e9/q+HIiR2YcfP9tVAzcaschIfS/tuZb3XGXcE4wz3k
KPdMMPEtr2rBnub9o5wrE0TUU0yxsyK5qoAqQowlyL/e1HeafLPHSih7AEhNDMNM
NO1aChc+Vql5rWJtO/seTSq/NP6BvYGcX3TrnucTIC9YaksPTDe+DhsOnV1mYCW6
YBRsatl7o026kly9+9v/cT5pg03UCb5gaU2Nc9GG7qBxJxhSnxIPbZ9r/4UOF6WD
e3AiNP7WiqiQ6Ahlsd9rBCH3LErgjPR4ecco7H+u/ric3ypozWH+zjrrnWW+VYVo
L6PTT8zxOQw9p2pBDGBu4Z5GBCSI/esmdwHW2HzjKxPgJlc5cvwx/2hgs+XbpnhR
SfVBiQGGYXyFmwy0zeycKlM/ZdiDPcGP2ljb4nQISd4FdNonCmVfOOmRmW2880UY
kw8BB2MzzVEF5VJ2Z0XnBS2kEAlSg6nzBPpnvVcm1Iq/MVIZX/UVDJUZiun0MJBI
kghNQrHB0wgSHJplxqXsa0EX5/k+rtOgNoAET8iC07XhZ1bzK20=
=QgyE
-----END PGP SIGNATURE-----

--Sig_/YRaonVMN0kbDymw3IkU_qG+--