Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4446790ybg; Mon, 21 Oct 2019 09:08:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ7UIKXr2yBfLYe9J230yujNPmlgjsRfhfSXWr2xqlcHBriRc2TOHwnUagdr7ruRSBwAoO X-Received: by 2002:a17:906:b74f:: with SMTP id fx15mr22627505ejb.69.1571674101710; Mon, 21 Oct 2019 09:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571674101; cv=none; d=google.com; s=arc-20160816; b=Iyop4sEqm092KYBOoT0M+mMAgnZymEAqi0OlXXkdRvILuP3uDyG9Xl0+MZMaDfMWYv q0B8NnhJdvXEdcFBkcZYsi8dlRa30qzGV5TErSF/t1Y4+hGus62VgMteDndkgzakuUNG apqt8PJTpdZkom/lhtp5Pwy7u69vmAKFwJnJBXJ5EQBcn+JEg87jsFDXeA6L34C/s9zs p1OYqixXn3fjGLpxuH0HzxB+em1t/UzyhTZ0q6xUcy7jhKHLQSpVgq5iU9S1OzF1Lb9j hKF1EiSI5cgIBox7QmXmqBveQAXFcb3gem18Tl1NfqYgTNDJtcW+re/UdUYGap5hU/d6 yCXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JE8U2Fghv6YjjweCRTqDn5FZUlMFhhM8tZP7QTcsL4M=; b=qGVIAhqUJhSTBZPIawF/lkb59dWqfBYH6b5Gz3y92dFNwwcpJRKqSdTKJpzjb6Jcir T3tRPHaZ/03XoEcrMkxTAcqYsRUC3ft3WI9H13Tq8ibnVXW7SpE7ml+Mbpsoh78jm0lN qLmKW/E+AFpWQzveZRrg35oi9Ixf0R9O5Tde4IKIto4OW30uvdANJmKon/XBDTSnpMi4 SRYLAN4zsB8oNpvnPoMBLnvwOSohnGDTuyIb98izcE401ljDGgM7TnuyYC4JgrTXwrMG RbYQ7WiXIkKQlaaz7siLZbMudQYYdA9GF0ZnXNz2UnboxvVC0Lhpu3mJEUXrCgd4XS55 w8yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BXwbjyQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16si9246286ejj.360.2019.10.21.09.07.51; Mon, 21 Oct 2019 09:08:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BXwbjyQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729779AbfJUQHC (ORCPT + 99 others); Mon, 21 Oct 2019 12:07:02 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:40633 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbfJUQHC (ORCPT ); Mon, 21 Oct 2019 12:07:02 -0400 Received: by mail-pg1-f193.google.com with SMTP id 15so2735020pgt.7 for ; Mon, 21 Oct 2019 09:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JE8U2Fghv6YjjweCRTqDn5FZUlMFhhM8tZP7QTcsL4M=; b=BXwbjyQHcxJWNiy0iXKopawMWLVVLer31/iixLJkLYJrr0DN6W/g3Yxd8AhYLMw4GY yaOOYp6clpQlM8wBCeAsr7WNscSUW0a/CNbCltgSRmtM67DKbQ4DtyJUrsqntno1wI5y 6L8iL7u4BsmyrJM63Dgery3dZ3UK4EZQgDH+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JE8U2Fghv6YjjweCRTqDn5FZUlMFhhM8tZP7QTcsL4M=; b=d7STCR3oFyt/srHkOA27vp/aAOwoQcpmp3m1z1z7VYlFCRnV73FgMKty4yHcvVF0M0 TW8GlJIRGLY+jAqn58QpKZT5T7rG/XrKo2vsSiVc1mggDWGOo1cHEO37v0Z75pctT7li IS6ULs3JOYaFL4hovgtBp0SlgfMEiprWZGqlhfbv8vCyvq+FGLlaNH0lMNzDBtQOnNAO YGyPpoUMFJVfhTBwrNXApw+Rgr4TRCJ7EopidCHq+2RgDDUA3D3IcI6Ip5dqLzsz4TLX 8ttI8XFvXXqgEdl5uIV2BbtoK/ZykRmh0H+JvM0rY8GaRvmbyjSTrA85L6VAdHqUtb4K 6I9Q== X-Gm-Message-State: APjAAAWQRmCcf4L237VKjnTlMNup0hwZ6dewDfwKe7ntz5uXEf+ZHyGH bEJv/buhDQol3hJCPjXIHQkNsQ== X-Received: by 2002:aa7:96a9:: with SMTP id g9mr23757769pfk.147.1571674020135; Mon, 21 Oct 2019 09:07:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x139sm18509941pgx.92.2019.10.21.09.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 09:06:59 -0700 (PDT) Date: Mon, 21 Oct 2019 09:06:58 -0700 From: Kees Cook To: Ard Biesheuvel Cc: Sami Tolvanen , Will Deacon , Catalin Marinas , Steven Rostedt , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Subject: Re: [PATCH 16/18] arm64: kprobes: fix kprobes without CONFIG_KRETPROBES Message-ID: <201910210905.7494C5C@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-17-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 08:21:48AM +0200, Ard Biesheuvel wrote: > On Fri, 18 Oct 2019 at 18:11, Sami Tolvanen wrote: > > > > This allows CONFIG_KRETPROBES to be disabled without disabling > > kprobes entirely. > > > > Signed-off-by: Sami Tolvanen > > Can we make kretprobes work with the shadow call stack instead? I've been viewing that as "next steps". This series is the first step: actually gaining the feature and clearly indicating where future improvements can live. -- Kees Cook