Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Matteo Croce <mcroce@redhat.com>
CC:     Joe Perches <joe@perches.com>, Doug Ledford <dledford@redhat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Potnuri Bharat Teja <bharat@chelsio.com>
Subject: Re: linux-next: Fixes tag needs some work in the rdma-fixes tree
Thread-Topic: linux-next: Fixes tag needs some work in the rdma-fixes tree
Thread-Index: AQHVh+L3TKVLX91rm0q8yD/5yy/ydKdlLgGAgAAG3YCAAAa0AIAAFu+AgAACAICAAAD9gA==
Date:   Mon, 21 Oct 2019 17:11:58 +0000
Message-ID: <20191021171153.GC6285@mellanox.com>
References: <20191021184128.601ff09d@canb.auug.org.au>
 <c4377d50c8a30ae292cd7886909238ce4fb56ee5.camel@redhat.com>
 <20191021151507.GD25164@mellanox.com>
 <CAGnkfhzCuCUBG++QRTZbsUyFr8orq059Be7AvyL+_V9Smz7J3g@mail.gmail.com>
 <20191021170111.GB6285@mellanox.com>
 <CAGnkfhwsczOBLMZSJ0pWm=L3bMqgd4mWNitpZB3-NwjFN+fYDA@mail.gmail.com>
In-Reply-To: <CAGnkfhwsczOBLMZSJ0pWm=L3bMqgd4mWNitpZB3-NwjFN+fYDA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [142.162.113.180]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 54f7fe47-5b47-41b1-1b88-08d75649c7da
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: VI1PR05MB5534:
x-microsoft-antispam-prvs: <VI1PR05MB55346E5B0B8B7DF4DC67D229CF690@VI1PR05MB5534.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0197AFBD92
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(189003)(199004)(8936002)(2906002)(66946007)(81156014)(71190400001)(64756008)(66556008)(66476007)(66446008)(71200400001)(7736002)(305945005)(81166006)(6916009)(8676002)(1076003)(66066001)(25786009)(5660300002)(54906003)(86362001)(256004)(6512007)(186003)(2616005)(446003)(4326008)(6246003)(36756003)(52116002)(3846002)(102836004)(6116002)(26005)(478600001)(99286004)(316002)(53546011)(6506007)(386003)(76176011)(6486002)(229853002)(33656002)(14454004)(6436002)(476003)(11346002)(486006);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5534;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: A+Bo1dVk52iQjzfQCByxL/YzYJlfIVLh8Kuu65ZrxsxfZvrNNymq9LCvINOfc68L7bSTZ/z23Mdu85nQruKsrtrr7FsHi+STBOtbRYRJ5GrFvDhGZGNKxgPJFG9aDx5zJioMVm3t/Wq/cInTDHhksQ//uXoS3z2qaueG+LyrAV/7tOJDfH9Cf9FWLmWoT0QxBUpuyZ0CGROmWT4Bvyzj7UGfsK8KTFMog9hTu/IXpfvpabixFoFHKGhzj4fcATmV7dpBDDiSl4ipI+PU9mPfq83bvAwOxDWcCmS+U+RKnnZ44BNwekaxFTT18UsZ51T3EA4TOMMmAdP/d7MuZ+ZfmxBNNstg7xNc4+UBUTGU/QVfLze4PdZdu1IcoD5aTKfv5b5/VUVvJsUc5sfHLXl4Gk5oKEyJheMdAdWkF5sFk7M=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0E10C059A5456342B8C356B8E079A85A@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54f7fe47-5b47-41b1-1b88-08d75649c7da
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 17:11:58.4264
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: orgrdnIVtySDxp+s+F9eR39la4U2R1w5mWducEzeUJVzEBM4Xuyn8kcl0ugQlYDkl3SMeL96313BbiRB6/PnkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5534
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 21, 2019 at 07:08:21PM +0200, Matteo Croce wrote:
> On Mon, Oct 21, 2019 at 7:01 PM Jason Gunthorpe <jgg@mellanox.com> wrote:
> >
> > On Mon, Oct 21, 2019 at 05:39:06PM +0200, Matteo Croce wrote:
> > > > I thought I saw that checkpatch was checking this now?
> > > >
> > > > commit a8dd86bf746256fbf68f82bc13356244c5ad8efa
> > > > Author: Matteo Croce <mcroce@redhat.com>
> > > > Date:   Wed Sep 25 16:46:38 2019 -0700
> > > >
> > > >     checkpatch.pl: warn on invalid commit id
> > > >
> > > > Maybe that check should also check that enough hash is provided and
> > > > other details like the correct subject line?
> > > >
> > > > I also use a check that builds the fixes line from the commit id an=
d
> > > > requires it to be the same as the patch provided. This catches all
> > > > sorts of wrong fixes lines, and sometimes git even recommends 13 ch=
ars
> > > > :\
> > > >
> > > > Jason
> > >
> > > Hi,
> > >
> > > actually I just call git_commit_info() which checks for validness.
> > > I could also check that the hash is at least 12 digits, would be very=
 easy.
> >
> > IMHO you should do
> >
> >   git log --abbrev=3D12 -1 --format=3D'Fixes: %h (\"%s\")'
> >
> > And check that the provided fixes line matches the above output
> > exactly, or nearly exactly. People do lots of funny things to fixes
> > lines..
> >
>=20
> The point in using git_commit_info() instead of calling git directly
> is that the latter would generate an error if the working copy is not
> a git tree (e.g. a tar.xz downloaded from kernel.org).

Well, it does some checks and calls 'git log' so it seems like it
could learn to call git log with different arguments, right?

Jason=20