Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Joe Perches <joe@perches.com>
CC:     Matteo Croce <mcroce@redhat.com>,
        Doug Ledford <dledford@redhat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Potnuri Bharat Teja <bharat@chelsio.com>
Subject: Re: linux-next: Fixes tag needs some work in the rdma-fixes tree
Thread-Topic: linux-next: Fixes tag needs some work in the rdma-fixes tree
Thread-Index: AQHVh+L3TKVLX91rm0q8yD/5yy/ydKdlLgGAgAAG3YCAAAa0AIAAFu+AgAACAICAAAD9gIAAA9uAgAAD0oA=
Date:   Mon, 21 Oct 2019 17:39:25 +0000
Message-ID: <20191021173921.GD6285@mellanox.com>
References: <20191021184128.601ff09d@canb.auug.org.au>
 <c4377d50c8a30ae292cd7886909238ce4fb56ee5.camel@redhat.com>
 <20191021151507.GD25164@mellanox.com>
 <CAGnkfhzCuCUBG++QRTZbsUyFr8orq059Be7AvyL+_V9Smz7J3g@mail.gmail.com>
 <20191021170111.GB6285@mellanox.com>
 <CAGnkfhwsczOBLMZSJ0pWm=L3bMqgd4mWNitpZB3-NwjFN+fYDA@mail.gmail.com>
 <20191021171153.GC6285@mellanox.com>
 <d3a389360982c9d2730e6b29eb96523a562483ac.camel@perches.com>
In-Reply-To: <d3a389360982c9d2730e6b29eb96523a562483ac.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [142.162.113.180]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5b3415c-28ce-47e0-3742-08d7564d9dae
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: VI1PR05MB3199:
x-microsoft-antispam-prvs: <VI1PR05MB31993D51B071F8D74A97408FCF690@VI1PR05MB3199.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1850;
x-forefront-prvs: 0197AFBD92
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(39860400002)(376002)(396003)(346002)(199004)(189003)(7736002)(6246003)(14454004)(5660300002)(3846002)(305945005)(25786009)(71190400001)(6116002)(86362001)(26005)(99286004)(102836004)(36756003)(33656002)(71200400001)(386003)(316002)(6436002)(186003)(6486002)(478600001)(486006)(6916009)(54906003)(2616005)(66066001)(446003)(256004)(14444005)(6506007)(4001150100001)(52116002)(76176011)(81166006)(8936002)(6512007)(476003)(2906002)(53546011)(4326008)(1076003)(11346002)(66946007)(66556008)(64756008)(229853002)(66476007)(66446008)(8676002)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB3199;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6nvPbwAK7VNUcHoZ/I6Aw9c0X532bz1V3J2/Ar+5WB1RSSs8gWJyxK/QBaSg4e49Weu8c0bfOI/qBgvh+usN1pajLhLjvL0+uTNpTawhYIKTe1QLHPhigQlR3+cirZxIimtSMWNFAdgwW8r2UkdWq1OhtqG87FqNT2c585M39RS7XwguaMjHzkxP4A/+gzFQ3GiL17GSGC81T7PlRjRaki1pnVo0D5b6SgNfTRNU1+ZIFDPPwHtiPlntEou224T6x9Ls9dIxWFxNaiOkUufLlBIc8u48hq+uDd3jKupfyJW+v9rbYprl0Hog1qmTrlbHxP1XYbw7r+IhT/BtG0es0qXeZSqme4VSyPWTmTYsipU/IEi5XsOhyn+Zg3j5/3XJYqNJ9mwGSZ3sKjIZ2TxOiKZiYXglblPx3cGzO59DN4M=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <737C8B349830954A8C665DDF6D61B5B0@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5b3415c-28ce-47e0-3742-08d7564d9dae
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 17:39:25.5954
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3woqn9h/4JcNVXPVTa4ebnyc/k84ZR89Bj7H9HjVLak+Xy78NKysW7SrwSc9vk5TtdmHtn6opiFk8Vctx3P+Bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3199
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 21, 2019 at 10:25:41AM -0700, Joe Perches wrote:
> On Mon, 2019-10-21 at 17:11 +0000, Jason Gunthorpe wrote:
> > On Mon, Oct 21, 2019 at 07:08:21PM +0200, Matteo Croce wrote:
> > > On Mon, Oct 21, 2019 at 7:01 PM Jason Gunthorpe <jgg@mellanox.com> wr=
ote:
> > > > On Mon, Oct 21, 2019 at 05:39:06PM +0200, Matteo Croce wrote:
> > > > > > I thought I saw that checkpatch was checking this now?
> > > > > >=20
> > > > > > commit a8dd86bf746256fbf68f82bc13356244c5ad8efa
> > > > > > Author: Matteo Croce <mcroce@redhat.com>
> > > > > > Date:   Wed Sep 25 16:46:38 2019 -0700
> > > > > >=20
> > > > > >     checkpatch.pl: warn on invalid commit id
> > > > > >=20
> > > > > > Maybe that check should also check that enough hash is provided=
 and
> > > > > > other details like the correct subject line?
> > > > > >=20
> > > > > > I also use a check that builds the fixes line from the commit i=
d and
> > > > > > requires it to be the same as the patch provided. This catches =
all
> > > > > > sorts of wrong fixes lines, and sometimes git even recommends 1=
3 chars
> > > > > > :\
> > > > > >=20
> > > > > > Jason
> > > > >=20
> > > > > Hi,
> > > > >=20
> > > > > actually I just call git_commit_info() which checks for validness=
.
> > > > > I could also check that the hash is at least 12 digits, would be =
very easy.
> > > >=20
> > > > IMHO you should do
> > > >=20
> > > >   git log --abbrev=3D12 -1 --format=3D'Fixes: %h (\"%s\")'
> > > >=20
> > > > And check that the provided fixes line matches the above output
> > > > exactly, or nearly exactly. People do lots of funny things to fixes
> > > > lines..
> > > >=20
> > >=20
> > > The point in using git_commit_info() instead of calling git directly
> > > is that the latter would generate an error if the working copy is not
> > > a git tree (e.g. a tar.xz downloaded from kernel.org).
> >=20
> > Well, it does some checks and calls 'git log' so it seems like it
> > could learn to call git log with different arguments, right?
>=20
> git commit SHA1's are not just 12 chars and could be any length.

--abbrev forces a minimum bound to the kernel recommendation if the
user has an old git or misconfigured git. git auto-detects if it needs
more digits beyond 12.

> And checkpatch already does use specific arguments
>=20
> 	my $output =3D `${git_command} log --no-color --format=3D'%H %s' -1 $com=
mit 2>&1`;
>=20
> and then parses that $output.

Maybe output format "%H %h %s" and then parse it to check the min
length and verify the subject?

Jason